From fde8e5f175b0de76fb87d14c741b46df076d27a1 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Wed, 23 Nov 2022 22:02:53 -0600 Subject: [PATCH 1/3] pants: silence un-actionable unowned dep warnings --- pants.toml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pants.toml b/pants.toml index 3ddbf7b88f..ce8c8bdbb9 100644 --- a/pants.toml +++ b/pants.toml @@ -84,6 +84,16 @@ root_patterns = [ "/st2common/benchmarks/micro", ] +[python-infer] +# https://www.pantsbuild.org/docs/reference-python-infer#unowned_dependency_behavior +# The default changed from "ignore" to "warning" in pants 2.14. +# Many of the new warnings however have been adressed via explicit deps, +# so the warnings are not helpful. In pants 2.16, a "visibility" feature might help +# us to disambiguate deps between files without those explicit BUILD dependencies, +# and without adding "# pants: no-infer-dep" comments all over the codebase. +# Revisit this in pants 2.16 to see if it is feasible to use the default "warning". +unowned_dependency_behavior = "ignore" + [bandit] lockfile = "lockfiles/bandit.lock" version = "bandit==1.7.0" From 57a02db4f673f0450d6aedfdc0252830c4d59964 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Thu, 3 Nov 2022 22:33:32 -0500 Subject: [PATCH 2/3] bump to pants 2.14.0 --- pants.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pants.toml b/pants.toml index ce8c8bdbb9..a0d10cac67 100644 --- a/pants.toml +++ b/pants.toml @@ -6,7 +6,7 @@ enabled = false repo_id = "de0dea7a-9f6a-4c6e-aa20-6ba5ad969b8a" [GLOBAL] -pants_version = "2.14.0rc3" +pants_version = "2.14.0" backend_packages = [ # python "pants.backend.python", From 626e592f37e69797a69b981850f84af537c8d83d Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Wed, 23 Nov 2022 22:12:01 -0600 Subject: [PATCH 3/3] update changelog entry --- CHANGELOG.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index e7b64c505d..5b1aecb27e 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -10,7 +10,7 @@ Added * Continue introducing `pants `_ to improve DX (Developer Experience) working on StackStorm, improve our security posture, and improve CI reliability thanks in part to pants' use of PEX lockfiles. This is not a user-facing addition. - #5778 #5789 + #5778 #5789 #5817 Contributed by @cognifloyd