Use master branch of st2-docker. #194
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
previously approved these changes
Nov 16, 2025
cognifloyd
reviewed
Nov 16, 2025
| git clone --branch ${ST2_DOCKER_BRANCH:-DEPRECATED/all-in-one} --depth 1 ${ST2_TEST_ENVIRONMENT} ~/st2-docker | ||
| echo "Cloning ${ST2_DOCKER_BRANCH:-master} branch of st2-docker" | ||
| git clone --branch ${ST2_DOCKER_BRANCH:-master} --depth 1 ${ST2_TEST_ENVIRONMENT} ~/st2-docker | ||
| make -C ~/st2-docker env |
Member
There was a problem hiding this comment.
Oh. Apparently this target is missing on the master branch. That's why CI is failing.
Contributor
Author
There was a problem hiding this comment.
I've marked this as draft. I think switching to the master branch will require work on circle ci because it's designed around the all in one docker instance.
cognifloyd
dismissed
their stale review
Approved too quickly, before reviewing CI failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.