From 215269dba05980f835be99f13858415a738bdfa6 Mon Sep 17 00:00:00 2001
From: Pradnya Bhagwat <pradnya@orchestral.ai>
Date: Tue, 29 Jun 2021 15:49:30 +0530
Subject: [PATCH 1/4] Changes for Delete Action/workflow functionality

---
 apps/st2-actions/actions-details.component.js | 21 +++++++++++++--
 apps/st2-actions/actions-panel.component.js   | 27 ++++++++++++++++---
 apps/st2-actions/store.js                     | 26 ++++++++++++++++++
 3 files changed, 69 insertions(+), 5 deletions(-)

diff --git a/apps/st2-actions/actions-details.component.js b/apps/st2-actions/actions-details.component.js
index 99d780e30..5b44d71e5 100644
--- a/apps/st2-actions/actions-details.component.js
+++ b/apps/st2-actions/actions-details.component.js
@@ -57,6 +57,7 @@ export default class ActionsDetails extends React.Component {
   static propTypes = {
     handleNavigate: PropTypes.func.isRequired,
     handleRun: PropTypes.func.isRequired,
+    handleDelete: PropTypes.func.isRequired,
 
     id: PropTypes.string,
     section: PropTypes.string,
@@ -127,10 +128,10 @@ export default class ActionsDetails extends React.Component {
     }
   }
 
-  
-
   componentDidUpdate(prevProps) {
+    console.log('inside did update prevprops',prevProps);
     const { id } = this.props;
+    console.log('id',id);
     if (id && id !== prevProps.id) {
       this.fetchAction(id);
     }
@@ -242,8 +243,22 @@ export default class ActionsDetails extends React.Component {
     return this.props.handleRun(...args);
   }
 
+  handleDelete (ref) {
+    const { id } = this.props;
+
+    console.log('id',id);
+
+    if (!window.confirm('Do you really want to delete this item?')) {
+      return undefined;
+    }
+    const res = this.props.handleDelete(id);
+    
+    return res;
+  }
+
   render() {
     const { section, action, executions, entrypoint } = this.props;
+    console.log('action',action);
     if (!action) {
       return null;
     }
@@ -281,6 +296,8 @@ export default class ActionsDetails extends React.Component {
               />
               <Button flat value="Preview" onClick={() => this.handleToggleRunPreview()} />
               <DetailsToolbarSeparator />
+              <Button className="st2-forms__button st2-details__toolbar-button"  value="Delete" onClick={() => this.handleDelete()}  />
+
               { action.runner_type === 'mistral-v2' || action.runner_type === 'orquesta' ? (
                 <Link
                   target="_blank"
diff --git a/apps/st2-actions/actions-panel.component.js b/apps/st2-actions/actions-panel.component.js
index 5cc5564d5..4ffbe03ca 100644
--- a/apps/st2-actions/actions-panel.component.js
+++ b/apps/st2-actions/actions-panel.component.js
@@ -116,7 +116,6 @@ export default class ActionsPanel extends React.Component {
       .then(() => {
         const { id } = this.urlParams;
         const { groups } = this.props;
-
         if (id && groups && !groups.some(({ actions }) => actions.some(({ ref }) => ref === id))) {
           this.navigate({ id: false });
         }
@@ -128,8 +127,7 @@ export default class ActionsPanel extends React.Component {
     const {
       ref = get('groups[0].actions[0].ref', this.props),
       section = 'general',
-    } = this.props.match.params;
-
+    } = this.props.match.params;  
     return {
       id: ref,
       section,
@@ -211,6 +209,28 @@ export default class ActionsPanel extends React.Component {
     });
   }
 
+  handleDelete (ref) {
+    return store.dispatch({
+      type: 'DELETE_ACTION',
+      ref,
+      promise: api.request({
+        method: 'delete',
+        path: `/actions/${ref}`,
+      })
+        .then((res) => {
+          notification.success(`Action "${ref}" has been deleted successfully.`);
+          return res;
+        })
+        .catch((err) => {
+          notification.error(`Unable to delete action "${ref}".`, {
+            err,
+            
+          });
+          throw err;
+        }),
+    });
+  }
+
   render() {
     const { groups, filter, collapsed } = this.props;
     const { id, section } = this.urlParams;
@@ -282,6 +302,7 @@ export default class ActionsPanel extends React.Component {
           ref={(ref) => this._details = ref}
           handleNavigate={(...args) => this.navigate(...args)}
           handleRun={(...args) => this.handleRun(...args)}
+          handleDelete={(...arg) => this.handleDelete(...arg)}
 
           id={id}
           section={section}
diff --git a/apps/st2-actions/store.js b/apps/st2-actions/store.js
index 45982befc..333e2c771 100644
--- a/apps/st2-actions/store.js
+++ b/apps/st2-actions/store.js
@@ -154,6 +154,32 @@ const actionReducer = (state = {}, input) => {
       };
     }
 
+    case 'DELETE_ACTION': {
+      const { ref } = input;
+
+      
+
+      switch(input.status) {
+        case 'success':
+          action = [ ...actions ]
+            .filter(action => action.ref !== ref)
+          ;
+          groups = makeGroups( action, filter);
+
+          break;
+        case 'error':
+          break;
+        default:
+          break;
+      }
+
+      return {
+        ...state,
+        action,
+        groups,
+      };
+    }
+
     case 'SET_FILTER': {
       filter = input.filter;
       groups = makeGroups(actions, filter);

From b64fa872d35325847b811aecf490ee2d691f13c6 Mon Sep 17 00:00:00 2001
From: Pradnya Bhagwat <pradnya@orchestral.ai>
Date: Tue, 29 Jun 2021 15:56:33 +0530
Subject: [PATCH 2/4] Changes for Delete action/workflow and removed console

---
 apps/st2-actions/actions-details.component.js | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/apps/st2-actions/actions-details.component.js b/apps/st2-actions/actions-details.component.js
index 5b44d71e5..a79b0a318 100644
--- a/apps/st2-actions/actions-details.component.js
+++ b/apps/st2-actions/actions-details.component.js
@@ -129,9 +129,7 @@ export default class ActionsDetails extends React.Component {
   }
 
   componentDidUpdate(prevProps) {
-    console.log('inside did update prevprops',prevProps);
     const { id } = this.props;
-    console.log('id',id);
     if (id && id !== prevProps.id) {
       this.fetchAction(id);
     }
@@ -246,19 +244,14 @@ export default class ActionsDetails extends React.Component {
   handleDelete (ref) {
     const { id } = this.props;
 
-    console.log('id',id);
-
     if (!window.confirm('Do you really want to delete this item?')) {
       return undefined;
     }
-    const res = this.props.handleDelete(id);
-    
-    return res;
+    return this.props.handleDelete(id);
   }
 
   render() {
     const { section, action, executions, entrypoint } = this.props;
-    console.log('action',action);
     if (!action) {
       return null;
     }

From 9f1ad1a4ca8852222bb0efdbfec7969c8f16098d Mon Sep 17 00:00:00 2001
From: Pradnya Bhagwat <pradnya@orchestral.ai>
Date: Fri, 2 Jul 2021 17:02:32 +0530
Subject: [PATCH 3/4] Changed confirmation message and resolved refresh data
 issue after delete

---
 apps/st2-actions/actions-details.component.js | 2 +-
 apps/st2-actions/store.js                     | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/apps/st2-actions/actions-details.component.js b/apps/st2-actions/actions-details.component.js
index a79b0a318..4716341e9 100644
--- a/apps/st2-actions/actions-details.component.js
+++ b/apps/st2-actions/actions-details.component.js
@@ -244,7 +244,7 @@ export default class ActionsDetails extends React.Component {
   handleDelete (ref) {
     const { id } = this.props;
 
-    if (!window.confirm('Do you really want to delete this item?')) {
+    if (!window.confirm(`You are about to delete the action "${id}". This operation is irreversible. Are you sure?`)) {
       return undefined;
     }
     return this.props.handleDelete(id);
diff --git a/apps/st2-actions/store.js b/apps/st2-actions/store.js
index 333e2c771..80df2dce7 100644
--- a/apps/st2-actions/store.js
+++ b/apps/st2-actions/store.js
@@ -161,10 +161,10 @@ const actionReducer = (state = {}, input) => {
 
       switch(input.status) {
         case 'success':
-          action = [ ...actions ]
+          actions = [ ...actions ]
             .filter(action => action.ref !== ref)
           ;
-          groups = makeGroups( action, filter);
+          groups = makeGroups( actions, filter);
 
           break;
         case 'error':
@@ -175,7 +175,7 @@ const actionReducer = (state = {}, input) => {
 
       return {
         ...state,
-        action,
+        actions,
         groups,
       };
     }

From 4ba1ac16ceba384afeb0779563fc9ae89ae5b7e4 Mon Sep 17 00:00:00 2001
From: Pradnya Bhagwat <pradnya@orchestral.ai>
Date: Wed, 18 Aug 2021 10:48:05 +0530
Subject: [PATCH 4/4] Resolved data updation issue page after action deletion

---
 apps/st2-actions/actions-panel.component.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/apps/st2-actions/actions-panel.component.js b/apps/st2-actions/actions-panel.component.js
index 4ffbe03ca..ee24a3343 100644
--- a/apps/st2-actions/actions-panel.component.js
+++ b/apps/st2-actions/actions-panel.component.js
@@ -55,7 +55,6 @@ import './style.css';
   return { collapsed, ...props };
 }, (dispatch, props) => {
   const { uid } = props;
-
   return {
     onToggle: () => store.dispatch(flexActions.toggle(uid)),
   };
@@ -219,6 +218,8 @@ export default class ActionsPanel extends React.Component {
       })
         .then((res) => {
           notification.success(`Action "${ref}" has been deleted successfully.`);
+          this.navigate({ id: null });
+          store.dispatch(flexActions.toggleAll());
           return res;
         })
         .catch((err) => {