From fec18456431893338ac569f5fc32e2446cc71c29 Mon Sep 17 00:00:00 2001 From: Andrew Emil Date: Thu, 29 Mar 2018 09:46:48 -0400 Subject: [PATCH 1/7] Add test for GetNodeMetadata in kubernetes --- src/kubernetes.h | 1 + test/Makefile | 25 +++++++++++-- test/kubernetes_unittest.cc | 70 +++++++++++++++++++++++++++++++++++++ 3 files changed, 94 insertions(+), 2 deletions(-) create mode 100644 test/kubernetes_unittest.cc diff --git a/src/kubernetes.h b/src/kubernetes.h index 46ccf494..1ca245ca 100644 --- a/src/kubernetes.h +++ b/src/kubernetes.h @@ -60,6 +60,7 @@ class KubernetesReader { const std::string& CurrentNode() const; private: + friend class KubernetesTest; // A representation of all query-related errors. class QueryException { public: diff --git a/test/Makefile b/test/Makefile index 5214c799..9ecd9c65 100644 --- a/test/Makefile +++ b/test/Makefile @@ -9,18 +9,29 @@ GMOCK_DIR=$(LIBDIR)/googletest/googlemock # TODO: Factor out the common variables. CPP_NETLIB_DIR=$(LIBDIR)/cpp-netlib +CPP_NETLIB_LIBDIR=$(CPP_NETLIB_DIR)/libs/network/src +NETWORK_URI_DIR=$(CPP_NETLIB_DIR)/deps/uri +NETWORK_URI_LIBDIR=$(NETWORK_URI_DIR)/src YAML_CPP_DIR=$(LIBDIR)/yaml-cpp YAML_CPP_LIBDIR=$(YAML_CPP_DIR) +CPP_NETLIB_LIBS=\ + $(CPP_NETLIB_LIBDIR)/libcppnetlib-client-connections.a \ + $(CPP_NETLIB_LIBDIR)/libcppnetlib-server-parsers.a \ + $(NETWORK_URI_LIBDIR)/libnetwork-uri.a YAML_CPP_LIBS=$(YAML_CPP_LIBDIR)/libyaml-cpp.a CPPFLAGS+= \ + -DENABLE_KUBERNETES_METADATA \ -isystem $(GTEST_DIR)/include -I$(GMOCK_DIR)/include \ -I$(YAML_CPP_DIR)/include CXXFLAGS=\ -std=c++11 -g -pthread -Wno-write-strings -Wno-deprecated -LDLIBS=-lpthread -lboost_program_options -lyaml-cpp -lyajl -LDFLAGS=-L$(YAML_CPP_LIBDIR) +LDLIBS=\ + -lcppnetlib-client-connections -lcppnetlib-server-parsers -lnetwork-uri \ + -lpthread -lboost_program_options -lboost_system -lboost_thread \ + -lboost_filesystem -lyaml-cpp -lyajl -lcrypto -lssl +LDFLAGS=-L$(CPP_NETLIB_LIBDIR) -L$(NETWORK_URI_LIBDIR) -L$(YAML_CPP_LIBDIR) # Where to find code under test. SRC_DIR=../src @@ -34,6 +45,7 @@ TESTS=\ format_unittest \ health_checker_unittest \ json_unittest \ + kubernetes_unittest \ resource_unittest \ time_unittest @@ -63,6 +75,9 @@ init-submodules: $(YAML_CPP_LIBS): cd $(SRC_DIR) && $(MAKE) $@ +$(CPP_NETLIB_LIBS): + cd $(SRC_DIR) && $(MAKE) $@ + $(SRC_DIR)/%.o: $(SRC_DIR)/%.cc cd $(SRC_DIR) && $(MAKE) $(@:$(SRC_DIR)/%=%) @@ -83,6 +98,12 @@ base64_unittest: $(GTEST_LIB) base64_unittest.o $(SRC_DIR)/base64.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ configuration_unittest: $(GTEST_LIB) $(YAML_CPP_LIBS) configuration_unittest.o $(SRC_DIR)/configuration.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ +kubernetes_unittest: $(GTEST_LIB) kubernetes_unittest.o $(SRC_DIR)/kubernetes.o + $(SRC_DIR)/json.o $(SRC_DIR)/logging.o $(SRC_DIR)/environment.o + $(SRC_DIR)/time.o $(SRC_DIR)/store.o $(SRC_DIR)/resource.o + $(SRC_DIR)/updater.o $(SRC_DIR)/instance.o $(SRC_DIR)/format.o + $(SRC_DIR)/configuration.o $(SRC_DIR)/health_checker.o + $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ resource_unittest: $(GTEST_LIB) resource_unittest.o $(SRC_DIR)/resource.o $(SRC_DIR)/json.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ time_unittest: $(GTEST_LIB) time_unittest.o $(SRC_DIR)/time.o diff --git a/test/kubernetes_unittest.cc b/test/kubernetes_unittest.cc new file mode 100644 index 00000000..31b588df --- /dev/null +++ b/test/kubernetes_unittest.cc @@ -0,0 +1,70 @@ +#include "../src/kubernetes.h" +#include "../src/updater.h" +#include "../src/configuration.h" +#include "../src/instance.h" +#include "gtest/gtest.h" + +namespace google { + +class KubernetesTest : public ::testing::Test { + protected: + MetadataUpdater::ResourceMetadata GetNodeMetadata( + const KubernetesReader& reader, const json::Object *node, + Timestamp collected_at, bool is_deleted) const + throw(json::Exception) { + return reader.GetNodeMetadata(node, collected_at, is_deleted); + } +}; + +TEST_F(KubernetesTest, GetNodeMetadata) { + Configuration config(std::stringstream( + "KubernetesClusterName: 'TestClusterName'\n" + "KubernetesClusterLocation: 'TestClusterLocation'\n" + "MetadataIngestionRawContentVersion: 'TestVersion'\n" + "InstanceZone: 'TestZone'\n" + "InstanceId: 'TestID'\n" + )); + Environment environment(config); + KubernetesReader reader(config, nullptr); + json::value node_json = json::object({ + {"metadata", json::object({ + {"name", json::string("testname")}, + {"creationTimestamp", json::string("2018-03-03T01:23:45.678901234Z")} + })} + }); + const json::Object* node = node_json->As(); + MetadataUpdater::ResourceMetadata metadata( + GetNodeMetadata(reader, node, Timestamp(), false)); + EXPECT_EQ(metadata.ids.size(), 1); + EXPECT_EQ(metadata.ids[0], "k8s_node.testname"); + EXPECT_EQ(metadata.resource, + MonitoredResource("k8s_node", { + {"cluster_name", "TestClusterName"}, + {"node_name", "testname"}, + {"location", "TestClusterLocation"} + })); + EXPECT_EQ(metadata.metadata.version, "TestVersion"); + EXPECT_EQ(metadata.metadata.is_deleted, false); + EXPECT_EQ(metadata.metadata.created_at, + time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z")); + EXPECT_EQ(metadata.metadata.collected_at, Timestamp()); + json::value big = json::object({ + {"blobs", json::object({ + {"association", json::object({ + {"version", json::string("TestVersion")}, + {"raw", json::object({ + {"infrastructureResource", + InstanceReader::InstanceResource(environment).ToJSON()}, + })}, + })}, + {"api", json::object({ + // 1.6 is hardcoded as kKubernetesApiVersion + {"version", json::string("1.6")}, + {"raw", node->Clone()}, + })}, + })}, + }); + EXPECT_EQ(big->As()->ToString(), + metadata.metadata.metadata->As()->ToString()); +} +} // namespace google From b0a054180a755cb5a4f370f32fad492fca012890 Mon Sep 17 00:00:00 2001 From: Andrew Emil Date: Thu, 29 Mar 2018 15:22:12 -0400 Subject: [PATCH 2/7] Addressed code review comments --- src/kubernetes.cc | 8 +++-- test/Makefile | 16 ++++------ test/kubernetes_unittest.cc | 58 +++++++++++++++++-------------------- 3 files changed, 39 insertions(+), 43 deletions(-) diff --git a/src/kubernetes.cc b/src/kubernetes.cc index f4c4da44..63c9b2cc 100644 --- a/src/kubernetes.cc +++ b/src/kubernetes.cc @@ -1143,7 +1143,9 @@ void KubernetesReader::WatchPods( } catch (const KubernetesReader::QueryException& e) { LOG(ERROR) << "No more pod metadata will be collected"; } - health_checker_->SetUnhealthy("kubernetes_pod_thread"); + if (health_checker_) { + health_checker_->SetUnhealthy("kubernetes_pod_thread"); + } LOG(INFO) << "Watch thread (pods) exiting"; } @@ -1176,7 +1178,9 @@ void KubernetesReader::WatchNodes( } catch (const KubernetesReader::QueryException& e) { LOG(ERROR) << "No more node metadata will be collected"; } - health_checker_->SetUnhealthy("kubernetes_node_thread"); + if (health_checker) { + health_checker_->SetUnhealthy("kubernetes_node_thread"); + } LOG(INFO) << "Watch thread (node) exiting"; } diff --git a/test/Makefile b/test/Makefile index 9ecd9c65..3aec08f3 100644 --- a/test/Makefile +++ b/test/Makefile @@ -27,11 +27,11 @@ CPPFLAGS+= \ -I$(YAML_CPP_DIR)/include CXXFLAGS=\ -std=c++11 -g -pthread -Wno-write-strings -Wno-deprecated +LDFLAGS=-L$(CPP_NETLIB_LIBDIR) -L$(NETWORK_URI_LIBDIR) -L$(YAML_CPP_LIBDIR) LDLIBS=\ -lcppnetlib-client-connections -lcppnetlib-server-parsers -lnetwork-uri \ - -lpthread -lboost_program_options -lboost_system -lboost_thread \ - -lboost_filesystem -lyaml-cpp -lyajl -lcrypto -lssl -LDFLAGS=-L$(CPP_NETLIB_LIBDIR) -L$(NETWORK_URI_LIBDIR) -L$(YAML_CPP_LIBDIR) + -lboost_program_options -lboost_system -lboost_thread -lboost_filesystem \ + -lpthread -lyajl -lssl -lcrypto -lyaml-cpp # Where to find code under test. SRC_DIR=../src @@ -72,10 +72,10 @@ init-submodules: git submodule update --init $(GTEST_MODULE) touch init-submodules -$(YAML_CPP_LIBS): +$(CPP_NETLIB_LIBS): cd $(SRC_DIR) && $(MAKE) $@ -$(CPP_NETLIB_LIBS): +$(YAML_CPP_LIBS): cd $(SRC_DIR) && $(MAKE) $@ $(SRC_DIR)/%.o: $(SRC_DIR)/%.cc @@ -98,11 +98,7 @@ base64_unittest: $(GTEST_LIB) base64_unittest.o $(SRC_DIR)/base64.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ configuration_unittest: $(GTEST_LIB) $(YAML_CPP_LIBS) configuration_unittest.o $(SRC_DIR)/configuration.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ -kubernetes_unittest: $(GTEST_LIB) kubernetes_unittest.o $(SRC_DIR)/kubernetes.o - $(SRC_DIR)/json.o $(SRC_DIR)/logging.o $(SRC_DIR)/environment.o - $(SRC_DIR)/time.o $(SRC_DIR)/store.o $(SRC_DIR)/resource.o - $(SRC_DIR)/updater.o $(SRC_DIR)/instance.o $(SRC_DIR)/format.o - $(SRC_DIR)/configuration.o $(SRC_DIR)/health_checker.o +kubernetes_unittest: $(GTEST_LIB) kubernetes_unittest.o $(SRC_DIR)/kubernetes.o $(SRC_DIR)/json.o $(SRC_DIR)/logging.o $(SRC_DIR)/environment.o $(SRC_DIR)/time.o $(SRC_DIR)/store.o $(SRC_DIR)/resource.o $(SRC_DIR)/updater.o $(SRC_DIR)/instance.o $(SRC_DIR)/format.o $(SRC_DIR)/configuration.o $(SRC_DIR)/health_checker.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ resource_unittest: $(GTEST_LIB) resource_unittest.o $(SRC_DIR)/resource.o $(SRC_DIR)/json.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ diff --git a/test/kubernetes_unittest.cc b/test/kubernetes_unittest.cc index 31b588df..1fbdb804 100644 --- a/test/kubernetes_unittest.cc +++ b/test/kubernetes_unittest.cc @@ -1,7 +1,7 @@ -#include "../src/kubernetes.h" -#include "../src/updater.h" #include "../src/configuration.h" #include "../src/instance.h" +#include "../src/kubernetes.h" +#include "../src/updater.h" #include "gtest/gtest.h" namespace google { @@ -18,36 +18,34 @@ class KubernetesTest : public ::testing::Test { TEST_F(KubernetesTest, GetNodeMetadata) { Configuration config(std::stringstream( - "KubernetesClusterName: 'TestClusterName'\n" - "KubernetesClusterLocation: 'TestClusterLocation'\n" - "MetadataIngestionRawContentVersion: 'TestVersion'\n" - "InstanceZone: 'TestZone'\n" - "InstanceId: 'TestID'\n" + "KubernetesClusterName: TestClusterName\n" + "KubernetesClusterLocation: TestClusterLocation\n" + "MetadataIngestionRawContentVersion: TestVersion\n" + "InstanceZone: TestZone\n" + "InstanceId: TestID\n" )); Environment environment(config); KubernetesReader reader(config, nullptr); - json::value node_json = json::object({ + json::value node = json::object({ {"metadata", json::object({ {"name", json::string("testname")}, - {"creationTimestamp", json::string("2018-03-03T01:23:45.678901234Z")} + {"creationTimestamp", json::string("2018-03-03T01:23:45.678901234Z")}, })} }); - const json::Object* node = node_json->As(); - MetadataUpdater::ResourceMetadata metadata( - GetNodeMetadata(reader, node, Timestamp(), false)); - EXPECT_EQ(metadata.ids.size(), 1); - EXPECT_EQ(metadata.ids[0], "k8s_node.testname"); - EXPECT_EQ(metadata.resource, - MonitoredResource("k8s_node", { - {"cluster_name", "TestClusterName"}, - {"node_name", "testname"}, - {"location", "TestClusterLocation"} - })); - EXPECT_EQ(metadata.metadata.version, "TestVersion"); - EXPECT_EQ(metadata.metadata.is_deleted, false); - EXPECT_EQ(metadata.metadata.created_at, - time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z")); - EXPECT_EQ(metadata.metadata.collected_at, Timestamp()); + const auto metadata( + GetNodeMetadata(reader, node->As(), Timestamp(), false)); + EXPECT_EQ(1, metadata.ids.size()); + EXPECT_EQ("k8s_node.testname", metadata.ids[0]); + EXPECT_EQ(MonitoredResource("k8s_node", { + {"cluster_name", "TestClusterName"}, + {"node_name", "testname"}, + {"location", "TestClusterLocation"}, + }), metadata.resource); + EXPECT_EQ("TestVersion", metadata.metadata.version); + EXPECT_EQ(false, metadata.metadata.is_deleted); + EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), + metadata.metadata.created_at); + EXPECT_EQ(Timestamp(), metadata.metadata.collected_at); json::value big = json::object({ {"blobs", json::object({ {"association", json::object({ @@ -58,13 +56,11 @@ TEST_F(KubernetesTest, GetNodeMetadata) { })}, })}, {"api", json::object({ - // 1.6 is hardcoded as kKubernetesApiVersion - {"version", json::string("1.6")}, - {"raw", node->Clone()}, + {"version", json::string("1.6")}, // Hard-coded in kubernetes.cc + {"raw", std::move(node)}, })}, })}, }); - EXPECT_EQ(big->As()->ToString(), - metadata.metadata.metadata->As()->ToString()); + EXPECT_EQ(big->ToString(), metadata.metadata.metadata->ToString()); } -} // namespace google +} // namespace google From f7861ce2a21e36c382ed8727e1f9637adb157663 Mon Sep 17 00:00:00 2001 From: Andrew Emil Date: Thu, 29 Mar 2018 17:28:21 -0400 Subject: [PATCH 3/7] Added library dependencies --- test/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Makefile b/test/Makefile index 3aec08f3..7d1cf8ca 100644 --- a/test/Makefile +++ b/test/Makefile @@ -92,6 +92,8 @@ gtest_main.o: $(GTEST_SOURCEDIR)/gtest_main.cc $(GTEST_LIB): gtest-all.o gtest_main.o $(AR) $(ARFLAGS) $@ $^ +$(TESTS): $(CPP_NETLIB_LIBS) $(YAML_CPP_LIBS) + format_unittest: $(GTEST_LIB) format_unittest.o $(SRC_DIR)/format.o $(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@ base64_unittest: $(GTEST_LIB) base64_unittest.o $(SRC_DIR)/base64.o From dd19b5dde8a890f88d9728755ba7bcb1874b6378 Mon Sep 17 00:00:00 2001 From: Andrew Emil Date: Thu, 29 Mar 2018 19:27:48 -0400 Subject: [PATCH 4/7] Further code review comments --- src/kubernetes.cc | 2 +- test/kubernetes_unittest.cc | 32 +++++++++++++++++++------------- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/src/kubernetes.cc b/src/kubernetes.cc index 63c9b2cc..cde233b3 100644 --- a/src/kubernetes.cc +++ b/src/kubernetes.cc @@ -1178,7 +1178,7 @@ void KubernetesReader::WatchNodes( } catch (const KubernetesReader::QueryException& e) { LOG(ERROR) << "No more node metadata will be collected"; } - if (health_checker) { + if (health_checker_) { health_checker_->SetUnhealthy("kubernetes_node_thread"); } LOG(INFO) << "Watch thread (node) exiting"; diff --git a/test/kubernetes_unittest.cc b/test/kubernetes_unittest.cc index 1fbdb804..9e3a9c0d 100644 --- a/test/kubernetes_unittest.cc +++ b/test/kubernetes_unittest.cc @@ -22,6 +22,7 @@ TEST_F(KubernetesTest, GetNodeMetadata) { "KubernetesClusterLocation: TestClusterLocation\n" "MetadataIngestionRawContentVersion: TestVersion\n" "InstanceZone: TestZone\n" + "InstanceResourceType: gce_instance\n" "InstanceId: TestID\n" )); Environment environment(config); @@ -32,35 +33,40 @@ TEST_F(KubernetesTest, GetNodeMetadata) { {"creationTimestamp", json::string("2018-03-03T01:23:45.678901234Z")}, })} }); - const auto metadata( - GetNodeMetadata(reader, node->As(), Timestamp(), false)); - EXPECT_EQ(1, metadata.ids.size()); - EXPECT_EQ("k8s_node.testname", metadata.ids[0]); + const auto m = + GetNodeMetadata(reader, node->As(), Timestamp(), false); + EXPECT_EQ(1, m.ids.size()); + EXPECT_EQ("k8s_node.testname", m.ids[0]); EXPECT_EQ(MonitoredResource("k8s_node", { {"cluster_name", "TestClusterName"}, {"node_name", "testname"}, {"location", "TestClusterLocation"}, - }), metadata.resource); - EXPECT_EQ("TestVersion", metadata.metadata.version); - EXPECT_EQ(false, metadata.metadata.is_deleted); + }), m.resource); + EXPECT_EQ("TestVersion", m.metadata.version); + EXPECT_EQ(false, m.metadata.is_deleted); EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), - metadata.metadata.created_at); - EXPECT_EQ(Timestamp(), metadata.metadata.collected_at); + m.metadata.created_at); + EXPECT_EQ(Timestamp(), m.metadata.collected_at); json::value big = json::object({ {"blobs", json::object({ {"association", json::object({ {"version", json::string("TestVersion")}, {"raw", json::object({ - {"infrastructureResource", - InstanceReader::InstanceResource(environment).ToJSON()}, + {"infrastructureResource", json::object({ + {"type", json::string("gce_instance")}, + {"labels", json::object({ + {"instance_id", json::string("TestID")}, + {"zone", json::string("TestZone")}, + })}, + })}, })}, })}, {"api", json::object({ - {"version", json::string("1.6")}, // Hard-coded in kubernetes.cc + {"version", json::string("1.6")}, // Hard-coded in kubernetes.cc. {"raw", std::move(node)}, })}, })}, }); - EXPECT_EQ(big->ToString(), metadata.metadata.metadata->ToString()); + EXPECT_EQ(big->ToString(), m.metadata.metadata->ToString()); } } // namespace google From b0f141523f8585455cdfaf1adb0c3efaa10209e8 Mon Sep 17 00:00:00 2001 From: Andrew Emil Date: Thu, 29 Mar 2018 19:46:52 -0400 Subject: [PATCH 5/7] Fixed spacing in KubernetesTest --- test/kubernetes_unittest.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/kubernetes_unittest.cc b/test/kubernetes_unittest.cc index 9e3a9c0d..95e28296 100644 --- a/test/kubernetes_unittest.cc +++ b/test/kubernetes_unittest.cc @@ -8,12 +8,12 @@ namespace google { class KubernetesTest : public ::testing::Test { protected: - MetadataUpdater::ResourceMetadata GetNodeMetadata( - const KubernetesReader& reader, const json::Object *node, - Timestamp collected_at, bool is_deleted) const - throw(json::Exception) { + MetadataUpdater::ResourceMetadata GetNodeMetadata( + const KubernetesReader& reader, const json::Object *node, + Timestamp collected_at, bool is_deleted) const + throw(json::Exception) { return reader.GetNodeMetadata(node, collected_at, is_deleted); - } + } }; TEST_F(KubernetesTest, GetNodeMetadata) { From 7306ba0e9e5cf251d0c7812d97f467e0d3a3e35b Mon Sep 17 00:00:00 2001 From: Andrew Emil Date: Fri, 30 Mar 2018 09:14:16 -0400 Subject: [PATCH 6/7] Code review changes --- test/kubernetes_unittest.cc | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/test/kubernetes_unittest.cc b/test/kubernetes_unittest.cc index 95e28296..2cde0219 100644 --- a/test/kubernetes_unittest.cc +++ b/test/kubernetes_unittest.cc @@ -1,5 +1,4 @@ #include "../src/configuration.h" -#include "../src/instance.h" #include "../src/kubernetes.h" #include "../src/updater.h" #include "gtest/gtest.h" @@ -7,13 +6,13 @@ namespace google { class KubernetesTest : public ::testing::Test { - protected: - MetadataUpdater::ResourceMetadata GetNodeMetadata( - const KubernetesReader& reader, const json::Object *node, - Timestamp collected_at, bool is_deleted) const - throw(json::Exception) { - return reader.GetNodeMetadata(node, collected_at, is_deleted); - } + protected: + MetadataUpdater::ResourceMetadata GetNodeMetadata( + const KubernetesReader& reader, const json::Object *node, + Timestamp collected_at, bool is_deleted) const + throw(json::Exception) { + return reader.GetNodeMetadata(node, collected_at, is_deleted); + } }; TEST_F(KubernetesTest, GetNodeMetadata) { @@ -21,8 +20,8 @@ TEST_F(KubernetesTest, GetNodeMetadata) { "KubernetesClusterName: TestClusterName\n" "KubernetesClusterLocation: TestClusterLocation\n" "MetadataIngestionRawContentVersion: TestVersion\n" - "InstanceZone: TestZone\n" "InstanceResourceType: gce_instance\n" + "InstanceZone: TestZone\n" "InstanceId: TestID\n" )); Environment environment(config); From 12742ebd9f41f5043261e2c9e46c2e64e47b2755 Mon Sep 17 00:00:00 2001 From: Andrew Emil Date: Fri, 30 Mar 2018 10:49:50 -0400 Subject: [PATCH 7/7] Added clarifying comment --- test/kubernetes_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/kubernetes_unittest.cc b/test/kubernetes_unittest.cc index 2cde0219..79e4ac94 100644 --- a/test/kubernetes_unittest.cc +++ b/test/kubernetes_unittest.cc @@ -25,7 +25,7 @@ TEST_F(KubernetesTest, GetNodeMetadata) { "InstanceId: TestID\n" )); Environment environment(config); - KubernetesReader reader(config, nullptr); + KubernetesReader reader(config, nullptr); // Don't need HealthChecker. json::value node = json::object({ {"metadata", json::object({ {"name", json::string("testname")},