From 3c29a92554b6bb09ad4b78343d3bc4ff601e76e4 Mon Sep 17 00:00:00 2001 From: Bryan Moyles Date: Thu, 15 Mar 2018 13:11:20 -0400 Subject: [PATCH 1/3] Remove pod startTime, as it is causing exceptions and is not used. --- src/kubernetes.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/kubernetes.cc b/src/kubernetes.cc index dab6485e..aad3681f 100644 --- a/src/kubernetes.cc +++ b/src/kubernetes.cc @@ -206,8 +206,6 @@ MetadataUpdater::ResourceMetadata KubernetesReader::GetPodMetadata( Timestamp created_at = time::rfc3339::FromString(created_str); const json::Object* status = pod->Get("status"); - const std::string started_str = status->Get("startTime"); - Timestamp started_at = time::rfc3339::FromString(started_str); const MonitoredResource k8s_pod("k8s_pod", { {"cluster_name", cluster_name}, From 2b8b06223352a90e595b57c0671f67938bcd7870 Mon Sep 17 00:00:00 2001 From: Bryan Moyles Date: Thu, 15 Mar 2018 13:57:24 -0400 Subject: [PATCH 2/3] Address feedback. --- src/kubernetes.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/kubernetes.cc b/src/kubernetes.cc index aad3681f..7c3a96a8 100644 --- a/src/kubernetes.cc +++ b/src/kubernetes.cc @@ -507,8 +507,6 @@ std::vector << " not the same as agent node " << node_name; } - const json::Object* status = pod->Get("status"); - const json::Array* container_specs = spec->Get("containers"); const json::Array* container_statuses = status->Get("containerStatuses"); From c16ea92fd66b4f4f33393806113a225e8c023fa0 Mon Sep 17 00:00:00 2001 From: Bryan Moyles Date: Thu, 15 Mar 2018 13:59:39 -0400 Subject: [PATCH 3/3] Oops, wrong status. --- src/kubernetes.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kubernetes.cc b/src/kubernetes.cc index 7c3a96a8..93ab7047 100644 --- a/src/kubernetes.cc +++ b/src/kubernetes.cc @@ -205,8 +205,6 @@ MetadataUpdater::ResourceMetadata KubernetesReader::GetPodMetadata( metadata->Get("creationTimestamp"); Timestamp created_at = time::rfc3339::FromString(created_str); - const json::Object* status = pod->Get("status"); - const MonitoredResource k8s_pod("k8s_pod", { {"cluster_name", cluster_name}, {"namespace_name", namespace_name}, @@ -507,6 +505,8 @@ std::vector << " not the same as agent node " << node_name; } + const json::Object* status = pod->Get("status"); + const json::Array* container_specs = spec->Get("containers"); const json::Array* container_statuses = status->Get("containerStatuses");