From dcb612796c85fc645488ce52fb2ef0fae3834a3b Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Thu, 23 May 2024 13:03:06 -0300 Subject: [PATCH 1/5] Start working on change log for v6.10 --- changelog.txt | 8 ++++++++ readme.txt | 14 +++++++++++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/changelog.txt b/changelog.txt index 394b6303d8..1e2f40854e 100644 --- a/changelog.txt +++ b/changelog.txt @@ -1,4 +1,12 @@ == Changelog == += 6.10 = +* New: Field data for shortcodes is now stored in memory and reused on the settings page and form builder page for a significant page load speed improvement for forms with a lot of fields. +* Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. +* Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form. +* Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle. +* Some front end JavaScript code for supporting Internet Explorer has been dropped, helping to reduce the size of JavaScript required on the front end. + = 6.9.1 = * New: Some data used for field settings is now stored in memory and reused in order to significantly improve performance in the form builder for forms with a lot of fields. * Fix: Rootline and progress bar elements would not appear when using some position settings with the new submit button field. diff --git a/readme.txt b/readme.txt index 84ba5de790..12524c5b93 100644 --- a/readme.txt +++ b/readme.txt @@ -3,9 +3,9 @@ Plugin Name: Formidable Forms - Contact Form, Survey & Quiz Form Builder for Wor Contributors: formidableforms, sswells, srwells Tags: forms, form builder, survey, free, custom form, contact form, form maker, form creator, paypal, stripe, stripe form, quote form, contact button, form manager, payment form, survey form, email subscription, donation form, user registration form, wordpress registration, feedback form Requires at least: 5.2 -Tested up to: 6.5.2 -Requires PHP: 5.6 -Stable tag: 6.9.1 +Tested up to: 6.5.3 +Requires PHP: 7.0 +Stable tag: 6.10 The most advanced WordPress forms plugin. Go beyond contact forms with our drag and drop form builder for surveys, quizzes, and more. @@ -371,6 +371,14 @@ Using our Zapier integration, you can easily connect your website with over 5,00 See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/integrations). == Changelog == += 6.10 = +* New: Field data for shortcodes is now stored in memory and reused on the settings page and form builder page for a significant page load speed improvement for forms with a lot of fields. +* Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. +* Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form. +* Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle. +* Some front end JavaScript code for supporting Internet Explorer has been dropped, helping to reduce the size of JavaScript required on the front end. + = 6.9.1 = * New: Some data used for field settings is now stored in memory and reused in order to significantly improve performance in the form builder for forms with a lot of fields. * Fix: Rootline and progress bar elements would not appear when using some position settings with the new submit button field. From 309a1d01c31edfe96b28b11b0841cdee244a0734 Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Thu, 23 May 2024 13:08:17 -0300 Subject: [PATCH 2/5] Drop some old readme stuff for another version --- readme.txt | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/readme.txt b/readme.txt index 12524c5b93..18d6b247fc 100644 --- a/readme.txt +++ b/readme.txt @@ -411,23 +411,6 @@ See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/inte * Monthly summary emails will no longer get sent when there are no new entries to report on. * The global JS function frm_add_logic_row used on admin pages has been removed. -= 6.8.3 = -* New: HTML field descriptions now support the shortcode pop up used in email actions. -* New: Exported posts from entries will now include tags when applicable. -* New: The collapsible sections used in the visual styler are now more accessible, including new aria-expanded attributes. -* New: Error messages should now be more descriptive. "This field" and "This value" strings will now be dynamically replaced with the name of the field. To partially revert this, a new frm_error_substrings_to_replace_with_field_name filter has been added as well. -* Fix: Form objects with missing option data would trigger fatal errors during various actions, including when deleting the form. -* Fix: HTML tags would get stripped of most HTML when displayed in a summary for a unprivileged or logged out user. -* Fix: A Uncaught TypeError: Cannot access offset of type string on string error has been fixed when checking for add-on data. -* Fix: License expired emails would get incorrectly sent for rate limited API requests. -* Fix: Some color style settings would output invalid RGB values when using a RGB color as the style setting value. -* API requests sent for retreiving add-on and template data will now happen less frequently. -* A few old deprecated global JavaScript functions have been removed including frm_resend_email, frmOnSubmit, and frmDeleteEntry. -* Some old CSS rules using -webkit- and -moz- prefixes have been removed, helping to reduce CSS file size. - -= 6.8.2 = -* Fix: The process of connecting an account to formidableforms.com would fail in some web browsers. - [See changelog for all versions](https://raw.githubusercontent.com/Strategy11/formidable-forms/master/changelog.txt) == Upgrade Notice == From 02301e5e5bd81fea3a5307fec7346e99169e5ff3 Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Tue, 28 May 2024 12:57:26 -0300 Subject: [PATCH 3/5] Add additional change log items --- changelog.txt | 2 ++ readme.txt | 2 ++ 2 files changed, 4 insertions(+) diff --git a/changelog.txt b/changelog.txt index 1e2f40854e..d8fb3b6d48 100644 --- a/changelog.txt +++ b/changelog.txt @@ -1,8 +1,10 @@ == Changelog == = 6.10 = * New: Field data for shortcodes is now stored in memory and reused on the settings page and form builder page for a significant page load speed improvement for forms with a lot of fields. +* New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings. * Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. * Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries. * Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form. * Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle. * Some front end JavaScript code for supporting Internet Explorer has been dropped, helping to reduce the size of JavaScript required on the front end. diff --git a/readme.txt b/readme.txt index 18d6b247fc..2e39f9230b 100644 --- a/readme.txt +++ b/readme.txt @@ -373,8 +373,10 @@ See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/inte == Changelog == = 6.10 = * New: Field data for shortcodes is now stored in memory and reused on the settings page and form builder page for a significant page load speed improvement for forms with a lot of fields. +* New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings. * Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. * Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries. * Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form. * Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle. * Some front end JavaScript code for supporting Internet Explorer has been dropped, helping to reduce the size of JavaScript required on the front end. From ede076312dd529192280e5e02eeb45a7a38dcb9f Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Tue, 28 May 2024 13:02:33 -0300 Subject: [PATCH 4/5] Stop checking for the PHP 5.6 syntax, mention the PHP version bump in the readme, update the php version notice check to report warnings for PHP 5.6 now --- .github/workflows/syntax.yml | 4 ++-- changelog.txt | 1 + classes/helpers/FrmAppHelper.php | 2 +- readme.txt | 1 + 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/syntax.yml b/.github/workflows/syntax.yml index bc5a1e128c..bcd07c24b5 100644 --- a/.github/workflows/syntax.yml +++ b/.github/workflows/syntax.yml @@ -16,8 +16,8 @@ jobs: strategy: matrix: include: - - php: 5.6 - - php: 8.1 + - php: 7.0 + - php: 8.3 steps: - uses: actions/checkout@v4.1.1 diff --git a/changelog.txt b/changelog.txt index d8fb3b6d48..1c18d2e7cb 100644 --- a/changelog.txt +++ b/changelog.txt @@ -4,6 +4,7 @@ * New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings. * Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. * Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* The minimum supported PHP version has been updated to 7.0, ending official support for PHP 5.6. * The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries. * Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form. * Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle. diff --git a/classes/helpers/FrmAppHelper.php b/classes/helpers/FrmAppHelper.php index ca6c12fc01..628f8b10ef 100644 --- a/classes/helpers/FrmAppHelper.php +++ b/classes/helpers/FrmAppHelper.php @@ -3509,7 +3509,7 @@ public static function meets_min_pro_version( $min_version ) { */ private static function php_version_notice() { $message = array(); - if ( version_compare( phpversion(), '5.6', '<' ) ) { + if ( version_compare( phpversion(), '7.0', '<' ) ) { $message[] = __( 'The version of PHP on your server is too low. If this is not corrected, you may see issues with Formidable Forms. Please contact your web host and ask to be updated to PHP 7.0+.', 'formidable' ); } diff --git a/readme.txt b/readme.txt index 2e39f9230b..09a18f96c1 100644 --- a/readme.txt +++ b/readme.txt @@ -376,6 +376,7 @@ See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/inte * New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings. * Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. * Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* The minimum supported PHP version has been updated to 7.0, ending official support for PHP 5.6. * The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries. * Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form. * Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle. From 36282a1d4397a684946257791d9efe22b5a6295b Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Wed, 29 May 2024 09:43:29 -0300 Subject: [PATCH 5/5] Mention Stripe error handling improvement in changelog --- changelog.txt | 1 + readme.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/changelog.txt b/changelog.txt index 1c18d2e7cb..ec87fb1170 100644 --- a/changelog.txt +++ b/changelog.txt @@ -4,6 +4,7 @@ * New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings. * Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. * Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* Fix: In some cases, a Stripe redirect would happen after failing to create an entry, resulting in an unexpected redirect to stripe.com. * The minimum supported PHP version has been updated to 7.0, ending official support for PHP 5.6. * The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries. * Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form. diff --git a/readme.txt b/readme.txt index 09a18f96c1..a144e62ba3 100644 --- a/readme.txt +++ b/readme.txt @@ -376,6 +376,7 @@ See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/inte * New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings. * Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5. * Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys. +* Fix: In some cases, a Stripe redirect would happen after failing to create an entry, resulting in an unexpected redirect to stripe.com. * The minimum supported PHP version has been updated to 7.0, ending official support for PHP 5.6. * The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries. * Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form.