From 4bbb614f2d3ea6d6fd56b78ef7d9c82f52e29c6c Mon Sep 17 00:00:00 2001 From: Sherv Date: Thu, 11 Jul 2024 21:50:41 +0300 Subject: [PATCH 01/56] Add "frm-inline-flex" class and refactor "settings.php" view --- classes/views/frm-fields/back-end/settings.php | 8 ++++---- css/frm_admin.css | 9 +++++++++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/classes/views/frm-fields/back-end/settings.php b/classes/views/frm-fields/back-end/settings.php index 384b07cc31..3b776d70ef 100644 --- a/classes/views/frm-fields/back-end/settings.php +++ b/classes/views/frm-fields/back-end/settings.php @@ -64,9 +64,9 @@ -

+

-

+

@@ -62,6 +62,8 @@

+

+ From bb347337f0e7bcb9e996d36d986c23a8d3967462 Mon Sep 17 00:00:00 2001 From: Sherv Date: Fri, 12 Jul 2024 16:30:02 +0300 Subject: [PATCH 03/56] Fix HTML validation, and make better HTML --- .../views/frm-fields/back-end/settings.php | 33 +++++++++++-------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/classes/views/frm-fields/back-end/settings.php b/classes/views/frm-fields/back-end/settings.php index 3b776d70ef..124d37d6c8 100644 --- a/classes/views/frm-fields/back-end/settings.php +++ b/classes/views/frm-fields/back-end/settings.php @@ -64,35 +64,41 @@ -

+

- +
+ +
- +
+ +
- +
+ +
-

+
show_primary_options( compact( 'field', 'display', 'values' ) ); - ?> From 107b596aad4fc33b4dc59350907b7b6419d7be21 Mon Sep 17 00:00:00 2001 From: Sherv Date: Fri, 12 Jul 2024 16:30:30 +0300 Subject: [PATCH 04/56] Add `.frm-my-sm` class --- css/frm_admin.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/css/frm_admin.css b/css/frm_admin.css index d14e319599..c24027db97 100644 --- a/css/frm_admin.css +++ b/css/frm_admin.css @@ -1697,6 +1697,11 @@ input.frm_insert_in_template { margin-right: var(--gap-sm) !important; } +#wpbody-content .frm-my-sm { + margin-top: var(--gap-sm) !important; + margin-bottom: var(--gap-sm) !important; +} + .frm-p-0 { padding: 0 !important; } From ce1fc48c5e9b05f6b91ce2af803e89c65a6e95f6 Mon Sep 17 00:00:00 2001 From: Sherv Date: Tue, 10 Dec 2024 15:05:37 +0300 Subject: [PATCH 05/56] Add is_hidden param to show_format_option method and refactor it --- classes/controllers/FrmFieldsController.php | 14 ++++++++------ classes/models/fields/FrmFieldPhone.php | 2 +- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/classes/controllers/FrmFieldsController.php b/classes/controllers/FrmFieldsController.php index 1f4feaa1df..3658b6258c 100644 --- a/classes/controllers/FrmFieldsController.php +++ b/classes/controllers/FrmFieldsController.php @@ -468,15 +468,17 @@ public static function display_field_options( $settings, $field_info = null ) { * * @since 3.0 * - * @param array $field + * @param array $field Field array. + * @param bool $is_hidden Whether the format option should be hidden. * @return void */ - public static function show_format_option( $field ) { - $attributes = array(); - $attributes['class'] = 'frm-has-modal'; + public static function show_format_option( $field, $is_hidden = false ) { + $attributes = array( + 'class' => 'frm-has-modal', + 'id' => 'phone' === $field['type'] ? 'frm-phone-field-custom-format-' . $field['id'] : 'frm-field-format-custom-' . $field['id'], + ); - if ( 'phone' === $field['type'] ) { - $attributes['id'] = 'frm-phone-field-custom-format-' . $field['id']; + if ( $is_hidden ) { $attributes['class'] .= ' frm_hidden'; } diff --git a/classes/models/fields/FrmFieldPhone.php b/classes/models/fields/FrmFieldPhone.php index 1b9c68c7eb..00df8f979d 100644 --- a/classes/models/fields/FrmFieldPhone.php +++ b/classes/models/fields/FrmFieldPhone.php @@ -47,7 +47,7 @@ public function show_primary_options( $args ) { $field = $args['field']; include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/phone/phone-type.php'; - FrmFieldsController::show_format_option( $field ); + FrmFieldsController::show_format_option( $field, true ); parent::show_primary_options( $args ); } From cc581b19ceb4bb16045eeb97b49987d38ccb538c Mon Sep 17 00:00:00 2001 From: Sherv Date: Tue, 10 Dec 2024 15:06:20 +0300 Subject: [PATCH 06/56] Add print_format_number_option method to FrmFieldText class --- classes/models/fields/FrmFieldText.php | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/classes/models/fields/FrmFieldText.php b/classes/models/fields/FrmFieldText.php index 30fa019c6d..ce74a30619 100644 --- a/classes/models/fields/FrmFieldText.php +++ b/classes/models/fields/FrmFieldText.php @@ -47,4 +47,24 @@ public function validate( $args ) { return $errors; } + + /** + * Print the format number option for a field. + * + * @since x.x + * + * @return void + */ + public function print_format_number_option() { + ?> + + Date: Tue, 10 Dec 2024 15:06:40 +0300 Subject: [PATCH 07/56] Add format-type view template --- .../views/frm-fields/back-end/format-type.php | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 classes/views/frm-fields/back-end/format-type.php diff --git a/classes/views/frm-fields/back-end/format-type.php b/classes/views/frm-fields/back-end/format-type.php new file mode 100644 index 0000000000..5328e7df98 --- /dev/null +++ b/classes/views/frm-fields/back-end/format-type.php @@ -0,0 +1,39 @@ + +

+ + + +

From a764391eb1724263f0e3279b4984501e751da183 Mon Sep 17 00:00:00 2001 From: Sherv Date: Tue, 10 Dec 2024 15:06:50 +0300 Subject: [PATCH 08/56] Move format setting --- classes/views/frm-fields/back-end/settings.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/classes/views/frm-fields/back-end/settings.php b/classes/views/frm-fields/back-end/settings.php index 5371e8c7cc..0c7d58b7f0 100644 --- a/classes/views/frm-fields/back-end/settings.php +++ b/classes/views/frm-fields/back-end/settings.php @@ -106,6 +106,12 @@ } $field_obj->show_primary_options( compact( 'field', 'display', 'values' ) ); + + if ( $display['format'] ) { + include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/format-type.php'; + + FrmFieldsController::show_format_option( $field, true ); + } ?> @@ -259,13 +265,7 @@

- +

From 0016cb222e4227b3505d028591130b8543af110a Mon Sep 17 00:00:00 2001 From: Sherv Date: Tue, 10 Dec 2024 20:36:59 +0300 Subject: [PATCH 09/56] Update text field to include format settings --- classes/models/fields/FrmFieldText.php | 2 +- classes/views/frm-fields/back-end/format-type.php | 2 +- classes/views/frm-fields/back-end/settings.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/classes/models/fields/FrmFieldText.php b/classes/models/fields/FrmFieldText.php index ce74a30619..3bf2db0720 100644 --- a/classes/models/fields/FrmFieldText.php +++ b/classes/models/fields/FrmFieldText.php @@ -55,7 +55,7 @@ public function validate( $args ) { * * @return void */ - public function print_format_number_option() { + public function print_format_number_option( $field ) { ?>

+