From c1919d3e85d47d83248c8a9c7520e6df66a8a3df Mon Sep 17 00:00:00 2001 From: liviu13 Date: Mon, 30 Sep 2024 15:13:57 +0300 Subject: [PATCH 1/3] add "for" accessibility to style editor elements, add form description font size option, add extra check for base font size in order to avoid undefined when used as non-numeric --- classes/helpers/FrmStylesHelper.php | 2 +- classes/views/styles/_buttons.php | 86 +++++++++++++++---- .../views/styles/_check-box-radio-fields.php | 20 +++-- classes/views/styles/_field-colors.php | 66 ++++++++++---- classes/views/styles/_field-description.php | 27 ++++-- classes/views/styles/_field-labels.php | 37 ++++++-- classes/views/styles/_field-sizes.php | 28 ++++-- classes/views/styles/_form-description.php | 19 ++++ classes/views/styles/_form-messages.php | 36 ++++++-- classes/views/styles/_form-title.php | 18 +++- classes/views/styles/_general.php | 64 +++++++++++--- classes/views/styles/_quick-settings.php | 56 +++++++++--- 12 files changed, 361 insertions(+), 98 deletions(-) diff --git a/classes/helpers/FrmStylesHelper.php b/classes/helpers/FrmStylesHelper.php index f4f4219e87..df833962d5 100644 --- a/classes/helpers/FrmStylesHelper.php +++ b/classes/helpers/FrmStylesHelper.php @@ -610,7 +610,7 @@ function ( $key ) use ( $defaults, $font_size, $base_font_size, &$settings ) { * @return float */ private static function get_base_font_size_scale( $key, $value, $defaults ) { - if ( empty( $defaults[ $key ] ) || ! is_numeric( (int) $defaults[ $key ] ) || ! is_numeric( (int) $value ) ) { + if ( empty( $defaults[ $key ] ) || ! is_numeric( (int) $defaults[ $key ] ) || ! is_numeric( (int) $value ) || 0 === (int) $value ) { return 1; } diff --git a/classes/views/styles/_buttons.php b/classes/views/styles/_buttons.php index 01af0eb7dc..a4a70df6a5 100644 --- a/classes/views/styles/_buttons.php +++ b/classes/views/styles/_buttons.php @@ -34,7 +34,9 @@ ); ?>
- +
-
+
+ +
- +
-
+
+ +
-
+
+ +
- +
-
+
+ +
- +
-
+
+ +
-
-
+
+ +
-