From 28742962e2954db8bb92ed6d41a977619631e683 Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Thu, 21 Nov 2024 16:05:32 +0300 Subject: [PATCH 1/6] Add additional remove icon for css and bcc fields --- classes/views/frm-form-actions/_email_settings.php | 2 ++ css/frm_admin.css | 10 ++++++++++ js/formidable_admin.js | 4 ++++ 3 files changed, 16 insertions(+) diff --git a/classes/views/frm-form-actions/_email_settings.php b/classes/views/frm-form-actions/_email_settings.php index f999312e51..d9808479fc 100644 --- a/classes/views/frm-form-actions/_email_settings.php +++ b/classes/views/frm-form-actions/_email_settings.php @@ -27,6 +27,7 @@ +
diff --git a/css/frm_admin.css b/css/frm_admin.css index 72ad51eb94..d62a35af24 100644 --- a/css/frm_admin.css +++ b/css/frm_admin.css @@ -5829,6 +5829,16 @@ p.frm_reply_to_container { vertical-align: bottom; } +.frm_cc_row.frm_email_row .frm-with-right-icon, +.frm_bcc_row.frm_email_row .frm-with-right-icon { + width: calc(100% - 20px); + display: inline-block; +} + +.frm_email_row .frm_remove_field .frm_close_icon { + fill: var(--grey-500); +} + .frm_logic_field_opts { max-width: 35%; } diff --git a/js/formidable_admin.js b/js/formidable_admin.js index ed8bad1b9b..4aecdefc94 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -8570,6 +8570,10 @@ function frmAdminBuildJS() { closeSvg = document.querySelectorAll( '.frm_has_shortcodes use' ); for ( u = 0; u < closeSvg.length; u++ ) { if ( closeSvg[u].getAttributeNS( 'http://www.w3.org/1999/xlink', 'href' ) === '#frm_close_icon' ) { + if ( closeSvg[u].closest( '.frm_remove_field' ) ) { + // Don't change the icon for the email fields remove button. + break; + } closeSvg[u].setAttributeNS( 'http://www.w3.org/1999/xlink', 'href', '#frm_more_horiz_solid_icon' ); } } From b5b0bba41168b547d96f1611410c6c9b7287b12f Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Fri, 29 Nov 2024 15:04:59 +0300 Subject: [PATCH 2/6] Change icons to tooltip icon --- classes/views/frm-form-actions/_email_settings.php | 4 ++-- css/frm_admin.css | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/classes/views/frm-form-actions/_email_settings.php b/classes/views/frm-form-actions/_email_settings.php index d9808479fc..c49ec790df 100644 --- a/classes/views/frm-form-actions/_email_settings.php +++ b/classes/views/frm-form-actions/_email_settings.php @@ -23,7 +23,7 @@
@@ -33,7 +33,7 @@
diff --git a/css/frm_admin.css b/css/frm_admin.css index d62a35af24..124c764803 100644 --- a/css/frm_admin.css +++ b/css/frm_admin.css @@ -6123,7 +6123,7 @@ span.howto { text-align: start; } -.frm_form_action_settings .frm_email_row .frm_remove_field svg { +.frm_form_action_settings .frm_email_row .frm_tooltip_icon { position: relative; bottom: 2px; } From 10ffb8623a1a6ce26f30a5c3e84e7dbc2ee37ae3 Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Fri, 29 Nov 2024 15:14:29 +0300 Subject: [PATCH 3/6] Fix potential bug --- css/frm_admin.css | 2 ++ js/formidable_admin.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/css/frm_admin.css b/css/frm_admin.css index 124c764803..63612304fe 100644 --- a/css/frm_admin.css +++ b/css/frm_admin.css @@ -5836,7 +5836,9 @@ p.frm_reply_to_container { } .frm_email_row .frm_remove_field .frm_close_icon { + position: relative; fill: var(--grey-500); + vertical-align: middle; } .frm_logic_field_opts { diff --git a/js/formidable_admin.js b/js/formidable_admin.js index 4aecdefc94..a9c325a311 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -8572,7 +8572,7 @@ function frmAdminBuildJS() { if ( closeSvg[u].getAttributeNS( 'http://www.w3.org/1999/xlink', 'href' ) === '#frm_close_icon' ) { if ( closeSvg[u].closest( '.frm_remove_field' ) ) { // Don't change the icon for the email fields remove button. - break; + continue; } closeSvg[u].setAttributeNS( 'http://www.w3.org/1999/xlink', 'href', '#frm_more_horiz_solid_icon' ); } From 67ead199d071e9d41b7d6e6a9e64fcbabd9d9862 Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Mon, 2 Dec 2024 11:10:43 +0300 Subject: [PATCH 4/6] Remove tooltip from label/input elements and use tooltip icon instead --- .../views/frm-form-actions/_action_inside.php | 5 +-- .../frm-form-actions/_email_settings.php | 36 ++++++++++--------- 2 files changed, 22 insertions(+), 19 deletions(-) diff --git a/classes/views/frm-form-actions/_action_inside.php b/classes/views/frm-form-actions/_action_inside.php index 2500d3004c..bb74d1bde3 100644 --- a/classes/views/frm-form-actions/_action_inside.php +++ b/classes/views/frm-form-actions/_action_inside.php @@ -9,10 +9,11 @@
-
-
-
@@ -59,19 +60,20 @@
-
-
+
From 91722c5b0ee5c641a1329900a7d06c3186a0793f Mon Sep 17 00:00:00 2001
From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com>
Date: Tue, 3 Dec 2024 09:21:00 +0300
Subject: [PATCH 5/6] Add reply to field remove trigger
---
classes/views/frm-form-actions/_email_settings.php | 1 +
css/frm_admin.css | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/classes/views/frm-form-actions/_email_settings.php b/classes/views/frm-form-actions/_email_settings.php
index 8066b8f962..4e43c25710 100644
--- a/classes/views/frm-form-actions/_email_settings.php
+++ b/classes/views/frm-form-actions/_email_settings.php
@@ -66,6 +66,7 @@
diff --git a/css/frm_admin.css b/css/frm_admin.css
index 63612304fe..e456e265aa 100644
--- a/css/frm_admin.css
+++ b/css/frm_admin.css
@@ -5830,7 +5830,8 @@ p.frm_reply_to_container {
}
.frm_cc_row.frm_email_row .frm-with-right-icon,
-.frm_bcc_row.frm_email_row .frm-with-right-icon {
+.frm_bcc_row.frm_email_row .frm-with-right-icon,
+.frm_reply_to_row.frm_email_row .frm-with-right-icon {
width: calc(100% - 20px);
display: inline-block;
}
From 46665c029adca31f9fddae752cec8f9d101ad973 Mon Sep 17 00:00:00 2001
From: Mike Letellier