From f2ee8d890da95877bb9604058a10c4626fce0b32 Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Thu, 9 Jan 2025 17:32:51 +0300 Subject: [PATCH 1/4] Avoid selecting text when multiselecting fields --- js/formidable_admin.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/formidable_admin.js b/js/formidable_admin.js index ced22ca6c9..c66ff73852 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -4411,9 +4411,6 @@ function frmAdminBuildJS() { } } ); - - // when holding shift and clicking, text gets selected. unselect it. - document.getSelection().removeAllRanges(); } } else { // not multi-selecting @@ -10706,6 +10703,9 @@ function frmAdminBuildJS() { handleShowPasswordLiveUpdate(); document.addEventListener( 'scroll', updateShortcodesPopupPosition, true ); document.addEventListener( 'change', handleBuilderChangeEvent ); + document.onselectstart = function( e ) { + return e.target.closest( '.frm_form_builder' ); + }; }, settingsInit: function() { From 195feba9f9a3ae6afad51af019eaff052009500d Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Sun, 12 Jan 2025 22:26:38 +0300 Subject: [PATCH 2/4] Limit selectstart event trigger on form builder --- js/formidable_admin.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/formidable_admin.js b/js/formidable_admin.js index c66ff73852..13a64df718 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -10703,9 +10703,9 @@ function frmAdminBuildJS() { handleShowPasswordLiveUpdate(); document.addEventListener( 'scroll', updateShortcodesPopupPosition, true ); document.addEventListener( 'change', handleBuilderChangeEvent ); - document.onselectstart = function( e ) { - return e.target.closest( '.frm_form_builder' ); - }; + document.querySelector( '.frm_form_builder' ).addEventListener( 'selectstart', function( e ) { + e.preventDefault(); + }); }, settingsInit: function() { From ad3213b6f053fc82cf3197a6079ba51abf095a2c Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Tue, 14 Jan 2025 15:03:23 +0300 Subject: [PATCH 3/4] Return false in the callback function to selectstart event on builder element --- js/formidable_admin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/formidable_admin.js b/js/formidable_admin.js index 13a64df718..028cd658b4 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -10704,7 +10704,7 @@ function frmAdminBuildJS() { document.addEventListener( 'scroll', updateShortcodesPopupPosition, true ); document.addEventListener( 'change', handleBuilderChangeEvent ); document.querySelector( '.frm_form_builder' ).addEventListener( 'selectstart', function( e ) { - e.preventDefault(); + return false; }); }, From 2872a96b530409291d6f6625b95a9d8d5cc08e27 Mon Sep 17 00:00:00 2001 From: Abdi Tolessa <41271840+AbdiTolesa@users.noreply.github.com> Date: Thu, 16 Jan 2025 12:07:25 +0300 Subject: [PATCH 4/4] Prevent default mousedown event when shift key is hold --- js/formidable_admin.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/js/formidable_admin.js b/js/formidable_admin.js index 028cd658b4..34c57763d8 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -10703,8 +10703,10 @@ function frmAdminBuildJS() { handleShowPasswordLiveUpdate(); document.addEventListener( 'scroll', updateShortcodesPopupPosition, true ); document.addEventListener( 'change', handleBuilderChangeEvent ); - document.querySelector( '.frm_form_builder' ).addEventListener( 'selectstart', function( e ) { - return false; + document.querySelector( '.frm_form_builder' ).addEventListener( 'mousedown', event => { + if ( event.shiftKey ) { + event.preventDefault(); + } }); },