From f53547abc55db13fc1f7d8e3593b4303499168bf Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Wed, 18 Jun 2025 11:30:16 -0300 Subject: [PATCH 1/3] Auto autocomplete does not init for files dropdown for new action --- js/formidable_admin.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/formidable_admin.js b/js/formidable_admin.js index af6de08875..19a755a5d6 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -651,7 +651,7 @@ function frmAdminBuildJS() { inside.html( html ); initiateMultiselect(); showInputIcon( '#' + cont.attr( 'id' ) ); - frmDom.autocomplete.initSelectionAutocomplete( inside ); + initSelectionAutocomplete( inside ); jQuery( b ).trigger( 'frm-action-loaded' ); /** @@ -7132,7 +7132,7 @@ function frmAdminBuildJS() { if ( newAction.classList.contains( 'frm_single_on_submit_settings' ) ) { const autocompleteInput = newAction.querySelector( 'input.frm-page-search' ); if ( autocompleteInput ) { - frmDom.autocomplete.initAutocomplete( 'page', newAction ); + initSelectionAutocomplete( newAction ); } } @@ -7230,7 +7230,7 @@ function frmAdminBuildJS() { showInputIcon( '#frm_form_action_' + actionId ); initiateMultiselect(); - frmDom.autocomplete.initAutocomplete( 'page', newAction ); + initSelectionAutocomplete( newAction ); if ( widgetTop ) { jQuery( widgetTop ).trigger( 'frm-action-loaded' ); @@ -9203,8 +9203,8 @@ function frmAdminBuildJS() { } }); } - function initSelectionAutocomplete() { - frmDom.autocomplete.initSelectionAutocomplete(); + function initSelectionAutocomplete( container ) { + frmDom.autocomplete.initSelectionAutocomplete( container ); } function nextInstallStep( thisStep ) { From 55729accc14eb2a9572801bd4e2459f702051b7a Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Wed, 18 Jun 2025 11:37:36 -0300 Subject: [PATCH 2/3] Add more consistency, rename function --- js/formidable_admin.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/js/formidable_admin.js b/js/formidable_admin.js index 19a755a5d6..fecc5a69e8 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -651,7 +651,7 @@ function frmAdminBuildJS() { inside.html( html ); initiateMultiselect(); showInputIcon( '#' + cont.attr( 'id' ) ); - initSelectionAutocomplete( inside ); + initAutocomplete( inside ); jQuery( b ).trigger( 'frm-action-loaded' ); /** @@ -7132,7 +7132,7 @@ function frmAdminBuildJS() { if ( newAction.classList.contains( 'frm_single_on_submit_settings' ) ) { const autocompleteInput = newAction.querySelector( 'input.frm-page-search' ); if ( autocompleteInput ) { - initSelectionAutocomplete( newAction ); + initAutocomplete( newAction ); } } @@ -7230,7 +7230,7 @@ function frmAdminBuildJS() { showInputIcon( '#frm_form_action_' + actionId ); initiateMultiselect(); - initSelectionAutocomplete( newAction ); + initAutocomplete( newAction ); if ( widgetTop ) { jQuery( widgetTop ).trigger( 'frm-action-loaded' ); @@ -7697,7 +7697,7 @@ function frmAdminBuildJS() { function( response, optName ) { // The replaced string is declared in FrmProFormActionController::ajax_get_post_menu_order_option() in the pro version. postParentField.querySelector( '.frm_post_parent_opt_wrapper' ).innerHTML = response.replaceAll( 'REPLACETHISNAME', optName ); - frmDom.autocomplete.initAutocomplete( 'page', postParentField ); + initAutocomplete( postParentField ); } ); } @@ -9203,7 +9203,7 @@ function frmAdminBuildJS() { } }); } - function initSelectionAutocomplete( container ) { + function initAutocomplete( container ) { frmDom.autocomplete.initSelectionAutocomplete( container ); } @@ -10145,7 +10145,7 @@ function frmAdminBuildJS() { // Solution install page frmAdminBuild.solutionInit(); } else { - initSelectionAutocomplete(); + initAutocomplete(); jQuery( '[data-frmprint]' ).on( 'click', function() { window.print(); @@ -10623,7 +10623,7 @@ function frmAdminBuildJS() { jQuery( document ).on( 'change', '#form_settings_page input:not(.frm-search-input), #form_settings_page select, #form_settings_page textarea', fieldUpdated ); // Page Selection Autocomplete - initSelectionAutocomplete(); + initAutocomplete(); jQuery( document ).on( 'frm-action-loaded', onActionLoaded ); From 95c82eb11c611f6263dea2b6bca3d5f033f1ac5e Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Wed, 18 Jun 2025 11:42:35 -0300 Subject: [PATCH 3/3] Add missing line break --- js/formidable_admin.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/formidable_admin.js b/js/formidable_admin.js index fecc5a69e8..03db5a69ea 100644 --- a/js/formidable_admin.js +++ b/js/formidable_admin.js @@ -9203,6 +9203,7 @@ function frmAdminBuildJS() { } }); } + function initAutocomplete( container ) { frmDom.autocomplete.initSelectionAutocomplete( container ); }