From badf2167a7c8690bca33cf0343e9b484b97f7aec Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Fri, 12 Dec 2025 21:41:33 -0400 Subject: [PATCH 1/3] phpstan config updates --- phpstan.neon | 117 +++++++++++++++++- .../FrmSquareLiteSettingsController.php | 10 -- 2 files changed, 113 insertions(+), 14 deletions(-) diff --git a/phpstan.neon b/phpstan.neon index 55c452b6e6..907ade415e 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -28,19 +28,16 @@ parameters: - '#Function (apply_filters)+ invoked with#' - '#code above always terminates.#' - '#does not (accept|exist on)+#' - - '#expects (array|string|int|callable|object|stdClass|float|bool|resource)+#' + - '#expects (array|string|int|callable|object|stdClass|float|bool)+#' - '#is always (false|true)+.#' - '#no value type specified.#' - '#only iterables are supported#' - '#results in an error.#' - - '#should return#' - '#will always evaluate to#' - '#in isset\(\) does not exist.#' - - '#is unused.#' - '#in empty\(\) is not falsy.#' - '#always exists and is not falsy.#' - '#get_gateway_for_action\(\) never returns array so it can be removed from the return type#' - - "#on left side of ??#" - message: '#has an unused parameter#' paths: @@ -169,3 +166,115 @@ parameters: - message: '#is never read, only written#' path: classes/helpers/FrmFieldGridHelper.php + - + message: '#is unused.#' + paths: + - classes/models/FrmField.php + - classes/controllers/FrmSimpleBlocksController.php + - classes/helpers/FrmFieldGridHelper.php + - square/controllers/FrmSquareLiteActionsController.php + - + message: '#on left side of ??#' + path: stripe/controllers/FrmTransLiteActionsController.php + - + message: '#fwrite expects resource, resource\|null given#' + path: classes/helpers/FrmCSVExportHelper.php + - + message: '#should return#' + paths: + - stubs.php + - classes/controllers/FrmAddonsController.php + - classes/controllers/FrmAntiSpamController.php + - classes/controllers/FrmAppController.php + - classes/controllers/FrmDashboardController.php + - classes/controllers/FrmEmailStylesController.php + - classes/controllers/FrmEntriesController.php + - classes/controllers/FrmFieldsController.php + - classes/controllers/FrmFormActionsController.php + - classes/controllers/FrmFormTemplatesController.php + - classes/controllers/FrmFormsController.php + - classes/controllers/FrmSettingsController.php + - classes/controllers/FrmStylesController.php + - classes/helpers/FrmAppHelper.php + - classes/helpers/FrmCSVExportHelper.php + - classes/helpers/FrmEntriesHelper.php + - classes/helpers/FrmEntriesListHelper.php + - classes/helpers/FrmFieldsHelper.php + - classes/helpers/FrmFormMigratorsHelper.php + - classes/helpers/FrmFormsHelper.php + - classes/helpers/FrmListHelper.php + - classes/helpers/FrmStylesHelper.php + - classes/helpers/FrmXMLHelper.php + - classes/models/FrmDb.php + - classes/models/FrmEntry.php + - classes/models/FrmEntryMeta.php + - classes/models/FrmField.php + - classes/models/FrmForm.php + - classes/models/FrmFormAction.php + - classes/models/FrmMigrate.php + - classes/models/FrmSettings.php + - classes/models/FrmStyle.php + - classes/models/fields/FrmFieldType.php + - square/controllers/FrmSquareLiteSettingsController.php + - stripe/controllers/FrmStrpLiteActionsController.php + - stripe/controllers/FrmTransLiteActionsController.php + - stripe/helpers/FrmStrpLiteConnectHelper.php + - stripe/helpers/FrmTransLiteActionsHelper.php + - stripe/helpers/FrmTransLiteAppHelper.php + - stripe/models/FrmStrpLiteAuth.php + - stripe/models/FrmTransLiteAction.php + - classes/controllers/FrmOnboardingWizardController.php + - classes/controllers/FrmTestModeController.php + - classes/controllers/FrmUsageController.php + - classes/controllers/FrmWelcomeTourController.php + - classes/controllers/FrmXMLController.php + - classes/factories/FrmCaptchaFactory.php + - classes/factories/FrmEntryFactory.php + - classes/factories/FrmFieldFactory.php + - classes/helpers/FrmEmailHelper.php + - classes/helpers/FrmEmailSummaryHelper.php + - classes/helpers/FrmOnSubmitHelper.php + - classes/helpers/FrmStylesCardHelper.php + - classes/helpers/FrmStylesPreviewHelper.php + - classes/helpers/FrmSubmitHelper.php + - classes/models/FrmAddon.php + - classes/models/FrmAntiSpam.php + - classes/models/FrmCreateFile.php + - classes/models/FrmEmailSummary.php + - classes/models/FrmEntryFormatter.php + - classes/models/FrmEntryValidate.php + - classes/models/FrmEntryValues.php + - classes/models/FrmFieldValue.php + - classes/models/FrmFormApi.php + - classes/models/FrmFormMigrator.php + - classes/models/FrmFormState.php + - classes/models/FrmFormTemplateApi.php + - classes/models/FrmHoneypot.php + - classes/models/FrmInbox.php + - classes/models/FrmOnSubmitAction.php + - classes/models/FrmPluginSearch.php + - classes/models/FrmSpamCheckDenylist.php + - classes/models/FrmSpamCheckWPDisallowedWords.php + - classes/models/FrmUsage.php + - classes/models/fields/FrmFieldCaptcha.php + - classes/models/fields/FrmFieldCombo.php + - classes/models/fields/FrmFieldCreditCard.php + - classes/models/fields/FrmFieldHTML.php + - classes/models/fields/FrmFieldName.php + - classes/models/fields/FrmFieldNumber.php + - classes/models/fields/FrmFieldSubmit.php + - classes/models/fields/FrmFieldUserID.php + - classes/views/frm-form-actions/email_action.php + - classes/views/styles/components/FrmSliderStyleComponent.php + - classes/views/styles/components/FrmStyleComponent.php + - square/controllers/FrmSquareLiteActionsController.php + - square/helpers/FrmSquareLiteConnectHelper.php + - square/models/FrmSquareLiteSettings.php + - stripe/controllers/FrmStrpLiteEventsController.php + - stripe/controllers/FrmTransLitePaymentsController.php + - stripe/controllers/FrmTransLiteSubscriptionsController.php + - stripe/helpers/FrmStrpLiteAppHelper.php + - stripe/helpers/FrmStrpLiteConnectApiAdapter.php + - stripe/helpers/FrmStrpLiteSubscriptionHelper.php + - stripe/helpers/FrmTransLiteListHelper.php + - stripe/models/FrmStrpLiteSettings.php diff --git a/square/controllers/FrmSquareLiteSettingsController.php b/square/controllers/FrmSquareLiteSettingsController.php index 75aeab6d56..4dc99dd6e5 100644 --- a/square/controllers/FrmSquareLiteSettingsController.php +++ b/square/controllers/FrmSquareLiteSettingsController.php @@ -44,16 +44,6 @@ public static function global_settings_form( $atts = array() ) { include FrmSquareLiteAppHelper::plugin_path() . '/views/settings/form.php'; } - /** - * @return array - */ - private static function get_default_settings_atts() { - return array( - 'errors' => array(), - 'message' => '', - ); - } - /** * Handle processing changes to global Stripe Settings. * From 24c1cb517c2267b60ff59efcc0bef4cb775aa532 Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Fri, 12 Dec 2025 21:49:08 -0400 Subject: [PATCH 2/3] Also update config for results in an error. rule --- phpstan.neon | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/phpstan.neon b/phpstan.neon index 907ade415e..0633439eab 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -32,7 +32,6 @@ parameters: - '#is always (false|true)+.#' - '#no value type specified.#' - '#only iterables are supported#' - - '#results in an error.#' - '#will always evaluate to#' - '#in isset\(\) does not exist.#' - '#in empty\(\) is not falsy.#' @@ -278,3 +277,21 @@ parameters: - stripe/helpers/FrmStrpLiteSubscriptionHelper.php - stripe/helpers/FrmTransLiteListHelper.php - stripe/models/FrmStrpLiteSettings.php + - + message: '#results in an error.#' + paths: + - classes/controllers/FrmAddonsController.php + - classes/controllers/FrmAppController.php + - classes/controllers/FrmFormsController.php + - classes/helpers/FrmCSVExportHelper.php + - classes/helpers/FrmFieldsHelper.php + - classes/helpers/FrmFormsHelper.php + - classes/helpers/FrmFormsListHelper.php + - classes/helpers/FrmStylesHelper.php + - classes/helpers/FrmXMLHelper.php + - classes/models/FrmFieldFormHtml.php + - classes/models/FrmHoneypot.php + - classes/models/FrmReviews.php + - classes/models/fields/FrmFieldType.php + - stripe/controllers/FrmStrpLiteAppController.php + - stripe/helpers/FrmStrpLiteSubscriptionHelper.php From 02904a8042c86ce285a71c2097b7c47df76fdb18 Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Fri, 12 Dec 2025 21:49:56 -0400 Subject: [PATCH 3/3] Escape ? characters in phpstan neon --- phpstan.neon | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpstan.neon b/phpstan.neon index 0633439eab..b644d068ea 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -173,7 +173,7 @@ parameters: - classes/helpers/FrmFieldGridHelper.php - square/controllers/FrmSquareLiteActionsController.php - - message: '#on left side of ??#' + message: '#on left side of \?\?#' path: stripe/controllers/FrmTransLiteActionsController.php - message: '#fwrite expects resource, resource\|null given#'