Skip to content

Do not swallow error when importing plugins #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SuperSandro2000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not swallow error when importing plugins #1705

SuperSandro2000 wants to merge 1 commit into from
+11 −9

Conversation

@SuperSandro2000
Copy link

@SuperSandro2000 SuperSandro2000 commented Dec 7, 2025

I had an error in knot-resolver v6 when importing its plugin which before looked like:

Error: knot_resolver.controller.supervisord.plugin.patch_logger:inject cannot be resolved within [rpcinterface:patch_logger]

which was not very actionable or clear for me.

Now the error is:

Error: knot_resolver.controller.supervisord.plugin.patch_logger:inject cannot be resolved within [rpcinterface:patch_logger]: No module named 'knot_resolver'

SuperSandro2000
SuperSandro2000 commented Dec 7, 2025
View reviewed changes
supervisor/tests/test_options.py
'thisishopefullynotanimportablepackage:nonexistent cannot be '
'resolved within [eventlistener:cat]')
'resolved within [eventlistener:cat]: No module named '
'\'thisishopefullynotanimportablepackage\'')
Copy link
Author

@SuperSandro2000 SuperSandro2000 Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to handle the quoting issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SuperSandro2000