Old develop to Main#152
Merged
Merged
Conversation
* First commit of potential scope names * Initial split for ComputeAllScopes * Break ComputeAllScopes into 5 scopes * Remove commented off cell * Create scopes for Actuals, Cashflows and Openings * Implement feedback * Change modifier of amortizationFactor to public * Implement feedbackx2
* Add non-zero count checks in SequenceImportTest * Empty cell * Add ApplicationMessage log in ReportVariablesTest * Implement ActivityLog in: ImportStorageTest, MapTemplateAndImportTest, ReportStorageTest * Undo year and month checking in MapTemplateAndImportTest * Check year and month entries in YieldCurves and apply ActivityLog in QueriesTest * Apply ActivityLogs in AocStructureTest, ReportStorageTest, ReportVariablesTest and TechnicalMarginTest * Implement feedback * fixed ImportStorageTest Co-authored-by: Sara Busato <sbusato@systemorph.com>
* improvement in data structure and import scope calculation * minor
Co-authored-by: akatz <akatz1@systemorph.com>
dtrzesniak
approved these changes
Dec 22, 2022
nnikolopoulos
approved these changes
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge an old develop commit into Main branch.