Coverage parameter scenario#229
Merged
Merged
Conversation
dcolleoni
reviewed
Mar 10, 2023
dtrzesniak
reviewed
Mar 10, 2023
dtrzesniak
approved these changes
Mar 12, 2023
dcolleoni
reviewed
Mar 13, 2023
dcolleoni
reviewed
Mar 13, 2023
dcolleoni
reviewed
Mar 13, 2023
dcolleoni
reviewed
Mar 16, 2023
Contributor
|
Why do we have so many changes in BMs? is it because of the format we fixed? |
Contributor
Author
Not only, it is also because of line 570 of the Importers notebook, that is, variables scenarios that are equal to BE are not saved anymore. Before we didn't have this additional filter and we duplicated the values. The fact that only IfrsVars BMs changed and not ReportVars BMs is the sign that we were saving unnecessary variables that we can retrieve via relaxed query at report level. |
dcolleoni
reviewed
Mar 17, 2023
dcolleoni
reviewed
Mar 17, 2023
dcolleoni
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to introduce the possibility to import reinsurance coverage parameters for different scenarios.