Skip to content

Grouping scenario constants#241

Merged
tkukuljan merged 6 commits into
developfrom
ScenariosConstants
Mar 20, 2023
Merged

Grouping scenario constants#241
tkukuljan merged 6 commits into
developfrom
ScenariosConstants

Conversation

@tkukuljan
Copy link
Copy Markdown
Contributor

@tkukuljan tkukuljan commented Mar 17, 2023

Grouping the constants in the Sensitivity section of the Ifrs17/Constants/Consts into a static class, and doing the refactoring.
Replacing ToIdentityString with ToString, to improve performance.

@tkukuljan tkukuljan requested review from amuolo and dcolleoni March 17, 2023 11:04
@tkukuljan tkukuljan self-assigned this Mar 17, 2023
@tkukuljan tkukuljan added the enhancement New feature or request label Mar 17, 2023
@tkukuljan tkukuljan added this to the v1.1.x milestone Mar 17, 2023
@tkukuljan tkukuljan linked an issue Mar 17, 2023 that may be closed by this pull request
@tkukuljan tkukuljan changed the title Refactors Grouping scenario constants Mar 17, 2023
Comment thread ifrs17/Report/ReportMutableScopes.ipynb Outdated
@dcolleoni dcolleoni mentioned this pull request Mar 20, 2023
@tkukuljan tkukuljan marked this pull request as ready for review March 20, 2023 13:24
@tkukuljan tkukuljan merged commit d68e6da into develop Mar 20, 2023
@tkukuljan tkukuljan deleted the ScenariosConstants branch March 20, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Scenario improvements from PR #232

2 participants