Conversation
* version 1 with everything * much better performance * Including filters to cache datacubes efficiently * implement Daniel feedback --------- Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
* scaffolding, snapshot and scheme * migration flow and some comments * update Configure * explanation file * configure * explain * comments * All the comments added * Update ReadMe.ipynb typo fixed * address the comment * Update ReadMe.ipynb comments resolved * Update ReadMe.ipynb typos fixed * Update ReadMe.ipynb typo * Update ReadMe.ipynb wording change * Update Scaffold.ipynb wording * Title and some minor explanations added --------- Co-authored-by: akatz <akatz1@systemorph.com>
* generalization * more concise switch * typo * messages fixed * changed api one again * api update * new api * full update * new api * new API in tests * identation * Update ActivityLog.ipynb typo fixed * idents fixed --------- Co-authored-by: akatz <akatz1@systemorph.com>
* generalization * more concise switch * typo * messages fixed * changed api one again * api update * new api * full update * start debugging * first attempt to fix the opening format. Not yet sure if it works. The changes in the DataNode format must be reset * bug fix * fix * restore unnecessary changes * reset unnecessary changes * reset * reset * new api * new API in tests * identation * syntax change * Update ActivityLog.ipynb typo fixed * idents fixed * Update ActivityLog.ipynb restore the rows that were removed by mistake in the merger --------- Co-authored-by: akatz <akatz1@systemorph.com>
* Replace GetElementOrDefault with GetValidElement * Rename array to collection * Remove obsolete case * Create error for negative index and apply it * Better error message * Add .ToHashSet() in ApplicationMessage AcivityLog Mege * Implement feedback * Implement feedbackx2
* template * pv * CE
Remove with { Height } from Reports
* Replace DataSource with options.TargetDataSource for A and CF and adjust SequenceImportTest * Fix .WithActivityLog() * Replace DataSource with options.TargetDataSource except in CommitPartitionAsync (remove empty cell and fix markdown typo) * Fix MapTemplateAndImportTest * Use disposable Workspaces
Co-authored-by: akatz <akatz1@systemorph.com>
* Develop (with removed Arithmetic) to Main (#63) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * update packages and fix csm with bm * approaching * better * implement feedback * final feedback * fix * const version ce * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * final fixes and feedback implementations Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com> Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * Dev to main (#66) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * update packages and fix csm with bm * approaching * better * implement feedback * final feedback * fix * const version ce * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * final fixes and feedback implementations * Interactive reports (#58) * Ifrs17ReportScopes * wip * latest * add other reports * start with pv * filter does not work * clean up * clean up reports * clean up * typo * move it ce * remove partition set * adjust reporting * test readme with relative path for image * back to absolute path - bug in the portal - * wip * settle with identities * some more docs * adding rn and period selector * New format design in importers (#62) * Define new ImportFormats * Apply import w format in DN, DNS, DP, CF * Apply import w format in A, SV and O * Correct Import statements * Replace abs link with var link * Adjust naming convention * Adjust new import format in full-template * Package update (#65) * update packages * add anchors Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com> Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * Update issue templates (#69) * Dev to main (#84) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * still not working properly * code cleanup * new file creation * update packages and fix csm with bm * approaching * better * testing ifrsvariables * implement feedback * final feedback * fix * const version ce * testing IfrsVariables calculations * new partition added * implementing new test * test cleaned * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * testing queries * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * checking multiple import of the same scenario * final fixes and feedback implementations * dynamic problems solved * fixing aoctype for scenario * Interactive reports (#58) * Ifrs17ReportScopes * wip * latest * add other reports * start with pv * filter does not work * clean up * clean up reports * clean up * typo * move it ce * remove partition set * adjust reporting * test readme with relative path for image * back to absolute path - bug in the portal - * wip * settle with identities * some more docs * adding rn and period selector * test for actualsr * code cleanup * New format design in importers (#62) * Define new ImportFormats * Apply import w format in DN, DNS, DP, CF * Apply import w format in A, SV and O * Correct Import statements * Replace abs link with var link * Adjust naming convention * Adjust new import format in full-template * forward * Package update (#65) * update packages * add anchors * cleanups * Fixing AA and OA opening and benchmark simple importer (#57) * Fixing input data * Workaround for bm generation * Fixed GetSign * Inputs * Fixed Importers * add some doc * fixed CU * Dirty fix on signs * undo CU sign * wip * Fix signs * Init * fix * fix * exclude simple value from test * some partial fix * Full fix * much better * implemented * Aggregate by in report variable (#67) * included back AggregateBy * included Currency column in ReportVariable benchmarks * Clean up doc (#71) * remove spec tests * read me and big picture * help review * code of conduct. Readme. Remove Spec tests * env for go live * rename of directories in file * overview template * improve template readme * calculation engine and reports in template * more on ifrs17ce * NB titles * clean up display order * improve validation * fix links * fix link * Close import template * additions to report guide * solve conflicts * implement feedback * cleanups * cleanups x2 * fixes needed after merge * all tests are green * implement feedback * Doc cleanup2 (#76) * forbiddenSlices and chose init or db connection * clean ups * small letters to capital * complete sentence about filters * implement all feedbacks * packages + withGridOption + await HierarchyCache init (#83) Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com> Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Danilo Calderini <dcalderini@systemorph.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * Dev to main (#86) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * still not working properly * code cleanup * new file creation * update packages and fix csm with bm * approaching * better * testing ifrsvariables * implement feedback * final feedback * fix * const version ce * testing IfrsVariables calculations * new partition added * implementing new test * test cleaned * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * testing queries * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * checking multiple import of the same scenario * final fixes and feedback implementations * dynamic problems solved * fixing aoctype for scenario * Interactive reports (#58) * Ifrs17ReportScopes * wip * latest * add other reports * start with pv * filter does not work * clean up * clean up reports * clean up * typo * move it ce * remove partition set * adjust reporting * test readme with relative path for image * back to absolute path - bug in the portal - * wip * settle with identities * some more docs * adding rn and period selector * test for actualsr * code cleanup * New format design in importers (#62) * Define new ImportFormats * Apply import w format in DN, DNS, DP, CF * Apply import w format in A, SV and O * Correct Import statements * Replace abs link with var link * Adjust naming convention * Adjust new import format in full-template * forward * Package update (#65) * update packages * add anchors * cleanups * Fixing AA and OA opening and benchmark simple importer (#57) * Fixing input data * Workaround for bm generation * Fixed GetSign * Inputs * Fixed Importers * add some doc * fixed CU * Dirty fix on signs * undo CU sign * wip * Fix signs * Init * fix * fix * exclude simple value from test * some partial fix * Full fix * much better * implemented * Aggregate by in report variable (#67) * included back AggregateBy * included Currency column in ReportVariable benchmarks * Clean up doc (#71) * remove spec tests * read me and big picture * help review * code of conduct. Readme. Remove Spec tests * env for go live * rename of directories in file * overview template * improve template readme * calculation engine and reports in template * more on ifrs17ce * NB titles * clean up display order * improve validation * fix links * fix link * Close import template * additions to report guide * solve conflicts * implement feedback * cleanups * cleanups x2 * fixes needed after merge * all tests are green * implement feedback * Doc cleanup2 (#76) * forbiddenSlices and chose init or db connection * clean ups * small letters to capital * complete sentence about filters * implement all feedbacks * packages + withGridOption + await HierarchyCache init (#83) * Change in ReportMutableScopes NB * Change in ReportMutableScopes NB (#85) Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com> Co-authored-by: Davide Colleoni <103409906+dcolleoni@users.noreply.github.com> Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Danilo Calderini <dcalderini@systemorph.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * delete full template dir * remove images * Openings: remove reimport duplicates (#150) * fixed ImportStorage queries for openings * clean up * debug import scopes * enhance technical margin test - reproduce the bug - * fix and increase test coverage * clean up * typos --------- Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com> Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> Co-authored-by: Danilo Calderini <dcalderini@systemorph.com>
* enable scenario switch * fix and improve existing scenario tests * bug fix import yield curve * only fixes and tests * fix scenario reports --------- Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
* enable scenario switch * fix and improve existing scenario tests * bug fix import yield curve * parameter import done, tests green * implement feedback * remove simple value * implement feedback * update benchmark * rounding digit when exporting ifrs vars * openings format for reimport best estimate * implement improvements suggested from Davide --------- Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
* Refactors * Replacing ToIdentityString with the ToStringWith. * Renaming the method ToStringWith * Adding IdentityPropertyReader and adapting the code * IdentityPropertyReader with Expressions
* copying over * end of week version * update * safe state? * working version * Some clean up * adding reports * update * adding comments and todos * Allow overwriting filter names. Add Delta and all to the scenarios list (hardcoded at this point) * all the filters are separately defined * incorporate exports. Appropriate changes to the report storage are made * filter changes + adapt old api * for objects: almost works, it is an advanced sketch * merge changes * incorporates parameter report -- for object * stopgap solution for csv and excel reports included. * resolve merge conflict * add filters * reference to disposable workspaces * filters, scenario, slices * Reports split to notebook per each report + some modifications * minor fix in parameter mutable reports * Typos fixed, pseudo-fix for the threading issue removed and added slices to the parameter reports * filters fix * filter fix * some changes to the reports * interactive reports * solve merge conflicts in tests * fixes a nasty bug that shows up when there is no data. * Some comments addressed and moved the types of parameter reports into an enum * Changed to FirstOrDefault() / LastOrDefault() * syntax simplificattion * routines renamed * typo fixed * syntax change to Any() * move import types and forms into the CE * small refactor of specific filter * fix failing tests * increase memory recommended * enums moved to classes + routine to query constant attributes of a class * bug fixed + produce param reports menu from method rather than enum * Added a comment about null reports * Generalization of the interactive mutable scopes * Align with the API * Move initializations to the LoadData and add exports to excel * Initialization to ParameterReportScope * parameter interactive some refinement * export description * report markdown * comment ToExcelInteractive * switch case in the data scope * remove treatment of annual cohort * with activity log * remove hardcoded --------- Co-authored-by: akatz <akatz1@systemorph.com> Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com>
* starting with some data * refine gross data * remove old files * more data in * some more * some more file review * Precision and Report Scopes * improving reports nb * refinement * Reverting the changes and renaming the nominals * Reseting the change * separating the practical case tests * Reverting the merge mistakes and updating the ScenarioParametersImportTest * Reseting the disposable workspace back to the DataSource. * small doc update * Typo and update of Ifrs17 creation --------- Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com>
* new scenario data queries tests * add yield curve for scenarios test * implement Davide feedback * more tests * add small description to use cases --------- Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com>
reference v1.2.0 in Template proj
# Conflicts: # ifrs17-template/Constants/CalculationEngine.ipynb # ifrs17-template/Export/MapTemplate.ipynb # ifrs17-template/Import/CloseImportTemplate.ipynb # ifrs17-template/InputFormatDescription.ipynb # ifrs17-template/Report/ParameterReports.ipynb # ifrs17-template/Report/Reports.ipynb
nnikolopoulos
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.