From e072f8ecbeb58c5c416b890422a79eb870a7b7c5 Mon Sep 17 00:00:00 2001 From: Slavomir Batka Date: Fri, 30 Jun 2023 11:15:52 +0200 Subject: [PATCH 1/2] get GetReportingPeriod getter --- ifrs17/Import/ImportStorage.ipynb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ifrs17/Import/ImportStorage.ipynb b/ifrs17/Import/ImportStorage.ipynb index aa2f30e9..3bcd92a6 100644 --- a/ifrs17/Import/ImportStorage.ipynb +++ b/ifrs17/Import/ImportStorage.ipynb @@ -318,6 +318,12 @@ "\n", "\n public DataNodeData GetDataNodeData(ImportIdentity id) => DataNodeDataBySystemName[id.DataNode];", "\n", + "\n public (int Year, int Month) GetReportingPeriod(int period) => period == CurrentPeriod ?", + "\n CurrentReportingPeriod :", + "\n period == PreviousPeriod ? ", + "\n PreviousReportingPeriod :", + "\n (0, 0);", + "\n ", "\n //YieldCurve", "\n public double[] GetYearlyYieldCurve(ImportIdentity id, string economicBasis) {", "\n var yc = GetYieldCurve(id, economicBasis);", From 65a22e5c8b3ced55a9ec8be29676d76f97ae8d28 Mon Sep 17 00:00:00 2001 From: Slavomir Batka Date: Fri, 30 Jun 2023 19:56:41 +0200 Subject: [PATCH 2/2] validation --- ifrs17/Constants/Validations.ipynb | 6 ++++-- ifrs17/Import/ImportStorage.ipynb | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ifrs17/Constants/Validations.ipynb b/ifrs17/Constants/Validations.ipynb index 1540c2f9..c7630623 100644 --- a/ifrs17/Constants/Validations.ipynb +++ b/ifrs17/Constants/Validations.ipynb @@ -79,7 +79,7 @@ "\n // Parameters", "\n ReinsuranceCoverageDataNode, DuplicateInterDataNode, DuplicateSingleDataNode, InvalidDataNode, InvalidDataNodeForOpening, InvalidCashFlowPeriodicity, MissingInterpolationMethod, InvalidInterpolationMethod, InvalidEconomicBasisDriver, InvalidReleasePattern,", "\n // Storage", - "\n DataNodeNotFound, PartnerNotFound, RatingNotFound, CreditDefaultRateNotFound, MissingPremiumAllocation, ReinsuranceCoverage, ", + "\n DataNodeNotFound, PartnerNotFound, PeriodNotFound, RatingNotFound, CreditDefaultRateNotFound, MissingPremiumAllocation, ReinsuranceCoverage, ", "\n YieldCurveNotFound, YieldCurvePeriodNotApplicable, EconomicBasisNotFound, AccountingVariableTypeNotFound,", "\n // Scopes", "\n NotSupportedAocStepReference, MultipleEoP,", @@ -165,6 +165,7 @@ "\n // Storage", "\n (Error.DataNodeNotFound , 1) => $\"DataNode {s[0]} not found.\",", "\n (Error.PartnerNotFound , 1) => $\"Partner not found for DataNode {s[0]}.\",", + "\n (Error.PeriodNotFound , 1) => $\"Current nor Previous Period not found for given period {s[0]}.\",", "\n (Error.RatingNotFound , 1) => $\"Rating not found for Partner {s[0]}.\",", "\n (Error.CreditDefaultRateNotFound , 1) => $\"Credit Default Rate not found for rating {s[0]}.\",", "\n (Error.MissingPremiumAllocation , 1) => $\"Premium Allocation Rate not found for Group of Contract {s[0]}.\", // TODO: this is now a warning to be produced by a validation in the importers (default is 1)", @@ -185,7 +186,8 @@ "\n // Default", "\n (Error.Generic , _) => $\"{s[0]}\",", "\n (_ , _) => $\"Error not found.\"", - "\n};" + "\n};", + "\n" ], "metadata": {}, "execution_count": 0, diff --git a/ifrs17/Import/ImportStorage.ipynb b/ifrs17/Import/ImportStorage.ipynb index 3bcd92a6..b7375dc8 100644 --- a/ifrs17/Import/ImportStorage.ipynb +++ b/ifrs17/Import/ImportStorage.ipynb @@ -322,7 +322,7 @@ "\n CurrentReportingPeriod :", "\n period == PreviousPeriod ? ", "\n PreviousReportingPeriod :", - "\n (0, 0);", + "\n ((int, int))ApplicationMessage.Log(Error.PeriodNotFound, period.ToString());", "\n ", "\n //YieldCurve", "\n public double[] GetYearlyYieldCurve(ImportIdentity id, string economicBasis) {",