Skip to content

Contract term Followup #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbatka merged 2 commits into from
Jul 3, 2023
Merged

Contract term Followup #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e072f8e
get GetReportingPeriod getter
sbatka Jun 30, 2023
65a22e5
validation
sbatka Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ifrs17/Constants/Validations.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"\n // Parameters",
"\n ReinsuranceCoverageDataNode, DuplicateInterDataNode, DuplicateSingleDataNode, InvalidDataNode, InvalidDataNodeForOpening, InvalidCashFlowPeriodicity, MissingInterpolationMethod, InvalidInterpolationMethod, InvalidEconomicBasisDriver, InvalidReleasePattern,",
"\n // Storage",
"\n DataNodeNotFound, PartnerNotFound, RatingNotFound, CreditDefaultRateNotFound, MissingPremiumAllocation, ReinsuranceCoverage, ",
"\n DataNodeNotFound, PartnerNotFound, PeriodNotFound, RatingNotFound, CreditDefaultRateNotFound, MissingPremiumAllocation, ReinsuranceCoverage, ",
"\n YieldCurveNotFound, YieldCurvePeriodNotApplicable, EconomicBasisNotFound, AccountingVariableTypeNotFound,",
"\n // Scopes",
"\n NotSupportedAocStepReference, MultipleEoP,",
Expand Down Expand Up @@ -165,6 +165,7 @@
"\n // Storage",
"\n (Error.DataNodeNotFound , 1) => $\"DataNode {s[0]} not found.\",",
"\n (Error.PartnerNotFound , 1) => $\"Partner not found for DataNode {s[0]}.\",",
"\n (Error.PeriodNotFound , 1) => $\"Current nor Previous Period not found for given period {s[0]}.\",",
"\n (Error.RatingNotFound , 1) => $\"Rating not found for Partner {s[0]}.\",",
"\n (Error.CreditDefaultRateNotFound , 1) => $\"Credit Default Rate not found for rating {s[0]}.\",",
"\n (Error.MissingPremiumAllocation , 1) => $\"Premium Allocation Rate not found for Group of Contract {s[0]}.\", // TODO: this is now a warning to be produced by a validation in the importers (default is 1)",
Expand All @@ -185,7 +186,8 @@
"\n // Default",
"\n (Error.Generic , _) => $\"{s[0]}\",",
"\n (_ , _) => $\"Error not found.\"",
"\n};"
"\n};",
"\n"
],
"metadata": {},
"execution_count": 0,
Expand Down
6 changes: 6 additions & 0 deletions ifrs17/Import/ImportStorage.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,12 @@
"\n",
"\n public DataNodeData GetDataNodeData(ImportIdentity id) => DataNodeDataBySystemName[id.DataNode];",
"\n",
"\n public (int Year, int Month) GetReportingPeriod(int period) => period == CurrentPeriod ?",
"\n CurrentReportingPeriod :",
"\n period == PreviousPeriod ? ",
"\n PreviousReportingPeriod :",
"\n ((int, int))ApplicationMessage.Log(Error.PeriodNotFound, period.ToString());",
"\n ",
"\n //YieldCurve",
"\n public double[] GetYearlyYieldCurve(ImportIdentity id, string economicBasis) {",
"\n var yc = GetYieldCurve(id, economicBasis);",
Expand Down