Skip to content

359 extendable warnings and errors#362

Merged
andrey-katz-systemorph merged 22 commits into
developfrom
359_ExtendableWarningsAndErrors
Aug 8, 2023
Merged

359 extendable warnings and errors#362
andrey-katz-systemorph merged 22 commits into
developfrom
359_ExtendableWarningsAndErrors

Conversation

@andrey-katz-systemorph
Copy link
Copy Markdown
Contributor

@andrey-katz-systemorph andrey-katz-systemorph commented Aug 2, 2023

Extends the enumerables of the errors and warnings to the classes in a minimal possible way in order not to break the existing code, allowing however the inheritance by external projects. The only caveat of this approach is the way switch is going to work (when must be invoked).

@andrey-katz-systemorph andrey-katz-systemorph marked this pull request as draft August 2, 2023 14:33
@andrey-katz-systemorph andrey-katz-systemorph marked this pull request as ready for review August 3, 2023 08:22
Comment thread ifrs17/Constants/Validations.ipynb Outdated
Comment thread ifrs17/Constants/Validations.ipynb Outdated
Comment thread ifrs17/Constants/Validations.ipynb
Comment thread ifrs17/Constants/Validations.ipynb
@dcolleoni
Copy link
Copy Markdown
Contributor

Dear @andrey-katz-systemorph ,
pls add a correction to the CalculationEngine NB in template/Constant => variable calculationEngine is currently wrong in develop branch.

Thanks.

andrey-katz-systemorph and others added 3 commits August 8, 2023 10:42
Return the reference to the CE to the original form, similar to the prod
@andrey-katz-systemorph
Copy link
Copy Markdown
Contributor Author

Dear @andrey-katz-systemorph , pls add a correction to the CalculationEngine NB in template/Constant => variable calculationEngine is currently wrong in develop branch.

Thanks.

I reverted it to what we currently have on the prod.

@andrey-katz-systemorph andrey-katz-systemorph merged commit d78e480 into develop Aug 8, 2023
@andrey-katz-systemorph andrey-katz-systemorph deleted the 359_ExtendableWarningsAndErrors branch August 8, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow client project to easily extend Validation notebook

3 participants