Skip to content

Present value series#70

Merged
amuolo merged 27 commits into
developfrom
present_value_series
Nov 18, 2022
Merged

Present value series#70
amuolo merged 27 commits into
developfrom
present_value_series

Conversation

@tkukuljan
Copy link
Copy Markdown
Contributor

@tkukuljan tkukuljan commented Nov 4, 2022

Only change in the Calculation Engine is setting partitions in "QueryReportVariablesAsync" (done by Andrea).

TODOs:

  • readme can be polished,
  • Import Format "Cashflow" needs to be adapted still to ignore missing column "AccidentYear", but the columns are removed from excel files,
  • static methods from "CalculationEngine.ipynb" can be moved to utils,
  • test "PresentValues - Episode 2" and "PresentValues - Episode 3" one last time.

@nnikolopoulos nnikolopoulos added the enhancement New feature or request label Nov 7, 2022
@dtrzesniak
Copy link
Copy Markdown

dtrzesniak commented Nov 7, 2022

A few general comments:
1 - please have all file extensions lower case: PNG should be png.
2 - do we want to mix input files in .xls and .csv? Are we trying to show we can work with both formats? If not, I would stick to one of them for all inputs.

@dtrzesniak
Copy link
Copy Markdown

dtrzesniak commented Nov 7, 2022 •
edited
Loading

[DemoPresentValue.PNG] --> I find it a bit confusing. Discount and Cumulate need the Discount Rates, they don't come at the end after the AOC delta calculation.

Also only Yield Curves are Economic Input --> Cashflows are Insurance Input

dtrzesniak
dtrzesniak reviewed Nov 7, 2022
View reviewed changes
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
@dtrzesniak
Copy link
Copy Markdown

dtrzesniak commented Nov 7, 2022

Maybe you still need some clean up, as many things seem still to be WIP

@dcolleoni dcolleoni added this to the Go-live milestone Nov 8, 2022
dcolleoni
dcolleoni reviewed Nov 8, 2022
View reviewed changes
Comment thread ifrs17/Report/ReportConfigurationAndUtils.ipynb Outdated
@dcolleoni
Copy link
Copy Markdown
Contributor

dcolleoni commented Nov 8, 2022

It is difficult to track changes to xlsx in git. Can we use csv as in the other projects?

dcolleoni
dcolleoni reviewed Nov 8, 2022
View reviewed changes
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
dcolleoni
dcolleoni reviewed Nov 8, 2022
View reviewed changes
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
dcolleoni
dcolleoni reviewed Nov 8, 2022
View reviewed changes
Comment thread PresentValueSeries/CalculationEngine.ipynb Outdated
@amuolo amuolo self-assigned this Nov 10, 2022
@amuolo amuolo linked an issue Nov 10, 2022 that may be closed by this pull request
Marketing material for IFRS17-Template #49
Closed
dcolleoni
dcolleoni approved these changes Nov 17, 2022
View reviewed changes
Comment thread PresentValueSeries/Readme.md Outdated
Comment thread PresentValueSeries/Readme.md Outdated
Comment thread PresentValueSeries/Readme.md Outdated
Comment thread PresentValueSeries/Readme.md Outdated
Comment thread full-ifrs17-template/Report/Reports.ipynb Outdated
Comment thread PresentValueSeries/PresentValue - Episode 2.ipynb Outdated
Comment thread PresentValueSeries/Readme.md Outdated
Comment thread PresentValueSeries/Readme.md Outdated
Comment thread PresentValueSeries/Readme.md Outdated
Comment thread ifrs17/Import/Importers.ipynb Outdated
dcolleoni
dcolleoni approved these changes Nov 17, 2022
View reviewed changes
Comment thread PresentValueSeries/Readme.md Outdated
@ghost
Copy link
Copy Markdown

ghost commented Nov 18, 2022

Nice PR, good features.

@amuolo amuolo merged commit d8f1240 into develop Nov 18, 2022
@amuolo amuolo deleted the present_value_series branch November 18, 2022 10:22
dtrzesniak pushed a commit that referenced this pull request Nov 23, 2022
@tkukuljan
Present value series (#70)
d29b190 
* Uploading the files to start working with.

* Finsihing with the second video, up to some corrections coming up.

* Finishing the notebook for the third video.

* Work on readme

* some commit

* Updating to the newest calculation engine, updating readme.

* simpler names + no mandatory accidentYear

* better

* fix Application Message

* better x2

* compute discount and cumulate

* implement feedback

* improve overall

* aoc configuration

* better importers

* reset and initialize only once

* solve remaining merge conflict

* revisions for signs + new overview

* metadata + fix importers validate datanode

* extra type + utils reports

* implement all feedback

* updated links YT

Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
dtrzesniak pushed a commit that referenced this pull request Nov 23, 2022
@tkukuljan
Present value series (#70)
bff5a40 
* Uploading the files to start working with.

* Finsihing with the second video, up to some corrections coming up.

* Finishing the notebook for the third video.

* Work on readme

* some commit

* Updating to the newest calculation engine, updating readme.

* simpler names + no mandatory accidentYear

* better

* fix Application Message

* better x2

* compute discount and cumulate

* implement feedback

* improve overall

* aoc configuration

* better importers

* reset and initialize only once

* solve remaining merge conflict

* revisions for signs + new overview

* metadata + fix importers validate datanode

* extra type + utils reports

* implement all feedback

* updated links YT

Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
dtrzesniak pushed a commit that referenced this pull request Nov 29, 2022
@tkukuljan
Present value series (#70)
23c4cf2 
* Uploading the files to start working with.

* Finsihing with the second video, up to some corrections coming up.

* Finishing the notebook for the third video.

* Work on readme

* some commit

* Updating to the newest calculation engine, updating readme.

* simpler names + no mandatory accidentYear

* better

* fix Application Message

* better x2

* compute discount and cumulate

* implement feedback

* improve overall

* aoc configuration

* better importers

* reset and initialize only once

* solve remaining merge conflict

* revisions for signs + new overview

* metadata + fix importers validate datanode

* extra type + utils reports

* implement all feedback

* updated links YT

Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@amuolo amuolo amuolo left review comments

@dtrzesniak dtrzesniak dtrzesniak left review comments

@dcolleoni dcolleoni dcolleoni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amuolo amuolo

@tkukuljan tkukuljan

Labels

enhancement New feature or request

Projects

IFRS17 Calculation Engine
Status: ✅ Done

Milestone

Go-live

Development

Successfully merging this pull request may close these issues.

Marketing material for IFRS17-Template

5 participants

@tkukuljan @dtrzesniak @dcolleoni @amuolo @nnikolopoulos