From 5ce555ce6ee87e7d6c3dff919802a9e07dab43e4 Mon Sep 17 00:00:00 2001 From: Kamran Ayub Date: Fri, 3 Apr 2020 14:10:32 -0500 Subject: [PATCH 1/2] Add test for throwOnError --- src/tests/queryCache.test.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/tests/queryCache.test.js b/src/tests/queryCache.test.js index 03d1577aabc..5acaa918463 100644 --- a/src/tests/queryCache.test.js +++ b/src/tests/queryCache.test.js @@ -24,6 +24,20 @@ describe('queryCache', () => { expect(second).toBe(first) }) + test('prefetchQuery should throw error when throwOnError is true', async () => { + const fetchFn = () => + new Promise(() => { + throw new Error('error') + }) + + await expect( + queryCache.prefetchQuery('key', undefined, fetchFn, { + retry: false, + throwOnError: true, + }) + ).rejects.toThrow(new Error('error')) + }) + test('should notify listeners when new query is added', () => { const callback = jest.fn() From e6b05d7dbb9aeaf416b506fc8f427cc1fc8890e5 Mon Sep 17 00:00:00 2001 From: Kamran Ayub Date: Fri, 3 Apr 2020 14:20:26 -0500 Subject: [PATCH 2/2] Uncomment throw error --- src/queryCache.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/queryCache.js b/src/queryCache.js index 00dc91a4fc1..69d8a636dd8 100644 --- a/src/queryCache.js +++ b/src/queryCache.js @@ -413,7 +413,7 @@ export function makeQueryCache() { instance.onSettled && instance.onSettled(undefined, error) ) - // throw error + throw error } } })()