From 16de4ac801727a9242a3a1d2eb6da6e6bfb7646f Mon Sep 17 00:00:00 2001 From: Alexander Date: Sat, 6 Jan 2024 21:45:45 +0100 Subject: [PATCH 1/3] perf: use shallowRef --- packages/vue-query/src/useQueries.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/vue-query/src/useQueries.ts b/packages/vue-query/src/useQueries.ts index 3b190b374d1..c710e24b213 100644 --- a/packages/vue-query/src/useQueries.ts +++ b/packages/vue-query/src/useQueries.ts @@ -5,13 +5,13 @@ import { getCurrentScope, onScopeDispose, readonly, - ref, + shallowRef, watch, } from 'vue-demi' import { useQueryClient } from './useQueryClient' import { cloneDeepUnref } from './utils' -import type { Ref } from 'vue-demi' +import type { ShallowRef } from 'vue-demi' import type { DefaultError, DefinedQueryObserverResult, @@ -259,7 +259,7 @@ export function useQueries< combine?: (result: UseQueriesResults) => TCombinedResult }, queryClient?: QueryClient, -): Readonly> { +): Readonly> { if (process.env.NODE_ENV === 'development') { if (!getCurrentScope()) { console.warn( @@ -294,7 +294,7 @@ export function useQueries< defaultedQueries.value, (options as QueriesObserverOptions).combine, ) - const state = ref(getCombinedResult()) as Ref + const state = shallowRef(getCombinedResult()) as ShallowRef let unsubscribe = () => { // noop @@ -343,5 +343,5 @@ export function useQueries< unsubscribe() }) - return readonly(state) as Readonly> + return readonly(state) as Readonly> } From 031ce5243bb583cc6aa58054602ab1648ffaec4c Mon Sep 17 00:00:00 2001 From: Alexander Date: Mon, 8 Jan 2024 11:04:24 +0100 Subject: [PATCH 2/3] chore: lint --- packages/vue-query/src/useQueries.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vue-query/src/useQueries.ts b/packages/vue-query/src/useQueries.ts index c710e24b213..f4e2f43f2df 100644 --- a/packages/vue-query/src/useQueries.ts +++ b/packages/vue-query/src/useQueries.ts @@ -294,7 +294,7 @@ export function useQueries< defaultedQueries.value, (options as QueriesObserverOptions).combine, ) - const state = shallowRef(getCombinedResult()) as ShallowRef + const state = shallowRef(getCombinedResult()) let unsubscribe = () => { // noop From 9d4862eea107d13f34dd3f7097b16d996427f5aa Mon Sep 17 00:00:00 2001 From: Damian Osipiuk Date: Sat, 13 Jan 2024 00:30:01 +0100 Subject: [PATCH 3/3] chore: format with prettier --- packages/vue-query/src/useQueries.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vue-query/src/useQueries.ts b/packages/vue-query/src/useQueries.ts index f4e2f43f2df..249598196e0 100644 --- a/packages/vue-query/src/useQueries.ts +++ b/packages/vue-query/src/useQueries.ts @@ -294,7 +294,7 @@ export function useQueries< defaultedQueries.value, (options as QueriesObserverOptions).combine, ) - const state = shallowRef(getCombinedResult()) + const state = shallowRef(getCombinedResult()) let unsubscribe = () => { // noop