From 34a159d1d4db6aa8c99e3e18ad908f07fdff477c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mika=C3=ABl=20S=C3=A9vigny?= <39170229+sevignator@users.noreply.github.com> Date: Tue, 22 Apr 2025 11:49:05 -0400 Subject: [PATCH 1/3] Remove trailing comma in JSON snippet Since JSON doesn't allow for trailing commas. --- docs/start/framework/react/build-from-scratch.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/start/framework/react/build-from-scratch.md b/docs/start/framework/react/build-from-scratch.md index 5cb2e8e4837..fea5bffe9db 100644 --- a/docs/start/framework/react/build-from-scratch.md +++ b/docs/start/framework/react/build-from-scratch.md @@ -38,7 +38,7 @@ We highly recommend using TypeScript with TanStack Start. Create a `tsconfig.jso "module": "ESNext", "target": "ES2022", "skipLibCheck": true, - "strictNullChecks": true, + "strictNullChecks": true }, } ``` From d0b3b137202e5fb37d2061cd65c3badd25fb7c5d Mon Sep 17 00:00:00 2001 From: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com> Date: Wed, 23 Apr 2025 13:18:45 +1200 Subject: [PATCH 2/3] switch from `jsonc` to `jsonc` --- docs/start/framework/react/build-from-scratch.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/start/framework/react/build-from-scratch.md b/docs/start/framework/react/build-from-scratch.md index fea5bffe9db..055526d7f81 100644 --- a/docs/start/framework/react/build-from-scratch.md +++ b/docs/start/framework/react/build-from-scratch.md @@ -30,7 +30,7 @@ npm init -y We highly recommend using TypeScript with TanStack Start. Create a `tsconfig.json` file with at least the following settings: -```jsonc +```json { "compilerOptions": { "jsx": "react-jsx", @@ -39,7 +39,7 @@ We highly recommend using TypeScript with TanStack Start. Create a `tsconfig.jso "target": "ES2022", "skipLibCheck": true, "strictNullChecks": true - }, + } } ``` From de976b22dacfb1e60d3e56837cfeb26c80da533f Mon Sep 17 00:00:00 2001 From: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com> Date: Wed, 23 Apr 2025 13:19:31 +1200 Subject: [PATCH 3/3] also for Solid --- docs/start/framework/solid/build-from-scratch.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/start/framework/solid/build-from-scratch.md b/docs/start/framework/solid/build-from-scratch.md index 6e00a653240..c5fcdb35632 100644 --- a/docs/start/framework/solid/build-from-scratch.md +++ b/docs/start/framework/solid/build-from-scratch.md @@ -30,7 +30,7 @@ npm init -y We highly recommend using TypeScript with TanStack Start. Create a `tsconfig.json` file with at least the following settings: -```jsonc +```json { "compilerOptions": { "jsx": "preserve", @@ -39,8 +39,8 @@ We highly recommend using TypeScript with TanStack Start. Create a `tsconfig.jso "module": "ESNext", "target": "ES2022", "skipLibCheck": true, - "strictNullChecks": true, - }, + "strictNullChecks": true + } } ```