From 5a5285a0a782faa65acfc0723f2a5729554d0f03 Mon Sep 17 00:00:00 2001
From: Birk Skyum <birk.skyum@pm.me>
Date: Sun, 26 Oct 2025 00:12:23 +0200
Subject: [PATCH] test(solid-router): un-skip link tests

---
 packages/solid-router/src/link.tsx        |  2 +-
 packages/solid-router/tests/link.test.tsx | 17 ++++++++---------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/packages/solid-router/src/link.tsx b/packages/solid-router/src/link.tsx
index 407f106d36b..d8cc8656907 100644
--- a/packages/solid-router/src/link.tsx
+++ b/packages/solid-router/src/link.tsx
@@ -260,7 +260,7 @@ export function useLinkProps<
       propsSafeToSpread,
       {
         ref,
-        href: externalLink,
+        href: externalLink(),
       },
       Solid.splitProps(local, [
         'target',
diff --git a/packages/solid-router/tests/link.test.tsx b/packages/solid-router/tests/link.test.tsx
index 93f6988c0e1..347f36362e5 100644
--- a/packages/solid-router/tests/link.test.tsx
+++ b/packages/solid-router/tests/link.test.tsx
@@ -675,8 +675,7 @@ describe('Link', () => {
     expect(pageZero).toBeInTheDocument()
   })
 
-  // TODO - THIS WORKS IN REACT
-  test.skip('when navigation to . from /posts while updating search from /', async () => {
+  test('when navigation to . from /posts while updating search from /', async () => {
     const RootComponent = () => {
       return (
         <>
@@ -774,12 +773,13 @@ describe('Link', () => {
 
     fireEvent.click(updateSearchLink)
 
+    const updatedPage = await screen.findByTestId('current-page')
+    const updatedFilter = await screen.findByTestId('current-filter')
+
     // Verify search was updated
     expect(window.location.pathname).toBe('/posts')
     expect(window.location.search).toBe('?page=2&filter=inactive')
 
-    const updatedPage = await screen.findByTestId('current-page')
-    const updatedFilter = await screen.findByTestId('current-filter')
     expect(updatedPage).toHaveTextContent('Page: 2')
     expect(updatedFilter).toHaveTextContent('Filter: inactive')
   })
@@ -1627,8 +1627,7 @@ describe('Link', () => {
     expect(window.location.pathname).toBe('/posts/id1')
   })
 
-  // TODO - THIS WORKS IN REACT
-  test.skip('when navigating from /posts/$postId to "/"', async () => {
+  test('when navigating from /posts/$postId to "/"', async () => {
     const rootRoute = createRootRoute({
       component: () => {
         return (
@@ -1745,8 +1744,9 @@ describe('Link', () => {
 
     fireEvent.click(homeLink)
 
-    expect(window.location.pathname).toBe('/')
     const homeHeading = await screen.findByTestId('home-heading')
+
+    expect(window.location.pathname).toBe('/')
     expect(homeHeading).toBeInTheDocument()
 
     expect(consoleWarnSpy).not.toHaveBeenCalled()
@@ -6346,8 +6346,7 @@ describe('when on /posts/$postId and navigating to ../ with default `from` /post
 })
 
 describe('rewrite', () => {
-  // TODO - THIS WORKS IN REACT
-  test.skip('renders hard link when rewrite points to different origin', async () => {
+  test('renders hard link when rewrite points to different origin', async () => {
     const rootRoute = createRootRoute()
     const indexRoute = createRoute({
       getParentRoute: () => rootRoute,