From 6369f9b909d81e854a295943ebd3abd20c1e867d Mon Sep 17 00:00:00 2001 From: Rhys Goodall Date: Wed, 13 Aug 2025 18:23:48 -0400 Subject: [PATCH 1/3] fix: pin plotly. remove misleading ty from PR template until we achieve zero errors --- .github/PULL_REQUEST_TEMPLATE.md | 1 - examples/scripts/6_Phonons/6.1_Phonons_MACE.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b71a59105..0194cc5e0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,6 @@ Before a pull request can be merged, the following items must be checked: * [ ] Doc strings have been added in the [Google docstring format](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html#example-google). * [ ] Run [ruff](https://beta.ruff.rs/docs/rules/#pydocstyle-d) on your code. -* [ ] Run `uvx ty check` on the repo. * [ ] Tests have been added for any new functionality or bug fixes. We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run `pip install pre-commit && pre-commit install` to install the hooks which will check your code before each commit. diff --git a/examples/scripts/6_Phonons/6.1_Phonons_MACE.py b/examples/scripts/6_Phonons/6.1_Phonons_MACE.py index 38a50d60a..49e4640c8 100644 --- a/examples/scripts/6_Phonons/6.1_Phonons_MACE.py +++ b/examples/scripts/6_Phonons/6.1_Phonons_MACE.py @@ -4,10 +4,10 @@ # dependencies = [ # "mace-torch>=0.3.12", # "phonopy>=2.35", -# "pymatviz==0.16", +# "pymatviz==0.16.0", +# "plotly==6.1.2", # TODO remove pin pending https://github.com/plotly/plotly.py/issues/5253#issuecomment-3016615635 # "seekpath", # "ase", -# "plotly!=6.2.0", # TODO remove pin pending https://github.com/plotly/plotly.py/issues/5253#issuecomment-3016615635 # ] # /// From 0fbf95366ca31d52b6841e2440421d0392f35cf3 Mon Sep 17 00:00:00 2001 From: Rhys Goodall Date: Wed, 13 Aug 2025 18:28:22 -0400 Subject: [PATCH 2/3] bump pins --- examples/scripts/6_Phonons/6.1_Phonons_MACE.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/scripts/6_Phonons/6.1_Phonons_MACE.py b/examples/scripts/6_Phonons/6.1_Phonons_MACE.py index 49e4640c8..3968acdab 100644 --- a/examples/scripts/6_Phonons/6.1_Phonons_MACE.py +++ b/examples/scripts/6_Phonons/6.1_Phonons_MACE.py @@ -4,8 +4,8 @@ # dependencies = [ # "mace-torch>=0.3.12", # "phonopy>=2.35", -# "pymatviz==0.16.0", -# "plotly==6.1.2", # TODO remove pin pending https://github.com/plotly/plotly.py/issues/5253#issuecomment-3016615635 +# "pymatviz>=0.17.1", +# "plotly>=6.3.0", # "seekpath", # "ase", # ] From 7459871d514c698a658b5c57440f8543e0cc0b17 Mon Sep 17 00:00:00 2001 From: Rhys Goodall Date: Wed, 13 Aug 2025 21:10:29 -0400 Subject: [PATCH 3/3] fix tree map deps --- docs/_static/draw_pkg_treemap.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/_static/draw_pkg_treemap.py b/docs/_static/draw_pkg_treemap.py index 3a9833874..44e762e74 100644 --- a/docs/_static/draw_pkg_treemap.py +++ b/docs/_static/draw_pkg_treemap.py @@ -5,8 +5,8 @@ # /// script # dependencies = [ -# "pymatviz==0.16.0", -# "plotly!=6.2.0", # TODO remove pin pending https://github.com/plotly/plotly.py/issues/5253#issuecomment-3016615635 +# "pymatviz>=0.17.1", +# "plotly>=6.3.0", # ] # ///