From 6d5fb63067a972221844dd6a8a077aa7be622f0b Mon Sep 17 00:00:00 2001 From: Dmytro Lutsyk Date: Fri, 3 Jun 2022 12:19:20 +0200 Subject: [PATCH 1/4] add modify_a_beta_app_review_detail methode --- appstoreconnect/api.py | 8 ++++++++ appstoreconnect/resources.py | 1 + 2 files changed, 9 insertions(+) diff --git a/appstoreconnect/api.py b/appstoreconnect/api.py index d0416c5..521de2e 100644 --- a/appstoreconnect/api.py +++ b/appstoreconnect/api.py @@ -692,6 +692,14 @@ def read_beta_app_review_submission_information(self, beta_app_id: str): """ return self._get_resource(BetaAppReviewSubmission, beta_app_id) + def modify_a_beta_app_review_detail(self, beta_app_review_detail: BetaAppReviewDetail, demoAccountName: str, demoAccountPassword: str, demoAccountRequired: bool, contactFirstName: str, contactLastName: str, contactEmail: str, contactPhone: str, notes: str = None) -> AppStoreReviewDetail: + """ + :reference: https://developer.apple.com/documentation/appstoreconnectapi/modify_a_beta_app_review_detail + :return: an BetaAppReviewDetail resource + """ + attributes = {'demoAccountName':demoAccountName, 'demoAccountPassword':demoAccountPassword, 'demoAccountRequired':demoAccountRequired, 'contactFirstName':contactFirstName, 'contactLastName':contactLastName, 'contactEmail': contactEmail, 'contactPhone':contactPhone, 'notes': notes} + return self._modify_resource(BetaAppReviewDetail, attributes) + def create_an_app_store_version_submission(self, appStoreVersion: AppStoreVersion): """ :reference: https://developer.apple.com/documentation/appstoreconnectapi/create_an_app_store_version_submission diff --git a/appstoreconnect/resources.py b/appstoreconnect/resources.py index c4d1643..d2f1469 100644 --- a/appstoreconnect/resources.py +++ b/appstoreconnect/resources.py @@ -280,6 +280,7 @@ class BetaBuildLocalization(Resource): class BetaAppReviewDetail(Resource): endpoint = '/v1/betaAppReviewDetails' type = 'betaAppReviewDetails' + attributes = ['contactEmail', 'contactFirstName', 'contactLastName', 'contactPhone', 'demoAccountName', 'demoAccountPassword', 'demoAccountRequired', 'notes'] documentation = 'https://developer.apple.com/documentation/appstoreconnectapi/betaAppReviewDetail/attributes' From 46e3fb40569d56a32774af4a935d4dacc390fb8e Mon Sep 17 00:00:00 2001 From: Dmytro Lutsyk Date: Wed, 15 Jun 2022 13:31:34 +0200 Subject: [PATCH 2/4] betaAppReviewDetail ok need to do beta app localization --- appstoreconnect/api.py | 2 +- appstoreconnect/resources.py | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/appstoreconnect/api.py b/appstoreconnect/api.py index 521de2e..1490aa9 100644 --- a/appstoreconnect/api.py +++ b/appstoreconnect/api.py @@ -698,7 +698,7 @@ def modify_a_beta_app_review_detail(self, beta_app_review_detail: BetaAppReviewD :return: an BetaAppReviewDetail resource """ attributes = {'demoAccountName':demoAccountName, 'demoAccountPassword':demoAccountPassword, 'demoAccountRequired':demoAccountRequired, 'contactFirstName':contactFirstName, 'contactLastName':contactLastName, 'contactEmail': contactEmail, 'contactPhone':contactPhone, 'notes': notes} - return self._modify_resource(BetaAppReviewDetail, attributes) + return self._modify_resource(beta_app_review_detail, attributes) def create_an_app_store_version_submission(self, appStoreVersion: AppStoreVersion): """ diff --git a/appstoreconnect/resources.py b/appstoreconnect/resources.py index d2f1469..b440fe9 100644 --- a/appstoreconnect/resources.py +++ b/appstoreconnect/resources.py @@ -258,11 +258,28 @@ class Build(Resource): endpoint = '/v1/builds' type = 'builds' attributes = ['expired', 'iconAssetToken', 'minOsVersion', 'processingState', 'version', 'usesNonExemptEncryption', 'uploadedDate', 'expirationDate'] + relationships = { + 'app': {'multiple': False}, + 'appEncryptionDeclaration': {'multiple': False}, + 'individualTesters': {'multiple': True}, + 'preReleaseVersion': {'multiple': False}, + 'betaBuildLocalizations': {'multiple': True}, + 'buildBetaDetail': {'multiple': False}, + 'betaAppReviewSubmission': {'multiple': False}, + 'appStoreVersion': {'multiple': False}, + 'icons': {'multiple': True}, + 'buildBundles': {'multiple': True}, + 'betaGroups': {'multiple': True}, + } documentation = 'https://developer.apple.com/documentation/appstoreconnectapi/build/attributes' class BuildBetaDetail(Resource): endpoint = '/v1/buildBetaDetails' + attributes = ['autoNotifyEnabled', 'externalBuildState', 'internalBuildState'] + relationships = { + 'build': {'multiple': False}, + } type = 'buildBetaDetails' documentation = 'https://developer.apple.com/documentation/appstoreconnectapi/buildBetaDetail/attributes' @@ -281,6 +298,9 @@ class BetaAppReviewDetail(Resource): endpoint = '/v1/betaAppReviewDetails' type = 'betaAppReviewDetails' attributes = ['contactEmail', 'contactFirstName', 'contactLastName', 'contactPhone', 'demoAccountName', 'demoAccountPassword', 'demoAccountRequired', 'notes'] + relationships = { + 'app': {'multiple': False}, + } documentation = 'https://developer.apple.com/documentation/appstoreconnectapi/betaAppReviewDetail/attributes' From d5401b765405db8bf3eaae735a10e3cc0010c9a1 Mon Sep 17 00:00:00 2001 From: Dmytro Lutsyk Date: Wed, 15 Jun 2022 17:45:46 +0200 Subject: [PATCH 3/4] beta app info localization blocked --- appstoreconnect/api.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/appstoreconnect/api.py b/appstoreconnect/api.py index 1490aa9..52274d8 100644 --- a/appstoreconnect/api.py +++ b/appstoreconnect/api.py @@ -496,6 +496,13 @@ def create_beta_app_localization(self, app: App, locale: str, description: str = """ return self._create_resource(BetaAppLocalization, locals()) + def modify_a_beta_app_localization(self, betaAppLocalization: BetaAppLocalization, locale: str, description: str = None, feedbackEmail: str = None, marketingUrl: str = None, privacyPolicyUrl: str = None, tvOsPrivacyPolicy: str = None): + """ + :reference: https://developer.apple.com/documentation/appstoreconnectapi/modify_a_beta_app_localization + :return: an BetaAppLocalization resource + """ + return self._create_resource(betaAppLocalization, locals()) + def list_app_encryption_declarations(self, filters=None): """ :reference: https://developer.apple.com/documentation/appstoreconnectapi/list_app_encryption_declarations From b7fa52063cddfdc20e208d27c2d187d5a8e74089 Mon Sep 17 00:00:00 2001 From: Dmytro Lutsyk Date: Thu, 16 Jun 2022 11:20:31 +0200 Subject: [PATCH 4/4] ready to merge --- appstoreconnect/api.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appstoreconnect/api.py b/appstoreconnect/api.py index 52274d8..a23f256 100644 --- a/appstoreconnect/api.py +++ b/appstoreconnect/api.py @@ -496,12 +496,12 @@ def create_beta_app_localization(self, app: App, locale: str, description: str = """ return self._create_resource(BetaAppLocalization, locals()) - def modify_a_beta_app_localization(self, betaAppLocalization: BetaAppLocalization, locale: str, description: str = None, feedbackEmail: str = None, marketingUrl: str = None, privacyPolicyUrl: str = None, tvOsPrivacyPolicy: str = None): + def modify_a_beta_app_localization(self, betaAppLocalization: BetaAppLocalization, description: str = None, feedbackEmail: str = None, marketingUrl: str = None, privacyPolicyUrl: str = None, tvOsPrivacyPolicy: str = None): """ :reference: https://developer.apple.com/documentation/appstoreconnectapi/modify_a_beta_app_localization :return: an BetaAppLocalization resource """ - return self._create_resource(betaAppLocalization, locals()) + return self._modify_resource(betaAppLocalization, locals()) def list_app_encryption_declarations(self, filters=None): """