From bac27312fa7718de391134b5213bfc6d8fec71a7 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Tue, 27 Jan 2026 06:41:12 +1000 Subject: [PATCH 1/2] CI: make baseline comparison non-blocking --- .github/workflows/build-ultraplot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 94747f315..625067650 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -87,6 +87,7 @@ jobs: compare-baseline: name: Compare baseline Python ${{ inputs.python-version }} with MPL ${{ inputs.matplotlib-version }} runs-on: ubuntu-latest + continue-on-error: true env: IS_PR: ${{ github.event_name == 'pull_request' }} TEST_MODE: ${{ inputs.test-mode }} From 38eaa301cc5d2d682e2b2261346de039ff325a40 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Tue, 27 Jan 2026 07:00:57 +1000 Subject: [PATCH 2/2] CI: drop redundant pytest run --- .github/workflows/build-ultraplot.yml | 32 --------------------------- 1 file changed, 32 deletions(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 625067650..64ced1f3f 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -52,38 +52,6 @@ jobs: run: | pip install --no-build-isolation --no-deps . - - name: Test Ultraplot - run: | - status=0 - filter_nodeids() { - local filtered="" - for nodeid in ${TEST_NODEIDS}; do - local path="${nodeid%%::*}" - if [ -f "$path" ]; then - filtered="${filtered} ${nodeid}" - fi - done - echo "${filtered}" - } - if [ "${TEST_MODE}" = "selected" ] && [ -n "${TEST_NODEIDS}" ]; then - FILTERED_NODEIDS="$(filter_nodeids)" - if [ -z "${FILTERED_NODEIDS}" ]; then - echo "No valid nodeids found; running full suite." - pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$? - else - pytest -q --tb=short --disable-warnings -n 0 ${FILTERED_NODEIDS} || status=$? - if [ "$status" -eq 4 ] || [ "$status" -eq 5 ]; then - echo "No tests collected from selected nodeids; running full suite." - status=0 - pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$? - fi - fi - else - pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$? - fi - echo "Final test status: ${status}" - exit "$status" - compare-baseline: name: Compare baseline Python ${{ inputs.python-version }} with MPL ${{ inputs.matplotlib-version }} runs-on: ubuntu-latest