From a52f2be163af4ac5c89b5ec595d1599baa016f38 Mon Sep 17 00:00:00 2001 From: Matteo Vivona Date: Fri, 26 Jan 2024 16:23:26 +0100 Subject: [PATCH 1/5] Add support to Node20 --- .nvmrc | 2 +- action.yml | 2 +- package.json | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.nvmrc b/.nvmrc index 3f430af..9a2a0e2 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v18 +v20 diff --git a/action.yml b/action.yml index 05a7068..3c787c1 100644 --- a/action.yml +++ b/action.yml @@ -16,5 +16,5 @@ inputs: required: false default: 'false' runs: - using: 'node16' + using: 'node20' main: 'github-action-runtime/index.js' diff --git a/package.json b/package.json index ea185e5..37016a8 100644 --- a/package.json +++ b/package.json @@ -29,6 +29,9 @@ "github actions", "actions" ], + "engines": { + "node": ">=20.0.0" + }, "author": "UnlyEd", "license": "MIT", "dependencies": { From fe00f54c5410c4d684b797ef2f13c3d0ba07ee8b Mon Sep 17 00:00:00 2001 From: Matteo Vivona Date: Fri, 26 Jan 2024 16:27:02 +0100 Subject: [PATCH 2/5] Remove Node16 support on pipeline --- .github/workflows/check-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index be91a08..6a84631 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -13,7 +13,7 @@ jobs: run-build-test: strategy: matrix: - version: [ 16, 18, 20 ] + version: [ 18, 20 ] runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 From 83e78d263a74890b1b1e9d60aae7db4eb1eabda4 Mon Sep 17 00:00:00 2001 From: Matteo Vivona Date: Fri, 26 Jan 2024 16:29:32 +0100 Subject: [PATCH 3/5] Install Node20 on build workflow --- .github/workflows/check-build.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index 6a84631..6bca69e 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -17,6 +17,9 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + - uses: actions/setup-node@v4 + with: + node-version: '20' - run: | yarn yarn build:once From c9e23d72e23672d5fcdbbe25387d116c6059da55 Mon Sep 17 00:00:00 2001 From: Matteo Vivona Date: Fri, 26 Jan 2024 16:31:35 +0100 Subject: [PATCH 4/5] Install Node20 on test workflows --- .github/workflows/run-integration-test.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/run-integration-test.yml b/.github/workflows/run-integration-test.yml index 37cd0e4..ca21430 100644 --- a/.github/workflows/run-integration-test.yml +++ b/.github/workflows/run-integration-test.yml @@ -14,6 +14,9 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + - uses: actions/setup-node@v4 + with: + node-version: '20' - run: yarn # Install all dependencies - uses: ./ id: store-variables @@ -29,6 +32,9 @@ jobs: needs: run-integration-test1 steps: - uses: actions/checkout@v3 + - uses: actions/setup-node@v4 + with: + node-version: '20' - run: yarn # Install all dependencies - uses: ./ with: @@ -46,6 +52,9 @@ jobs: needs: run-integration-test2 steps: - uses: actions/checkout@v3 + - uses: actions/setup-node@v4 + with: + node-version: '20' - run: yarn # Install all dependencies - uses: ./ with: @@ -63,6 +72,9 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + - uses: actions/setup-node@v4 + with: + node-version: '20' - run: yarn # Install all dependencies - uses: ./ with: From d6f8b756b6ac6d9f10c192d6fd5d87396971a777 Mon Sep 17 00:00:00 2001 From: Matteo Vivona Date: Tue, 6 Feb 2024 18:18:03 +0100 Subject: [PATCH 5/5] Remove engine option from package.json --- package.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/package.json b/package.json index 37016a8..ea185e5 100644 --- a/package.json +++ b/package.json @@ -29,9 +29,6 @@ "github actions", "actions" ], - "engines": { - "node": ">=20.0.0" - }, "author": "UnlyEd", "license": "MIT", "dependencies": {