From bf6df15cda1ca6b7131433f34daf36271ad020b7 Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Tue, 14 Dec 2021 13:16:08 +1300
Subject: [PATCH 01/13] delete unused components

---
 .../components/shared/app.shared.module.ts    |  5 ----
 .../confirm-dialog.component.html             |  9 -------
 .../confirm-dialog.component.scss             |  0
 .../confirm-dialog.component.ts               | 22 ----------------
 .../error-dialog/error-dialog.component.html  |  3 ---
 .../error-dialog/error-dialog.component.scss  |  0
 .../error-dialog/error-dialog.component.ts    | 26 -------------------
 7 files changed, 65 deletions(-)
 delete mode 100644 research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.html
 delete mode 100644 research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.scss
 delete mode 100644 research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.ts
 delete mode 100644 research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.html
 delete mode 100644 research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.scss
 delete mode 100644 research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.ts

diff --git a/research-hub-web/src/app/components/shared/app.shared.module.ts b/research-hub-web/src/app/components/shared/app.shared.module.ts
index f41ea7947..efdd679d8 100644
--- a/research-hub-web/src/app/components/shared/app.shared.module.ts
+++ b/research-hub-web/src/app/components/shared/app.shared.module.ts
@@ -3,8 +3,6 @@ import { CommonModule } from '@angular/common';
 import { FlexLayoutModule } from '@angular/flex-layout';
 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 import { MaterialModule } from '@app/app.material.module';
-import { ErrorDialogComponent } from './error-dialog/error-dialog.component';
-import { ConfirmDialogComponent } from './confirm-dialog/confirm-dialog.component';
 import { HumanCasePipe } from '@pipes/human-case.pipe';
 import { ContentTypeDisplayNamePipe } from '@pipes/content-type-display-name.pipe';
 import { CollectionListComponent } from './collection-list/collection-list.component';
@@ -39,8 +37,6 @@ import { ExpandablePagePartComponent } from './body-media/expandable-page-part/e
     MarkdownModule.forRoot()
   ],
   declarations: [
-    ErrorDialogComponent,
-    ConfirmDialogComponent,
     HumanCasePipe,
     ContentTypeDisplayNamePipe,
     CollectionListComponent,
@@ -60,7 +56,6 @@ import { ExpandablePagePartComponent } from './body-media/expandable-page-part/e
     FormsModule,
     ReactiveFormsModule,
     MaterialModule,
-    ErrorDialogComponent,
     HumanCasePipe,
     ContentTypeDisplayNamePipe,
     CollectionListComponent,
diff --git a/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.html b/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.html
deleted file mode 100644
index a19d25edf..000000000
--- a/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.html
+++ /dev/null
@@ -1,9 +0,0 @@
-<h3 mat-dialog-title>{{title}}</h3>
-<mat-dialog-content>
-  <p>{{message}}</p>
-</mat-dialog-content>
-<mat-dialog-actions fxLayout="row" fxLayoutAlign="end center">
-  <button mat-button [mat-dialog-close]="false" color="primary" style="font-weight: 600;">CANCEL</button>
-  <button mat-button role="button" aria-label="confirm-dialog" [mat-dialog-close]="true" 
-    color="primary" style="font-weight: 600;">OK</button>
-</mat-dialog-actions>
diff --git a/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.scss b/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.scss
deleted file mode 100644
index e69de29bb..000000000
diff --git a/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.ts b/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.ts
deleted file mode 100644
index c4305785c..000000000
--- a/research-hub-web/src/app/components/shared/confirm-dialog/confirm-dialog.component.ts
+++ /dev/null
@@ -1,22 +0,0 @@
-import {Component, Inject} from '@angular/core';
-import {MAT_DIALOG_DATA, MatDialogRef} from '@angular/material/dialog';
-
-@Component({
-  selector: 'app-confirm-dialog',
-  templateUrl: './confirm-dialog.component.html',
-  styleUrls: ['./confirm-dialog.component.scss']
-})
-export class ConfirmDialogComponent {
-
-  public title: string;
-  public message: string;
-
-  constructor(public dialogRef: MatDialogRef<ConfirmDialogComponent>, @Inject(MAT_DIALOG_DATA) public data: any) {
-    this.title = data.title;
-    this.message = data.message;
-  }
-
-  onNoClick(): void {
-    this.dialogRef.close();
-  }
-}
diff --git a/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.html b/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.html
deleted file mode 100644
index 56c198109..000000000
--- a/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.html
+++ /dev/null
@@ -1,3 +0,0 @@
-<h2 mat-dialog-title>{{title}}</h2>
-<mat-dialog-content>{{message}}</mat-dialog-content>
-<mat-dialog-actions><button role="button" aria-label="close" mat-button mat-dialog-close>{{closeButtonName}}</button></mat-dialog-actions>
diff --git a/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.scss b/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.scss
deleted file mode 100644
index e69de29bb..000000000
diff --git a/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.ts b/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.ts
deleted file mode 100644
index 5466d3911..000000000
--- a/research-hub-web/src/app/components/shared/error-dialog/error-dialog.component.ts
+++ /dev/null
@@ -1,26 +0,0 @@
-import {Component, Inject, OnInit} from '@angular/core';
-import {MAT_DIALOG_DATA, MatDialogRef} from '@angular/material/dialog';
-
-@Component({
-  selector: 'app-error-dialog',
-  templateUrl: './error-dialog.component.html',
-  styleUrls: ['./error-dialog.component.scss']
-})
-export class ErrorDialogComponent implements OnInit {
-
-  public title: string;
-  public message: string;
-  public closeButtonName: string;
-  private timeout: number;
-
-  constructor(public dialogRef: MatDialogRef<ErrorDialogComponent>, @Inject(MAT_DIALOG_DATA) public data: any) {
-    this.title = data.title;
-    this.message = data.message;
-    this.closeButtonName = data.closeButtonName;
-    this.timeout = data.timeout;
-  }
-
-  ngOnInit() {
-    if (this.timeout) { setTimeout(() => { this.dialogRef.close() }, this.timeout)}
-  }
-}

From 04c254211d537b7ff081f5096d23eb6c7704ab8b Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Tue, 14 Dec 2021 17:08:30 +1300
Subject: [PATCH 02/13] show external links icons

---
 .../blocks-embedded-entry.component.html      |  2 +-
 research-hub-web/src/styles.scss              | 35 +++++++++++++------
 2 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html b/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html
index 44670add0..fbe4b2272 100644
--- a/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html
+++ b/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html
@@ -24,7 +24,7 @@
 
         <!-- Link Card -->
         <span *ngSwitchCase="'LinkCard'">
-            <div>
+            <div class="link-card">
                 <a href="{{ contentItem.document ? contentItem.document.url : contentItem.url }}" target="_blank">
                     <mat-card class="embedded-entry-block">
                         <mat-card-title>
diff --git a/research-hub-web/src/styles.scss b/research-hub-web/src/styles.scss
index 91129c25b..ad9477020 100644
--- a/research-hub-web/src/styles.scss
+++ b/research-hub-web/src/styles.scss
@@ -134,20 +134,33 @@ a {
   color: $link-light-bg-color;
   font-family: $font-family;
 }
-
-// show icon for external links
-// page below is good for checking
-// http://localhost:4200/research-impact/planning-for-impact
-// a:not([href^="/"]):after {
-//   font-family: "Material Icons";
-//   content: " \e895";
-//   font-size: 0.8em;
-// }
-
 span {
   font-family: $font-family;
 }
 
+/**
+* External Links Icon
+* Show the icon for any anchor tags in the main-content area where:
+* - href does not start with '/' (our domain)
+* - href does not contain @ (emails)
+* - do not apply to those with .standard-button class
+* - do not apply to descendents of element app-blocks-embedded-asset
+* - do not apply to link cards or funding application docs
+* - show the mail icon for email links within rich text
+*/
+#main-content a:not([href^="/"], [href*="@"]):not(.standard-button):not(app-blocks-embedded-asset *):not(.link-card *):not(.application-doc *):after {
+  font-family: "Material Icons";
+  content: " \e895";
+  font-size: 0.8em;
+  color: $dark-grey;
+}
+ngx-contentful-rich-text a[href^="mailto"]:after {
+  font-family: "Material Icons";
+  content: " \e0e1";
+  font-size: 0.8em;
+  color: $dark-grey;
+}
+
 /*
  * app-markdown related styles
  */
@@ -168,7 +181,7 @@ span {
 }
 
 /*
- * Gloabl styles and Material overrides
+ * Global styles and Material overrides
  */
 mat-chip.mat-chip {
   font-size: mat-font-size($app-chips-typography, button);

From 0ef015d66a3f58407e50d5c8516c15b0fb564738 Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Tue, 14 Dec 2021 17:09:46 +1300
Subject: [PATCH 03/13] tweaks to card titles for consistency

---
 .../src/app/components/cards/cards-common.scss       |  2 +-
 .../cards/contact-card/contact-card.component.html   |  6 ++----
 .../cards/document-card/document-card.component.html |  4 ++--
 .../cards/standard-card/standard-card.component.html | 12 +++++++-----
 .../cards/standard-card/standard-card.component.scss |  3 ++-
 5 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/research-hub-web/src/app/components/cards/cards-common.scss b/research-hub-web/src/app/components/cards/cards-common.scss
index 0d7b8b57b..b61a868ed 100644
--- a/research-hub-web/src/app/components/cards/cards-common.scss
+++ b/research-hub-web/src/app/components/cards/cards-common.scss
@@ -19,7 +19,7 @@
  */
 .mat-card-title {
   line-height: 20px;
-  a {
+  span {
     color: $dark-grey;
     &:hover {
       border-bottom: solid 2px $dark-grey;
diff --git a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
index eac0e3335..f4aa916ea 100644
--- a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
+++ b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
@@ -1,12 +1,10 @@
-<mat-card (click)="person.link ? navigateTo(person.link) : null">
+<mat-card (click)="person.link ? navigateTo(person.link) : person.email">
   <span class="card-label">Contact</span>
 
   <div style="margin-top: 12px"></div>
 
   <mat-card-title>
-    <a class="card-title">
-      <span *ngIf="person.name">{{ person.name }}</span>
-    </a>
+    <span class="card-title" *ngIf="person.name">{{ person.name }}</span>
   </mat-card-title>
 
   <mat-card-content>
diff --git a/research-hub-web/src/app/components/cards/document-card/document-card.component.html b/research-hub-web/src/app/components/cards/document-card/document-card.component.html
index e145f4d92..257153cbe 100644
--- a/research-hub-web/src/app/components/cards/document-card/document-card.component.html
+++ b/research-hub-web/src/app/components/cards/document-card/document-card.component.html
@@ -6,12 +6,12 @@
   <div style="margin-top: 12px"></div>
 
   <mat-card-title>
-    <a
+    <a 
       class="card-title"
       [attr.href]="document.url ?? document.document?.url"
       target="_blank"
     >
-      {{ document.title }}
+      <span>{{ document.title }}</span>
     </a>
   </mat-card-title>
   <mat-card-content>
diff --git a/research-hub-web/src/app/components/cards/standard-card/standard-card.component.html b/research-hub-web/src/app/components/cards/standard-card/standard-card.component.html
index 3cbe5862a..e76ea1c00 100644
--- a/research-hub-web/src/app/components/cards/standard-card/standard-card.component.html
+++ b/research-hub-web/src/app/components/cards/standard-card/standard-card.component.html
@@ -25,13 +25,15 @@
         contentItem.slug
       ]"
     >
-      {{ contentItem.title }}
+      <span>{{ contentItem.title }}
+        &nbsp;
+        <mat-icon *ngIf="contentItem.ssoProtected" matTooltip="SSO Login Required">
+          lock
+        </mat-icon>
+      </span>
     </a>
-    &nbsp;
-    <mat-icon *ngIf="contentItem.ssoProtected" matTooltip="SSO Login Required">
-      lock
-    </mat-icon>
   </mat-card-title>
+
   <mat-card-content
     ><span class="card-summary">
       <p>{{ contentItem.summary }}</p>
diff --git a/research-hub-web/src/app/components/cards/standard-card/standard-card.component.scss b/research-hub-web/src/app/components/cards/standard-card/standard-card.component.scss
index 2cebf4b66..b399b15e2 100644
--- a/research-hub-web/src/app/components/cards/standard-card/standard-card.component.scss
+++ b/research-hub-web/src/app/components/cards/standard-card/standard-card.component.scss
@@ -7,7 +7,7 @@
     background: rgb(255, 255, 255);
   }
   .mat-card-title {
-    >a {
+    span {
       color: white;
       &:hover {
         border-bottom: solid 2px white;
@@ -28,6 +28,7 @@ mat-icon {
   font-size: 16px;
   height: 16px;
   width: 16px;
+  color: $dark-grey;
 }
 
 img {

From deb514921e3f213e97c0ab5850272ac9eff74b51 Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Wed, 15 Dec 2021 10:27:39 +1300
Subject: [PATCH 04/13] navigateTo changed to window.open, fix typo

---
 .../components/cards/contact-card/contact-card.component.html   | 2 +-
 .../app/components/cards/contact-card/contact-card.component.ts | 2 +-
 .../components/cards/document-card/document-card.component.ts   | 2 +-
 .../components/cards/org-unit-card/org-unit-card.component.ts   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
index f4aa916ea..9a8ed2c78 100644
--- a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
+++ b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
@@ -1,4 +1,4 @@
-<mat-card (click)="person.link ? navigateTo(person.link) : person.email">
+<mat-card (click)="person.link ? navigateTo(person.link) : null">
   <span class="card-label">Contact</span>
 
   <div style="margin-top: 12px"></div>
diff --git a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.ts b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.ts
index e115709a8..1df2ca6d1 100644
--- a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.ts
+++ b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.ts
@@ -15,7 +15,7 @@ export class ContactCardComponent {
   constructor() { }
 
   public navigateTo(url: string) {
-    location.href = url;
+    window.open(url, "_blank");
   }
 
 }
diff --git a/research-hub-web/src/app/components/cards/document-card/document-card.component.ts b/research-hub-web/src/app/components/cards/document-card/document-card.component.ts
index c689543c0..ccc797bbd 100644
--- a/research-hub-web/src/app/components/cards/document-card/document-card.component.ts
+++ b/research-hub-web/src/app/components/cards/document-card/document-card.component.ts
@@ -15,6 +15,6 @@ export class DocumentCardComponent {
   constructor() { }
 
   public navigateTo(url: Maybe<string> | undefined) {
-    if (url) location.href = url;
+    if (url) window.open(url, "_blank");
   }
 }
diff --git a/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.ts b/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.ts
index 856be0409..7b9b63ba0 100644
--- a/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.ts
+++ b/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.ts
@@ -15,7 +15,7 @@ export class OrgUnitCardComponent {
   constructor() { }
 
   public navigateTo(url: string) {
-    location.href = url;
+    window.open(url, "_blank");
   }
 
 }

From f2176af21052ad3cf0d50b74c5b053c16c0f8cbd Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Wed, 15 Dec 2021 10:28:05 +1300
Subject: [PATCH 05/13] minor fixes

---
 .../src/app/components/articles/article/article.component.html  | 1 +
 research-hub-web/src/styles.scss                                | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/research-hub-web/src/app/components/articles/article/article.component.html b/research-hub-web/src/app/components/articles/article/article.component.html
index 387260bda..62e4b7878 100644
--- a/research-hub-web/src/app/components/articles/article/article.component.html
+++ b/research-hub-web/src/app/components/articles/article/article.component.html
@@ -46,6 +46,7 @@
         <div *ngIf="article.banner">
           <a
             href="{{ article.callToAction }}"
+            target="_blank"
             mat-flat-button
             class="standard-button-banner"
           >
diff --git a/research-hub-web/src/styles.scss b/research-hub-web/src/styles.scss
index ad9477020..8332ec80b 100644
--- a/research-hub-web/src/styles.scss
+++ b/research-hub-web/src/styles.scss
@@ -148,7 +148,7 @@ span {
 * - do not apply to link cards or funding application docs
 * - show the mail icon for email links within rich text
 */
-#main-content a:not([href^="/"], [href*="@"]):not(.standard-button):not(app-blocks-embedded-asset *):not(.link-card *):not(.application-doc *):after {
+#main-content a:not([href^="/"]):not([href*="//research-hub"]):not([href*="@"]):not(.standard-button):not(app-blocks-embedded-asset *):not(.link-card *):not(.application-doc *):after {
   font-family: "Material Icons";
   content: " \e895";
   font-size: 0.8em;

From bf3231370ef50ff1e6e09ed00ce6ac8f1e4b33bd Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Wed, 15 Dec 2021 15:28:07 +1300
Subject: [PATCH 06/13] close search autocomplete panel on enter keypress

---
 .../app/components/layout/search-bar/search-bar.component.html | 3 ++-
 .../app/components/layout/search-bar/search-bar.component.ts   | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/research-hub-web/src/app/components/layout/search-bar/search-bar.component.html b/research-hub-web/src/app/components/layout/search-bar/search-bar.component.html
index 70b3f612c..cc3aa978e 100644
--- a/research-hub-web/src/app/components/layout/search-bar/search-bar.component.html
+++ b/research-hub-web/src/app/components/layout/search-bar/search-bar.component.html
@@ -35,7 +35,8 @@
         id="search"
         #searchBox
         type="search"
-        (keydown.enter)="search()"
+        #trigger="matAutocompleteTrigger"
+        (keydown.enter)="search(); trigger.closePanel()"
         placeholder="Search for anything"
         [matAutocomplete]="auto"
         [formControl]="searchText"
diff --git a/research-hub-web/src/app/components/layout/search-bar/search-bar.component.ts b/research-hub-web/src/app/components/layout/search-bar/search-bar.component.ts
index 98d678e3c..313356804 100644
--- a/research-hub-web/src/app/components/layout/search-bar/search-bar.component.ts
+++ b/research-hub-web/src/app/components/layout/search-bar/search-bar.component.ts
@@ -16,7 +16,7 @@ import { filter, map, startWith } from 'rxjs/operators';
 export class SearchBarComponent implements OnInit, OnDestroy {
   @ViewChild('searchBarContainer') searchBarContainer: ElementRef;
   @ViewChild('searchBox') searchBox: ElementRef;
-  @ViewChild('filterContent') filterContent: ElementRef
+  @ViewChild('filterContent') filterContent: ElementRef;
 
   public searchText: FormControl = new FormControl();
   public activeFilters: SearchFilters;

From 310bbd1514453a8915984dd9bdc53ff8ed8a060b Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Mon, 20 Dec 2021 10:29:33 +1300
Subject: [PATCH 07/13] readme

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index de04acf53..2c37a0b3e 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@ A [Serverless Framework](https://www.serverless.com/) ([AWS Lambda](https://aws.
 ### 4. [terraform/](terraform/)
 Terraform infrastructure as code to create the Research Hub AWS infrastructure.
 
-### 4. [subhub-link-checker/](subhub-link-checker/)
+### 5. [subhub-link-checker/](subhub-link-checker/)
 A [Contentful App Framework app](https://www.contentful.com/developers/docs/extensibility/app-framework/) that checks to prevent cyclical content references in SubHubs.
 ## Deployment
 CI/CD is achieved via the monorepo's [Jenkinsfile](Jenkinsfile) which is triggered when code is pushed to one of 4 Git branches (`sandbox`, `dev`, `test`, `prod`) corresponding to environments across the three [UoA AWS accounts](http://aws.auckland.ac.nz/) (`sandbox`, `nonprod`, `prod`). 

From eb62ccf40a2af558b32bf7fcbabdfda8f26def80 Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Mon, 20 Dec 2021 11:17:50 +1300
Subject: [PATCH 08/13] external links icon not on phone numbers

---
 research-hub-web/src/styles.scss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/research-hub-web/src/styles.scss b/research-hub-web/src/styles.scss
index 6d5679cc1..19dd1a36e 100644
--- a/research-hub-web/src/styles.scss
+++ b/research-hub-web/src/styles.scss
@@ -148,7 +148,7 @@ span {
 * - do not apply to link cards or funding application docs
 * - show the mail icon for email links within rich text
 */
-#main-content a:not([href^="/"]):not([href*="//research-hub"]):not([href*="@"]):not(.standard-button):not(app-blocks-embedded-asset *):not(.link-card *):not(.application-doc *):after {
+#main-content a:not([href^="/"]):not([href*="//research-hub"]):not([href*="@"]):not([href^="tel"]):not(.standard-button):not(app-blocks-embedded-asset *):not(.link-card *):not(.application-doc *):after {
   font-family: "Material Icons";
   content: " \e895";
   font-size: 0.8em;

From 2c4c5dd7945c6690a773fe582a4f31bc7c49905f Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Mon, 20 Dec 2021 12:17:57 +1300
Subject: [PATCH 09/13] fix link card external icon

---
 .../blocks-embedded-entry.component.html      | 20 +------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html b/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html
index 4f0cbcbbe..39d6d6008 100644
--- a/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html
+++ b/research-hub-web/src/app/components/shared/body-media/blocks-embedded-entry/blocks-embedded-entry.component.html
@@ -22,7 +22,7 @@
   <span [ngSwitch]="contentItem.__typename">
     <!-- Link Card -->
     <span *ngSwitchCase="'LinkCard'">
-      <div>
+      <div class="link-card">
         <a
           href="{{
             contentItem.document ? contentItem.document.url : contentItem.url
@@ -53,24 +53,6 @@
       <app-video-card [contentItem]="contentItem"></app-video-card>
     </span>
 
-    <!-- Link Card -->
-    <span *ngSwitchCase="'LinkCard'">
-      <div class="link-card">
-        <a href="{{ contentItem.document ? contentItem.document.url : contentItem.url }}" target="_blank">
-          <mat-card class="embedded-entry-block">
-            <mat-card-title>
-              <span>
-                  {{ contentItem.title }}&nbsp;
-              </span>
-              <mat-icon *ngIf="contentItem.ssoProtected" matTooltip="SSO Login Required">lock</mat-icon>
-            </mat-card-title>
-            <mat-card-content><span class="card-summary"><p>{{ contentItem.summary }}</p></span>
-            </mat-card-content>
-          </mat-card>
-        </a>
-      </div>
-    </span>
-
     <!-- Table -->
     <span *ngSwitchCase="'Table'">
       <div class="table-container section">

From 427e5e74e7f5af95e2176bb3e9e70eb1a7deb315 Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Mon, 20 Dec 2021 12:51:13 +1300
Subject: [PATCH 10/13] cards external links functionality and accessibility

---
 .../cards/contact-card/contact-card.component.html          | 5 ++++-
 .../cards/document-card/document-card.component.html        | 6 +-----
 .../cards/org-unit-card/org-unit-card.component.html        | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
index 9a8ed2c78..35d4a5336 100644
--- a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
+++ b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
@@ -4,7 +4,10 @@
   <div style="margin-top: 12px"></div>
 
   <mat-card-title>
-    <span class="card-title" *ngIf="person.name">{{ person.name }}</span>
+    <a *ngIf="person.link" class="card-title" tabindex="0" (keydown.enter)="navigateTo(person.link)">
+      <span *ngIf="person.name">{{ person.name }}</span>
+    </a>
+    <span *ngIf="!person.link && person.name" class="card-title">{{ person.name }}</span>
   </mat-card-title>
 
   <mat-card-content>
diff --git a/research-hub-web/src/app/components/cards/document-card/document-card.component.html b/research-hub-web/src/app/components/cards/document-card/document-card.component.html
index 257153cbe..76d1d3a95 100644
--- a/research-hub-web/src/app/components/cards/document-card/document-card.component.html
+++ b/research-hub-web/src/app/components/cards/document-card/document-card.component.html
@@ -6,11 +6,7 @@
   <div style="margin-top: 12px"></div>
 
   <mat-card-title>
-    <a 
-      class="card-title"
-      [attr.href]="document.url ?? document.document?.url"
-      target="_blank"
-    >
+    <a class="card-title" tabindex="0" (keydown.enter)="navigateTo(document.url)">
       <span>{{ document.title }}</span>
     </a>
   </mat-card-title>
diff --git a/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.html b/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.html
index ed8b21e55..2e8b72cc2 100644
--- a/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.html
+++ b/research-hub-web/src/app/components/cards/org-unit-card/org-unit-card.component.html
@@ -4,7 +4,7 @@
   <div style="margin-top: 12px"></div>
 
   <mat-card-title>
-    <a class="card-title" [attr.href]="orgUnit.link ? orgUnit.link : null">
+    <a class="card-title" tabindex="0" (keydown.enter)="orgUnit.link ? navigateTo(orgUnit.link) : null">
       <span *ngIf="orgUnit.name">{{ orgUnit.name }}</span>
       <span *ngIf="orgUnit.maoriName && orgUnit.name">, </span>
       <span *ngIf="orgUnit.maoriName">{{ orgUnit.maoriName }}</span>

From 9085f05aa195da0db0b73dc1078d654a8d477f33 Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Mon, 20 Dec 2021 13:02:45 +1300
Subject: [PATCH 11/13] fix tabbing on contact card

---
 .../components/cards/contact-card/contact-card.component.html   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
index 35d4a5336..54191f042 100644
--- a/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
+++ b/research-hub-web/src/app/components/cards/contact-card/contact-card.component.html
@@ -7,7 +7,7 @@
     <a *ngIf="person.link" class="card-title" tabindex="0" (keydown.enter)="navigateTo(person.link)">
       <span *ngIf="person.name">{{ person.name }}</span>
     </a>
-    <span *ngIf="!person.link && person.name" class="card-title">{{ person.name }}</span>
+    <span *ngIf="!person.link && person.name" class="card-title" tabindex="0">{{ person.name }}</span>
   </mat-card-title>
 
   <mat-card-content>

From 02302fa335a3bc099e25805218771e229074ce4a Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Mon, 20 Dec 2021 15:14:24 +1300
Subject: [PATCH 12/13] open assets in new tab

---
 .../blocks-embedded-asset.component.html                    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/research-hub-web/src/app/components/shared/body-media/blocks-embedded-asset/blocks-embedded-asset.component.html b/research-hub-web/src/app/components/shared/body-media/blocks-embedded-asset/blocks-embedded-asset.component.html
index b1ca6b1bc..d5bd86049 100644
--- a/research-hub-web/src/app/components/shared/body-media/blocks-embedded-asset/blocks-embedded-asset.component.html
+++ b/research-hub-web/src/app/components/shared/body-media/blocks-embedded-asset/blocks-embedded-asset.component.html
@@ -2,7 +2,7 @@
     <span [ngSwitch]="contentItem.contentType">
     <ng-template #image>
         <div class="embedded-asset-block section-2" ngClass.xs="embedded-asset-block-mobile">
-            <a *ngIf="contentItem.url" href="{{ contentItem.url }}">
+            <a *ngIf="contentItem.url" href="{{ contentItem.url }}" target="_blank">
                 <picture>
                     <source srcset="{{ contentItem.url }}?w=1500&fm=webp" type="image/webp">
                     <img src="{{ contentItem.url }}?w=1500" alt="{{ contentItem.title }}" />
@@ -15,7 +15,7 @@
 
     <ng-template #svg>
         <div class="embedded-asset-block section-2" ngClass.xs="embedded-asset-block-mobile">
-            <a *ngIf="contentItem.url" href="{{ contentItem.url }}">
+            <a *ngIf="contentItem.url" href="{{ contentItem.url }}" target="_blank">
                 <img src="{{ contentItem.url }}?w=1500" alt="{{ contentItem.title }}" />
             </a><br>{{ contentItem.title }}
             <small class="asset-summary" *ngIf="contentItem.description">&nbsp;—&nbsp;{{ contentItem.description
@@ -43,7 +43,7 @@
     <!-- Asset File -->
     <span *ngSwitchDefault>
         <div class="embedded-asset-block file" ngClass.xs="embedded-asset-block-mobile">
-            <a *ngIf="contentItem.url" href="{{ contentItem.url }}">
+            <a *ngIf="contentItem.url" href="{{ contentItem.url }}" target="_blank">
                 <mat-card>
                     <mat-card-title class="card-title">
                         <span>{{ contentItem.title }}</span>

From 2fc03b8398faceadc31eec9e372a740f81abbfa3 Mon Sep 17 00:00:00 2001
From: rosemcc <rosemccoll@hotmail.com>
Date: Wed, 22 Dec 2021 12:25:47 +1300
Subject: [PATCH 13/13] dont show external link icon on home page banner
 content

---
 research-hub-web/src/styles.scss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/research-hub-web/src/styles.scss b/research-hub-web/src/styles.scss
index 19dd1a36e..09d99429b 100644
--- a/research-hub-web/src/styles.scss
+++ b/research-hub-web/src/styles.scss
@@ -148,7 +148,7 @@ span {
 * - do not apply to link cards or funding application docs
 * - show the mail icon for email links within rich text
 */
-#main-content a:not([href^="/"]):not([href*="//research-hub"]):not([href*="@"]):not([href^="tel"]):not(.standard-button):not(app-blocks-embedded-asset *):not(.link-card *):not(.application-doc *):after {
+#main-content a:not([href^="/"]):not([href*="//research-hub"]):not([href*="@"]):not([href^="tel"]):not(.standard-button):not(app-blocks-embedded-asset *):not(.link-card *):not(.application-doc *):not(.banner-container-home *):after {
   font-family: "Material Icons";
   content: " \e895";
   font-size: 0.8em;