From 2db4370599b26248ebda123b0145ab85a1bd6af7 Mon Sep 17 00:00:00 2001 From: Magomed Chemurziev Date: Wed, 30 Oct 2024 12:24:28 +0300 Subject: [PATCH 1/2] fix: empty string in arrayBuffer (#447) * fix: empty string in arrayBuffer * chore: linter --- CHANGELOG.md | 6 ++++++ src/core/request/response/CHANGELOG.md | 6 ++++++ src/core/request/response/index.ts | 2 +- src/core/request/response/test/main.spec.ts | 19 +++++++++++++++++++ 4 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 src/core/request/response/test/main.spec.ts diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d413770c..8e2d2368b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,12 @@ Changelog _Note: Gaps between patch versions are faulty, broken or test releases._ +## v3.101.?? (2024-??-??) + +#### :bug: Bug Fix + +* Fixed an issue when receiving an empty string with the `Content-Type: application/octet-stream` header `core/request/response` + ## v3.101.1 (2024-10-21) #### :bug: Bug Fix diff --git a/src/core/request/response/CHANGELOG.md b/src/core/request/response/CHANGELOG.md index 87b9998c5..c4362f505 100644 --- a/src/core/request/response/CHANGELOG.md +++ b/src/core/request/response/CHANGELOG.md @@ -9,6 +9,12 @@ Changelog > - :house: [Internal] > - :nail_care: [Polish] +## v3.101.?? (2024-??-??) + +#### :bug: Bug Fix + +* Fixed an issue when receiving an empty string with the `Content-Type: application/octet-stream` header `core/request/response` + ## v3.93.0 (2023-03-14) #### :rocket: New Feature diff --git a/src/core/request/response/index.ts b/src/core/request/response/index.ts index 7d723d43b..688ac31b5 100644 --- a/src/core/request/response/index.ts +++ b/src/core/request/response/index.ts @@ -664,7 +664,7 @@ export default class Response< @once arrayBuffer(): AbortablePromise { return this.readBody().then((body) => { - if (body == null) { + if (body == null || body === '') { return new ArrayBuffer(0); } diff --git a/src/core/request/response/test/main.spec.ts b/src/core/request/response/test/main.spec.ts new file mode 100644 index 000000000..230d95378 --- /dev/null +++ b/src/core/request/response/test/main.spec.ts @@ -0,0 +1,19 @@ +import { Response } from 'core/request'; +import V4Headers from 'core/request/headers'; + +describe('core/request/response', () => { + test([ + 'should successfully handle a request with the Content-Type: application/octet-stream header', + 'and an empty response body' + ].join(' '), async () => { + + const response = new Response(Promise.resolve(''), { + url: 'url/url', + headers: new V4Headers({ + 'Content-Type': 'application/octet-stream' + }) + }); + + await expect(response.decode()).resolves.toBeInstanceOf(ArrayBuffer); + }); +}); From 5f77e0018692197f2546b7e8902d81a922dce615 Mon Sep 17 00:00:00 2001 From: Alexei Shcherbina Date: Mon, 9 Dec 2024 13:05:49 +0300 Subject: [PATCH 2/2] :up: version --- CHANGELOG.md | 2 +- package.json | 2 +- src/core/request/response/CHANGELOG.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e2d2368b..f5f5450f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ Changelog _Note: Gaps between patch versions are faulty, broken or test releases._ -## v3.101.?? (2024-??-??) +## v3.101.2 (2024-12-09) #### :bug: Bug Fix diff --git a/package.json b/package.json index e05660f97..749bbd6af 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "main": "lib/core/index.js", "typings": "index.d.ts", "license": "MIT", - "version": "3.101.1", + "version": "3.101.2", "author": "kobezzza (https://github.com/kobezzza)", "repository": { "type": "git", diff --git a/src/core/request/response/CHANGELOG.md b/src/core/request/response/CHANGELOG.md index c4362f505..f9a0323d6 100644 --- a/src/core/request/response/CHANGELOG.md +++ b/src/core/request/response/CHANGELOG.md @@ -9,7 +9,7 @@ Changelog > - :house: [Internal] > - :nail_care: [Polish] -## v3.101.?? (2024-??-??) +## v3.101.2 (2024-12-09) #### :bug: Bug Fix