From f9a04c69e43ee54cf0fad4db13f7a2ea8f49529e Mon Sep 17 00:00:00 2001
From: roggy666 <59109355+roggy666@users.noreply.github.com>
Date: Thu, 9 Apr 2026 02:33:34 +0400
Subject: [PATCH] Add missing minecraft:dyeable item tag for 1.21.5 -> 1.21.4
 downgrade

In 1.21.5, the minecraft:dyeable item tag was removed as dyeable property
moved into the equippable component system. However, the 1.21.4 client's
EquipmentRenderer checks stack.isIn(ItemTags.DYEABLE) before applying dye
color to the 3D armor model. Without this tag, colored leather armor appears
as default brown on the player model (inventory icon works fine).

This adds the dyeable tag with all leather armor item IDs resolved from
mapping data in onMappingDataLoaded().
---
 .../Protocol1_21_5To1_21_4.java               | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_5to1_21_4/Protocol1_21_5To1_21_4.java b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_5to1_21_4/Protocol1_21_5To1_21_4.java
index ed31409f..9995fe2c 100644
--- a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_5to1_21_4/Protocol1_21_5To1_21_4.java
+++ b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_5to1_21_4/Protocol1_21_5To1_21_4.java
@@ -55,6 +55,8 @@
 import com.viaversion.viaversion.protocols.v1_21_4to1_21_5.rewriter.RecipeDisplayRewriter1_21_5;
 import com.viaversion.viaversion.protocols.v1_21to1_21_2.packet.ClientboundPacket1_21_2;
 import com.viaversion.viaversion.protocols.v1_21to1_21_2.packet.ClientboundPackets1_21_2;
+import com.viaversion.viaversion.api.data.FullMappings;
+import com.viaversion.viaversion.api.minecraft.RegistryType;
 import com.viaversion.viaversion.rewriter.BlockRewriter;
 import com.viaversion.viaversion.rewriter.ParticleRewriter;
 import com.viaversion.viaversion.rewriter.RecipeDisplayRewriter;
@@ -175,6 +177,31 @@ public void handleArgument(final PacketWrapper wrapper, final String argumentTyp
         cancelClientbound(ClientboundPackets1_21_5.TEST_INSTANCE_BLOCK_STATUS);
     }
 
+    @Override
+    protected void onMappingDataLoaded() {
+        super.onMappingDataLoaded();
+
+        // The minecraft:dyeable item tag was removed in 1.21.5, but the 1.21.4 client's
+        // EquipmentRenderer checks stack.isIn(ItemTags.DYEABLE) before applying dye color
+        // to the 3D armor model. Without this tag, colored leather armor appears as default brown.
+        final FullMappings itemMappings = getMappingData().getFullItemMappings();
+        if (itemMappings != null) {
+            final String[] dyeableItems = {
+                "minecraft:leather_helmet",
+                "minecraft:leather_chestplate",
+                "minecraft:leather_leggings",
+                "minecraft:leather_boots",
+                "minecraft:leather_horse_armor",
+                "minecraft:wolf_armor"
+            };
+            final int[] mappedIds = new int[dyeableItems.length];
+            for (int i = 0; i < dyeableItems.length; i++) {
+                mappedIds[i] = itemMappings.mappedId(dyeableItems[i]);
+            }
+            tagRewriter.addTagRaw(RegistryType.ITEM, "minecraft:dyeable", mappedIds);
+        }
+    }
+
     @Override
     public void init(final UserConnection user) {
         addEntityTracker(user, new EntityTrackerBase(user, EntityTypes1_21_4.PLAYER));