From a04e665c3ca99c4110d56911393d4a982110a2ab Mon Sep 17 00:00:00 2001 From: SarahAlidoost Date: Fri, 3 Apr 2026 09:51:13 +0200 Subject: [PATCH 1/3] replace coverage run with pytest-cov in sinar action --- .github/workflows/sonarcloud.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 0c8dad3..8d91b93 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -28,10 +28,8 @@ jobs: python -m pip install -e .[dev] - name: Run unit tests and store coverage run: | - # [!] Note that sonarcloud runs the full test suite - coverage run -m pytest -n auto - coverage report -m - coverage xml -o coverage.xml + # [!] Note that sonarcloud runs the fast test suite + pytest --fast -n auto --cov=your_package --cov-report=xml:coverage.xml --cov-report=term-missing - name: Make coverage paths relative run: sed -i "s+$PWD/++g" coverage.xml - name: SonarQube Scan From e07b02d426ee2d763898d123f531fa73d11c55c2 Mon Sep 17 00:00:00 2001 From: SarahAlidoost Date: Fri, 3 Apr 2026 09:52:05 +0200 Subject: [PATCH 2/3] remove exclusions from sonar --- sonar-project.properties | 1 - 1 file changed, 1 deletion(-) diff --git a/sonar-project.properties b/sonar-project.properties index 9cde9ba..d3886e1 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -8,4 +8,3 @@ sonar.links.scm=git@github.com:WUR-AI/diffwofost sonar.links.issue=https://github.com/WUR-AI/diffwofost/issues sonar.links.ci=https://github.com/WUR-AI/diffwofost/actions sonar.python.coverage.reportPaths=coverage.xml -sonar.coverage.exclusions=src/diffwofost/physical_models/crop/evapotranspiration.py,src/diffwofost/physical_models/utils.py From 2268d2be3fe17041ea9053c001dbf46fdbfc7686 Mon Sep 17 00:00:00 2001 From: SarahAlidoost Date: Fri, 3 Apr 2026 09:57:14 +0200 Subject: [PATCH 3/3] fix the path in sonar action --- .github/workflows/sonarcloud.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 8d91b93..53f8160 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -29,7 +29,7 @@ jobs: - name: Run unit tests and store coverage run: | # [!] Note that sonarcloud runs the fast test suite - pytest --fast -n auto --cov=your_package --cov-report=xml:coverage.xml --cov-report=term-missing + pytest --fast -n auto --cov=src --cov-report=xml:coverage.xml --cov-report=term-missing - name: Make coverage paths relative run: sed -i "s+$PWD/++g" coverage.xml - name: SonarQube Scan