Fix unit tests#345
Closed
datagutten wants to merge 7 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=========================================
Coverage 92.11% 92.11%
Complexity 760 760
=========================================
Files 21 21
Lines 1762 1762
=========================================
Hits 1623 1623
Misses 139 139Continue to review full report at Codecov.
|
Composer is locked to PHP 5.6, so it will install incompatible versions
jrfnl
reviewed
Sep 15, 2019
Member
jrfnl
left a comment
There was a problem hiding this comment.
Wouldn't it make more sense to let Composer sort out the PHPUnit version on every build ?
That would make the Travis script much simpler and more stable.
Collaborator
|
Thanks so much for this pull request and apologies for the delay. I've rolled these tests into #351 to also update the domain name; will aim to merge that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests currently use an empty string or the default value for checking exception message which means empty message. The message is not empty and causes the tests to fail. I changed this to null so the message is not checked and those tests pass.