From 7f0b0d7b23c2d7768c8a7eaa360ec00a63ff0655 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sun, 21 Jul 2019 08:10:56 +0200 Subject: [PATCH] PHP 7.4 compatibility fix / implode argument order `implode()` takes two parameters, `$glue` and `$pieces`. For historical reasons, `implode()` accepted these parameters in either order, though it was recommended to use the documented argument order of `implode( $glue, $pieces )`. PHP 7.4 is slated to deprecate the tolerance for passing the parameters for `implode()` in reverse order. PHP 8.0 is expected to remove the tolerance for this completely. Refs: * https://wiki.php.net/rfc/deprecations_php_7_4#implode_parameter_order_mix * https://php.net/manual/en/function.implode.php --- library/Requests/Transport/fsockopen.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/Requests/Transport/fsockopen.php b/library/Requests/Transport/fsockopen.php index 21cb56d5e..7f95a4f0c 100644 --- a/library/Requests/Transport/fsockopen.php +++ b/library/Requests/Transport/fsockopen.php @@ -192,7 +192,7 @@ public function request($url, $headers = array(), $data = array(), $options = ar $headers = Requests::flatten($headers); if (!empty($headers)) { - $out .= implode($headers, "\r\n") . "\r\n"; + $out .= implode("\r\n", $headers) . "\r\n"; } $options['hooks']->dispatch('fsockopen.after_headers', array(&$out));