Create get checks to run AJAX endpoint#97
Merged
felixarntz merged 8 commits intoMar 15, 2023
Conversation
felixarntz
reviewed
Mar 14, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger This looks great so far. A few suggestions for decoupling the functions/methods more.
joemcgill
approved these changes
Mar 14, 2023
Member
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
I've got a couple comments, but this is generally looking good. I'm not sure I totally get my head around why this process needs to happen in separate AJAX calls, rather than all at once when the plugin is being checked, but I don't see that as a blocker to continuing to push forward with this approach. Nice work.
felixarntz
deleted the
feature/create-plugin_check_get_checks_to_run-endpoint
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses acceptance criteria for #90
Closes #90