From f9ff891bfeb98946b158ac810ddfda5cd6044c08 Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Wed, 6 May 2026 11:31:31 +0530 Subject: [PATCH 1/3] Update the error message for changeit action --- src/js/_enqueues/admin/common.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index 2a7daba0d2dc4..c1454498621bc 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1350,9 +1350,15 @@ $( function() { event.stopPropagation(); $( 'html, body' ).animate( { scrollTop: 0 } ); + var noSelectionMessages = { + 'changeit': __( 'Please select a role to change.' ), + 'bulk_action': __( 'Please select a bulk action to perform.' ) + }; + var errorMessage = value !== '-1' ? __( 'Please select at least one item to perform this action on.' ) : - __( 'Please select a bulk action to perform.' ); + noSelectionMessages[ submitterName ] || noSelectionMessages['bulk_action']; + addAdminNotice( { id: value !== '-1' ? 'no-items-selected' : 'no-bulk-action-selected', type: 'error', From 110fae1d33eee01832a7c2d23bf5c7a3b0594b12 Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Wed, 6 May 2026 11:34:30 +0530 Subject: [PATCH 2/3] Update object in alphabetical order --- src/js/_enqueues/admin/common.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index c1454498621bc..675da741f7129 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1351,8 +1351,8 @@ $( function() { $( 'html, body' ).animate( { scrollTop: 0 } ); var noSelectionMessages = { - 'changeit': __( 'Please select a role to change.' ), - 'bulk_action': __( 'Please select a bulk action to perform.' ) + 'bulk_action': __( 'Please select a bulk action to perform.' ), + 'changeit': __( 'Please select a role to change.' ) }; var errorMessage = value !== '-1' ? From 522f53c5c36f715fa3ce967315428f673e912cdf Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Wed, 6 May 2026 12:02:20 +0530 Subject: [PATCH 3/3] Fix phpcs issue --- src/js/_enqueues/admin/common.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index 675da741f7129..e9da0d547c8f8 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1357,7 +1357,7 @@ $( function() { var errorMessage = value !== '-1' ? __( 'Please select at least one item to perform this action on.' ) : - noSelectionMessages[ submitterName ] || noSelectionMessages['bulk_action']; + noSelectionMessages[ submitterName ] || noSelectionMessages.bulk_action; addAdminNotice( { id: value !== '-1' ? 'no-items-selected' : 'no-bulk-action-selected',