Skip to content

Enhance DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES by local search #79

@Xiaoven

Description

@Xiaoven

目前 DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVESSA_SELF_COMPARISON 都会识别 contains 方法。可以通过搜索 object 的用法来辅助判断它是否是 collection,如果是,则报 DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES.

Example

下面的例子会同时报 DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVESSA_SELF_COMPARISON

void tmp(Collection c){
        if (c.contains(c)){
            System.out.println("collection yes");
        } else{
            System.out.println("no");
        }
    }

希望能改一下 local search 机制,在 engine 初始化 detector 的时候,检查 detector 是否需要 local search,如需要,则把 patch_set 信息传给它,让它在自己的 class 内加工保存自己需要用的信息, 而不是像现在local search 方法和相关变量都定义和保存在 engine 内

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions