From 2fbcdaedad4a09272bd7fa58bbb67e60f2d892fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C2=A0TheSmartnik?= Date: Mon, 8 Nov 2021 18:52:49 +0300 Subject: [PATCH] RSC7a * Update protocol version * Update RSC7c spec * Update expected value for v param per #G4 --- lib/ably/version.rb | 2 +- spec/acceptance/realtime/connection_spec.rb | 2 +- spec/acceptance/rest/client_spec.rb | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ably/version.rb b/lib/ably/version.rb index a88a5338f..1b7e6c414 100644 --- a/lib/ably/version.rb +++ b/lib/ably/version.rb @@ -1,6 +1,6 @@ module Ably VERSION = '1.1.8' - PROTOCOL_VERSION = '1.1' + PROTOCOL_VERSION = '1.2' # @api private def self.major_minor_version_numeric diff --git a/spec/acceptance/realtime/connection_spec.rb b/spec/acceptance/realtime/connection_spec.rb index 49ba10a12..5c281c068 100644 --- a/spec/acceptance/realtime/connection_spec.rb +++ b/spec/acceptance/realtime/connection_spec.rb @@ -2083,7 +2083,7 @@ def self.available_states it 'sends the protocol version param v (#G4, #RTN2f)' do expect(EventMachine).to receive(:connect) do |host, port, transport, object, url| uri = URI.parse(url) - expect(CGI::parse(uri.query)['v'][0]).to eql('1.1') + expect(CGI::parse(uri.query)['v'][0]).to eql('1.2') stop_reactor end client diff --git a/spec/acceptance/rest/client_spec.rb b/spec/acceptance/rest/client_spec.rb index d474e4238..bc163e38a 100644 --- a/spec/acceptance/rest/client_spec.rb +++ b/spec/acceptance/rest/client_spec.rb @@ -1097,7 +1097,7 @@ def encode64(text) it 'sends a protocol version and lib version header (#G4, #RSC7a, #RSC7b)' do client.channels.get('foo').publish("event") expect(publish_message_stub).to have_been_requested - expect(Ably::PROTOCOL_VERSION).to eql('1.1') + expect(Ably::PROTOCOL_VERSION).to eql('1.2') end end end @@ -1231,7 +1231,7 @@ def encode64(text) end end - context 'request_id generation' do + context 'request_id generation (#RSC7c)' do context 'Timeout error' do context 'with option add_request_ids: true and no fallback hosts', :webmock, :prevent_log_stubbing do let(:custom_logger_object) { TestLogger.new }