From a3e49ec8dd42711b03fc0cfe7985459cc825eda8 Mon Sep 17 00:00:00 2001 From: Patrick Ellis Date: Mon, 13 May 2024 14:25:08 -0400 Subject: [PATCH 1/3] =?UTF-8?q?Upgrade=20node20:=2020.8.1=20=E2=86=92=2020?= =?UTF-8?q?.13.1?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/Misc/externals.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Misc/externals.sh b/src/Misc/externals.sh index 383221e4452..f4fb5beba1d 100755 --- a/src/Misc/externals.sh +++ b/src/Misc/externals.sh @@ -6,7 +6,7 @@ NODE_URL=https://nodejs.org/dist UNOFFICIAL_NODE_URL=https://unofficial-builds.nodejs.org/download/release NODE_ALPINE_URL=https://github.com/actions/alpine_nodejs/releases/download NODE16_VERSION="16.20.2" -NODE20_VERSION="20.8.1" +NODE20_VERSION="20.13.1" # used only for win-arm64, remove node16 unofficial version when official version is available NODE16_UNOFFICIAL_VERSION="16.20.0" From dcaf602c57f46f9ebd045f927d76379378b3030c Mon Sep 17 00:00:00 2001 From: Patrick Ellis Date: Mon, 13 May 2024 14:42:04 -0400 Subject: [PATCH 2/3] Call out the release process for `alpine_nodejs` in a comment --- src/Misc/externals.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Misc/externals.sh b/src/Misc/externals.sh index f4fb5beba1d..341ff451122 100755 --- a/src/Misc/externals.sh +++ b/src/Misc/externals.sh @@ -5,6 +5,8 @@ PRECACHE=$2 NODE_URL=https://nodejs.org/dist UNOFFICIAL_NODE_URL=https://unofficial-builds.nodejs.org/download/release NODE_ALPINE_URL=https://github.com/actions/alpine_nodejs/releases/download +# When you update Node versions you must also create a new release of alpine_nodejs at that updated version. +# Follow the instructions here: https://github.com/actions/alpine_nodejs?tab=readme-ov-file#getting-started NODE16_VERSION="16.20.2" NODE20_VERSION="20.13.1" # used only for win-arm64, remove node16 unofficial version when official version is available From 25032602a34c4dcef76491e1fdf6d8e916fee6f4 Mon Sep 17 00:00:00 2001 From: Patrick Ellis Date: Mon, 13 May 2024 17:45:46 -0400 Subject: [PATCH 3/3] move the comment to the end of the line so it's more obvious which variable it's talking about --- src/Misc/externals.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Misc/externals.sh b/src/Misc/externals.sh index 341ff451122..e057ecb218f 100755 --- a/src/Misc/externals.sh +++ b/src/Misc/externals.sh @@ -9,8 +9,7 @@ NODE_ALPINE_URL=https://github.com/actions/alpine_nodejs/releases/download # Follow the instructions here: https://github.com/actions/alpine_nodejs?tab=readme-ov-file#getting-started NODE16_VERSION="16.20.2" NODE20_VERSION="20.13.1" -# used only for win-arm64, remove node16 unofficial version when official version is available -NODE16_UNOFFICIAL_VERSION="16.20.0" +NODE16_UNOFFICIAL_VERSION="16.20.0" # used only for win-arm64, remove node16 unofficial version when official version is available get_abs_path() { # exploits the fact that pwd will print abs path when no args