From d50c5fb92b65c9bc44c2f800e8e051b36f391c06 Mon Sep 17 00:00:00 2001 From: Salman Chishti Date: Fri, 25 Jul 2025 15:22:37 +0000 Subject: [PATCH 1/2] if statement fix --- src/Misc/layoutbin/update.sh.template | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Misc/layoutbin/update.sh.template b/src/Misc/layoutbin/update.sh.template index 476ae11e57d..85ca58f45e1 100755 --- a/src/Misc/layoutbin/update.sh.template +++ b/src/Misc/layoutbin/update.sh.template @@ -146,10 +146,11 @@ if [[ "$currentplatform" == 'darwin' && restartinteractiverunner -eq 0 ]]; then then nodever="node16" path=$(lsof -a -g "$procgroup" -F n | grep $nodever/bin/node | grep externals | tail -1 | cut -c2-) - if [[ $? -ne 0 || -z "$path" ]] # Fallback if RunnerService.js was started with node12 - then - nodever="node12" - path=$(lsof -a -g "$procgroup" -F n | grep $nodever/bin/node | grep externals | tail -1 | cut -c2-) + if [[ $? -ne 0 || -z "$path" ]] # Fallback if RunnerService.js was started with node12 + then + nodever="node12" + path=$(lsof -a -g "$procgroup" -F n | grep $nodever/bin/node | grep externals | tail -1 | cut -c2-) + fi fi fi if [[ $? -eq 0 && -n "$path" ]] From cb2c3077eeca59f1df8affc6480ba7271c04a828 Mon Sep 17 00:00:00 2001 From: Salman Chishti Date: Fri, 25 Jul 2025 15:28:39 +0000 Subject: [PATCH 2/2] variable update --- src/Misc/layoutbin/update.sh.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Misc/layoutbin/update.sh.template b/src/Misc/layoutbin/update.sh.template index 85ca58f45e1..82ada18b917 100755 --- a/src/Misc/layoutbin/update.sh.template +++ b/src/Misc/layoutbin/update.sh.template @@ -123,7 +123,7 @@ fi # fix upgrade issue with macOS when running as a service attemptedtargetedfix=0 currentplatform=$(uname | awk '{print tolower($0)}') -if [[ "$currentplatform" == 'darwin' && restartinteractiverunner -eq 0 ]]; then +if [[ "$currentplatform" == 'darwin' && $restartinteractiverunner -eq 0 ]]; then # We needed a fix for https://github.com/actions/runner/issues/743 # We will recreate the ./externals/nodeXY/bin/node of the past runner version that launched the runnerlistener service # Otherwise mac gatekeeper kills the processes we spawn on creation as we are running a process with no backing file