From 884cfe7772687b0c99180b7fd5a37c6db4566c73 Mon Sep 17 00:00:00 2001 From: Josh Gross Date: Fri, 4 Oct 2024 16:37:08 -0400 Subject: [PATCH 1/2] Extend Node version test coverage --- .github/workflows/unit-tests.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 952fa6b273..8b241adfb7 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -17,6 +17,11 @@ jobs: strategy: matrix: runs-on: [ubuntu-latest, macos-latest, windows-latest] + + # Node 16 actions are in the process of being deprecated + # Node 18 is the current default Node version in hosted runners, so users may still use the toolkit with it + # Node 20 is the currently support Node version for actions - https://docs.github.com/actions/sharing-automations/creating-actions/metadata-syntax-for-github-actions#runsusing-for-javascript-actions + node-version: [16.x, 18.x, 20.x] fail-fast: false runs-on: ${{ matrix.runs-on }} @@ -25,10 +30,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Set Node.js 20.x + - name: Set up Node ${{ matrix.node-version }} uses: actions/setup-node@v4 with: - node-version: 20.x + node-version: ${{ matrix.node-version }} - name: npm install run: npm install From 6435e050d3efd6a7d8b53c1c61e5b670625323a0 Mon Sep 17 00:00:00 2001 From: Josh Gross Date: Mon, 7 Oct 2024 11:04:47 -0400 Subject: [PATCH 2/2] Remove Node 16 --- .github/workflows/unit-tests.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 8b241adfb7..d02de10817 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -18,10 +18,9 @@ jobs: matrix: runs-on: [ubuntu-latest, macos-latest, windows-latest] - # Node 16 actions are in the process of being deprecated - # Node 18 is the current default Node version in hosted runners, so users may still use the toolkit with it + # Node 18 is the current default Node version in hosted runners, so users may still use the toolkit with it when running tests (see https://github.com/actions/toolkit/issues/1841) # Node 20 is the currently support Node version for actions - https://docs.github.com/actions/sharing-automations/creating-actions/metadata-syntax-for-github-actions#runsusing-for-javascript-actions - node-version: [16.x, 18.x, 20.x] + node-version: [18.x, 20.x] fail-fast: false runs-on: ${{ matrix.runs-on }}