From 77c2b5383417459a5096a571ccceed5b2b8e5279 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Mon, 5 Jan 2026 14:08:06 +0100 Subject: [PATCH 1/2] build: expose libplatform symbols in shared libnode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This requires setting BUILDING_V8_PLATFORM_SHARED to expose the public symbols since we build with hidden visibility by default. PR-URL: https://github.com/nodejs/node/pull/61144 Fixes: https://github.com/nodejs/node/issues/61102 Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: Richard Lau --- node.gypi | 2 ++ tools/v8_gypfiles/v8.gyp | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/node.gypi b/node.gypi index 8ba67f53192159..4f35b103449fc3 100644 --- a/node.gypi +++ b/node.gypi @@ -50,9 +50,11 @@ 'defines': [ 'USING_UV_SHARED', 'USING_V8_SHARED', + 'USING_V8_PLATFORM_SHARED', 'BUILDING_NODE_EXTENSION' ], 'defines!': [ + 'BUILDING_V8_PLATFORM_SHARED=1', 'BUILDING_V8_SHARED=1', 'BUILDING_UV_SHARED=1' ] diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp index f22e914e1fc4a6..f323d8fba68f96 100644 --- a/tools/v8_gypfiles/v8.gyp +++ b/tools/v8_gypfiles/v8.gyp @@ -58,6 +58,7 @@ ['OS!="aix" and OS!="os400"', { 'defines': [ 'BUILDING_V8_SHARED', # Make V8_EXPORT visible. + 'BUILDING_V8_PLATFORM_SHARED', # Make V8_PLATFORM_EXPORT visible. ] }], ['node_shared=="true"', { @@ -1345,6 +1346,7 @@ ['component=="shared_library"', { 'defines': [ 'BUILDING_V8_SHARED', + 'BUILDING_V8_PLATFORM_SHARED', ], }], ['v8_enable_i18n_support==1', { @@ -1414,6 +1416,7 @@ 'defines!': [ '_HAS_EXCEPTIONS=0', 'BUILDING_V8_SHARED=1', + 'BUILDING_V8_PLATFORM_SHARED=1', ], 'cflags_cc!': ['-fno-exceptions'], 'cflags_cc': ['-fexceptions'], @@ -1440,6 +1443,7 @@ 'defines!': [ '_HAS_EXCEPTIONS=0', 'BUILDING_V8_SHARED=1', + 'BUILDING_V8_PLATFORM_SHARED=1', ], 'cflags_cc!': ['-fno-exceptions'], 'cflags_cc': ['-fexceptions'], @@ -1781,6 +1785,7 @@ ], 'defines!': [ 'BUILDING_V8_SHARED=1', + 'BUILDING_V8_PLATFORM_SHARED=1', ], 'dependencies': [ 'v8_libbase', @@ -1862,6 +1867,7 @@ 'defines!': [ '_HAS_EXCEPTIONS=0', 'BUILDING_V8_SHARED=1', + 'BUILDING_V8_PLATFORM_SHARED=1', ], 'cflags_cc!': ['-fno-exceptions'], 'cflags_cc': ['-fexceptions'], @@ -1905,6 +1911,7 @@ 'defines!': [ '_HAS_EXCEPTIONS=0', 'BUILDING_V8_SHARED=1', + 'BUILDING_V8_PLATFORM_SHARED=1', ], 'msvs_settings': { 'VCCLCompilerTool': { @@ -2119,10 +2126,12 @@ ], 'defines': [ 'BUILDING_V8_SHARED', + 'BUILDING_V8_PLATFORM_SHARED', ], 'direct_dependent_settings': { 'defines': [ 'USING_V8_SHARED', + 'USING_V8_PLATFORM_SHARED', ], }, 'conditions': [ From 5246229a895d40046f9d4fe3af675d02e776b9de Mon Sep 17 00:00:00 2001 From: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Date: Mon, 5 Jan 2026 14:08:16 +0100 Subject: [PATCH 2/2] doc: correct typo in api contributing doc PR-URL: https://github.com/nodejs/node/pull/61260 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Aviv Keller Reviewed-By: Rafael Gonzaga --- doc/contributing/api-documentation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/api-documentation.md b/doc/contributing/api-documentation.md index ffe1cef1386765..5847e9c216e134 100644 --- a/doc/contributing/api-documentation.md +++ b/doc/contributing/api-documentation.md @@ -54,7 +54,7 @@ meant to be a guide on how to write documentation for Node.js. it as a reference for the structure of the documentation. * The [Stability Index](https://nodejs.org/dist/latest/docs/api/documentation.html#stability-index) - is used to community the Stability of a given Node.js module. The Stability + is used to describe the Stability of a given Node.js module. The Stability levels include: * Stability 0: Deprecated. (This module is Deprecated) * Stability 1: Experimental. (This module is Experimental)