diff --git a/.gitignore b/.gitignore index b679fa67..e483083c 100644 --- a/.gitignore +++ b/.gitignore @@ -12,6 +12,7 @@ node_modules coverage/ junit.xml .vscode/ +.idea/ /package-lock.json .aio permissions.json diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8a63cb42..572aa64b 100755 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,6 +18,8 @@ All submissions should come in the form of pull requests and need to be reviewed Please follow the [pull request template](PULL_REQUEST_TEMPLATE.md) when submitting a pull request. Following the requirements for semantic releases (as described in the next section), each pull request should contain a single change and be comprised of a single commit. +**Pull requests created from forks won't be able to successfully run the E2E tests. We can’t use E2E secrets with workflows from a forked repository.** + ## Error Handling In order to ensure proper error handling, individual commands should generally *not* handle errors themselves. Commands should throw errors and allow them to be caught by the `catch` method in `BaseCommand`. There may be exceptions specifically around errors that are non-fatal. Thrown errors should be defined in either `ValidationErrors` or `ConfigurationErrors`. diff --git a/README.md b/README.md index fc253ab5..e4c160de 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,5 @@