From 9afdcf4a7636db05ba3c56b32218357c629066c6 Mon Sep 17 00:00:00 2001 From: Daniel Lu Date: Wed, 4 Jan 2023 17:21:26 -0800 Subject: [PATCH 1/4] Revert "Remove PR commenting for now so builds pass (#3826)" This reverts commit 5c1920e50d4b2b80c826ca91aff55c97350bf9f9. --- .circleci/config.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 0b4808505a4..0a4cef4ee5b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -518,6 +518,18 @@ workflows: - deploy-verdaccio: requires: - docs-verdaccio + - comment: + name: comment-pr + filters: + branches: + ignore: main + requires: + - ts-diff + - deploy + - comment: + name: comment-verdaccio + requires: + - deploy-verdaccio nightly: triggers: From fe3567fb1ef17293cc8eff1f1275544127c88e33 Mon Sep 17 00:00:00 2001 From: Daniel Lu Date: Tue, 10 Jan 2023 17:52:53 -0800 Subject: [PATCH 2/4] test commenting From f2755bfbbedfc0309e623b3701d228c88a9d1280 Mon Sep 17 00:00:00 2001 From: Daniel Lu Date: Wed, 11 Jan 2023 13:43:23 -0800 Subject: [PATCH 3/4] debugging --- .circleci/comment.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.circleci/comment.js b/.circleci/comment.js index cd84dfc46e3..0dca3ca2414 100644 --- a/.circleci/comment.js +++ b/.circleci/comment.js @@ -65,7 +65,7 @@ async function run() { } if (pr != null) { - await octokit.issues.createComment({ + let res = await octokit.issues.createComment({ owner: 'adobe', repo: 'react-spectrum', issue_number: pr, @@ -76,5 +76,6 @@ async function run() { * [View the storybook-16](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/storybook-16/index.html) * [View the documentation](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/docs/index.html)` }); + console.log('res', res); } } From 53920cb4c77edd4f391fde18e6b793228cef3433 Mon Sep 17 00:00:00 2001 From: Daniel Lu Date: Thu, 12 Jan 2023 10:30:16 -0800 Subject: [PATCH 4/4] Revert "debugging" This reverts commit f2755bfbbedfc0309e623b3701d228c88a9d1280. --- .circleci/comment.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.circleci/comment.js b/.circleci/comment.js index 0dca3ca2414..cd84dfc46e3 100644 --- a/.circleci/comment.js +++ b/.circleci/comment.js @@ -65,7 +65,7 @@ async function run() { } if (pr != null) { - let res = await octokit.issues.createComment({ + await octokit.issues.createComment({ owner: 'adobe', repo: 'react-spectrum', issue_number: pr, @@ -76,6 +76,5 @@ async function run() { * [View the storybook-16](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/storybook-16/index.html) * [View the documentation](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/docs/index.html)` }); - console.log('res', res); } }