From 7b02be3defa090b403247e0ae2ecd64df8573650 Mon Sep 17 00:00:00 2001 From: Yihui Liao Date: Fri, 10 Nov 2023 15:43:43 -0800 Subject: [PATCH 1/2] Fix selected checkbox fill color when checkbox group is disabled --- packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx b/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx index 9c736e48148..268092e651c 100644 --- a/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx +++ b/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx @@ -27,6 +27,7 @@ function CheckboxGroup(props: SpectrumCheckboxGroupProps, ref: DOMRef - + {children} From 0b7e32b3c66aa8e0d43ce45aeb32d1d63694a63b Mon Sep 17 00:00:00 2001 From: Yihui Liao Date: Mon, 13 Nov 2023 11:28:15 -0800 Subject: [PATCH 2/2] get isDisable from checkbox group state --- packages/@react-spectrum/checkbox/src/Checkbox.tsx | 6 +++--- packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/@react-spectrum/checkbox/src/Checkbox.tsx b/packages/@react-spectrum/checkbox/src/Checkbox.tsx index 517bd625eff..352f930b1c3 100644 --- a/packages/@react-spectrum/checkbox/src/Checkbox.tsx +++ b/packages/@react-spectrum/checkbox/src/Checkbox.tsx @@ -32,13 +32,11 @@ function Checkbox(props: SpectrumCheckboxProps, ref: FocusableRef(null); let domRef = useFocusableRef(ref, inputRef); @@ -47,7 +45,7 @@ function Checkbox(props: SpectrumCheckboxProps, ref: FocusableRef : ; diff --git a/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx b/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx index 268092e651c..9c736e48148 100644 --- a/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx +++ b/packages/@react-spectrum/checkbox/src/CheckboxGroup.tsx @@ -27,7 +27,6 @@ function CheckboxGroup(props: SpectrumCheckboxGroupProps, ref: DOMRef - + {children}