From f12abd51b2f8633efaed63e41a52b5aa3ec5d3f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominique=20J=C3=A4ggi?= Date: Wed, 27 Dec 2023 19:00:33 +0100 Subject: [PATCH] fix: include audit ref and audited at --- package-lock.json | 4 ++-- .../src/service/audits/accessPatterns.js | 6 +++++- packages/spacecat-shared-data-access/test/it/db.test.js | 6 +++++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index bd93b609f..02964a63b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12372,7 +12372,7 @@ }, "packages/spacecat-shared-data-access": { "name": "@adobe/spacecat-shared-data-access", - "version": "1.4.2", + "version": "1.5.0", "license": "Apache-2.0", "dependencies": { "@adobe/spacecat-shared-dynamo": "1.2.5", @@ -12901,7 +12901,7 @@ }, "packages/spacecat-shared-dynamo": { "name": "@adobe/spacecat-shared-dynamo", - "version": "1.2.6", + "version": "1.2.7", "license": "Apache-2.0", "dependencies": { "@adobe/spacecat-shared-utils": "1.1.0", diff --git a/packages/spacecat-shared-data-access/src/service/audits/accessPatterns.js b/packages/spacecat-shared-data-access/src/service/audits/accessPatterns.js index aeeb599c5..2936f7562 100644 --- a/packages/spacecat-shared-data-access/src/service/audits/accessPatterns.js +++ b/packages/spacecat-shared-data-access/src/service/audits/accessPatterns.js @@ -207,7 +207,11 @@ export const addAudit = async ( ); if (isObject(latestAudit)) { - newAudit.setPreviousAuditResult(latestAudit.getAuditResult()); + newAudit.setPreviousAuditResult({ + ...latestAudit.getAuditResult(), + auditedAt: latestAudit.getAuditedAt(), + fullAuditRef: latestAudit.getFullAuditRef(), + }); } // TODO: Add transaction support diff --git a/packages/spacecat-shared-data-access/test/it/db.test.js b/packages/spacecat-shared-data-access/test/it/db.test.js index d151900bd..9804fd4a5 100644 --- a/packages/spacecat-shared-data-access/test/it/db.test.js +++ b/packages/spacecat-shared-data-access/test/it/db.test.js @@ -378,7 +378,11 @@ describe('DynamoDB Integration Test', async () => { const anotherAudit = await dataAccess.addAudit(additionalAuditData); checkAudit(anotherAudit); - expect(anotherAudit.getPreviousAuditResult()).to.deep.equal(newAudit.getAuditResult()); + expect(anotherAudit.getPreviousAuditResult()).to.deep.equal({ + ...newAudit.getAuditResult(), + auditedAt: newAudit.getAuditedAt(), + fullAuditRef: newAudit.getFullAuditRef(), + }); }); it('throws an error when adding a duplicate audit', async () => {