From 2a51dc82b850493975024f5c99d42825faca1755 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Fri, 22 Apr 2022 17:51:10 -0700 Subject: [PATCH 01/23] feat: basic implementation of core tokens for ActionButton BREAKING CHANGE: .spectrum-ActionButton-icon is now required --- components/actionbutton/index.css | 198 ++++++++-------- .../actionbutton/metadata/actionbutton.yml | 219 +++++++++--------- 2 files changed, 204 insertions(+), 213 deletions(-) diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index 5bee87f2a3f..1feab03c1cd 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -11,120 +11,127 @@ governing permissions and limitations under the License. */ @import "../commons/basebutton.css"; -@import "../vars/css/components/spectrum-actionbutton.css"; @import "./actionbutton-generated.css"; -.spectrum-ActionButton--sizeS { - @remapvars { - find: --spectrum-actionbutton-s-; - replace: --spectrum-actionbutton-; - } +.spectrum { + --spectrum-animation-duration-100: 130ms; - /* todo: remove hardcoded values when we update DNA */ - --spectrum-actionbutton-hold-icon-padding-bottom: var(--spectrum-global-dimension-size-25); - --spectrum-actionbutton-hold-icon-padding-right: var(--spectrum-global-dimension-size-25); + --spectrum-edge-to-visual-only-75: 4px; + --spectrum-edge-to-visual-only-100: 7px; + --spectrum-edge-to-visual-only-200: 8px; + --spectrum-edge-to-visual-only-300: 9px; +} - /* hack to fix the incorrect min-width */ - --spectrum-actionbutton-textonly-min-width: var(--spectrum-global-dimension-size-300); + +.spectrum-ActionButton--sizeS { + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-75); + --spectrum-actionbutton-height: var(--spectrum-component-height-75); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-75); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-75); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-75); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-small); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-75) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-75) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-75) - var(--spectrum-actionbutton-border-width)); } .spectrum-ActionButton--sizeM { - @remapvars { - find: --spectrum-actionbutton-m-; - replace: --spectrum-actionbutton-; - } - - /* todo: remove hardcoded values when we update DNA */ - --spectrum-actionbutton-hold-icon-padding-bottom: var(--spectrum-global-dimension-size-40); - --spectrum-actionbutton-hold-icon-padding-right: var(--spectrum-global-dimension-size-40); + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-100); + --spectrum-actionbutton-height: var(--spectrum-component-height-100); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-100); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-100); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-100); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-medium); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-100) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-100) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-100) - var(--spectrum-actionbutton-border-width)); } .spectrum-ActionButton--sizeL { - @remapvars { - find: --spectrum-actionbutton-l-; - replace: --spectrum-actionbutton-; - } - - /* todo: remove hardcoded values when we update DNA */ - --spectrum-actionbutton-hold-icon-padding-bottom: var(--spectrum-global-dimension-size-50); - --spectrum-actionbutton-hold-icon-padding-right: var(--spectrum-global-dimension-size-50); + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-200); + --spectrum-actionbutton-height: var(--spectrum-component-height-200); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-200); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-200); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-200); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-large); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-200) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-200) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-200) - var(--spectrum-actionbutton-border-width)); } .spectrum-ActionButton--sizeXL { - @remapvars { - find: --spectrum-actionbutton-xl-; - replace: --spectrum-actionbutton-; - } - - /* todo: remove hardcoded values when we update DNA */ - --spectrum-actionbutton-hold-icon-padding-bottom: var(--spectrum-global-dimension-size-65); - --spectrum-actionbutton-hold-icon-padding-right: var(--spectrum-global-dimension-size-65); + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-300); + --spectrum-actionbutton-height: var(--spectrum-component-height-300); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-300); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-300); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-300); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-extra-large); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-300) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-300) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-300) - var(--spectrum-actionbutton-border-width)); } -.spectrum-ActionButton {/* --spectrum-actionbutton-textonly-padding-left 12px */ /* --spectrum-actionbutton-textonly-border-size 1px */ - /* Adjustments for inset/outset padding in DNA */ - --spectrum-actionbutton-padding-left-adjusted: calc(var(--spectrum-actionbutton-texticon-padding-left) - var(--spectrum-actionbutton-texticon-border-size)); - --spectrum-actionbutton-padding-right-adjusted: calc(var(--spectrum-actionbutton-texticon-padding-right) - var(--spectrum-actionbutton-texticon-border-size)); - --spectrum-actionbutton-textonly-padding-left-adjusted: calc(var(--spectrum-actionbutton-textonly-padding-left) - var(--spectrum-actionbutton-textonly-border-size)); - --spectrum-actionbutton-textonly-padding-right-adjusted: calc(var(--spectrum-actionbutton-textonly-padding-right) - var(--spectrum-actionbutton-textonly-border-size)); - --spectrum-actionbutton-icononly-padding-left-adjusted: calc(var(--spectrum-actionbutton-icononly-padding-left) - var(--spectrum-actionbutton-icononly-border-size)); - --spectrum-actionbutton-icononly-padding-right-adjusted: calc(var(--spectrum-actionbutton-icononly-padding-right) - var(--spectrum-actionbutton-icononly-border-size)); - --spectrum-actionbutton-focus-ring-border-radius-adjusted: calc(var(--spectrum-actionbutton-quiet-textonly-border-radius) + var(--spectrum-actionbutton-focus-ring-gap)); -} +.spectrum-ActionButton { + --spectrum-actionbutton-border-radius: var(--spectrum-corner-radius-100); + --spectrum-actionbutton-border-width: var(--spectrum-border-width-100); -a.spectrum-ActionButton { - @inherit: %spectrum-AnchorButton; + --spectrum-actionbutton-focus-ring-gap: var(--spectrum-focus-ring-gap); + --spectrum-actionbutton-focus-ring-thickness: var(--spectrum-focus-ring-thickness); + --spectrum-actionbutton-focus-ring-color: var(--spectrum-focus-ring-color); + --spectrum-actionbutton-focus-ring-border-radius: calc(var(--spectrum-actionbutton-border-radius) + var(--spectrum-actionbutton-focus-ring-gap)); } .spectrum-ActionButton { @inherit: %spectrum-BaseButton; position: relative; + padding-inline-start: 0; + padding-inline-end: 0; - block-size: var(--spectrum-actionbutton-textonly-height); - min-inline-size: var(--spectrum-actionbutton-textonly-min-width); + min-inline-size: var(--spectrum-actionbutton-min-width); + height: var(--spectrum-actionbutton-height); + border-radius: var(--spectrum-actionbutton-border-radius); + border-width: var(--spectrum-actionbutton-border-width); /* Start with text-only padding */ - padding-inline: var(--spectrum-actionbutton-textonly-padding-left-adjusted) var(--spectrum-actionbutton-textonly-padding-right-adjusted); - - border-width: var(--spectrum-actionbutton-textonly-border-size); - border-radius: var(--spectrum-actionbutton-textonly-border-radius); - - font-size: var(--spectrum-actionbutton-textonly-text-size); - font-weight: var(--spectrum-actionbutton-textonly-text-font-weight); - line-height: var(--spectrum-actionbutton-textonly-text-line-height); - - /* Let static variants inherit their color */ - color: inherit; + padding-inline-start: var(--spectrum-actionbutton-edge-to-text); + padding-inline-end: var(--spectrum-actionbutton-edge-to-text); +} - .spectrum-Icon { - @inherit: %spectrum-ButtonIcon; +a.spectrum-ActionButton { + @inherit: %spectrum-AnchorButton; +} - /* Scoot over, assuming we have both icon and text */ - margin-inline-start: calc(-1 * (var(--spectrum-actionbutton-textonly-padding-left-adjusted) - var(--spectrum-actionbutton-padding-left-adjusted))); - } +.spectrum-ActionButton-icon { + width: var(--spectrum-actionbutton-icon-size); + height: var(--spectrum-actionbutton-icon-size); - .spectrum-Icon + .spectrum-ActionButton-label { + & + .spectrum-ActionButton-label { /* Have gap on on the left */ - padding-inline-start: var(--spectrum-actionbutton-texticon-icon-gap); + padding-inline-start: var(--spectrum-actionbutton-text-to-visual); - /* - Have no padding on the right (it's built into the element) - This will fail if --spectrum-actionbutton-textonly-padding-right !== --spectrum-actionbutton-padding-right - */ + /* Have no padding on the right (it's built into the element) */ padding-inline-end: 0; } - .spectrum-ActionButton-hold + .spectrum-Icon, - .spectrum-Icon:only-child { - /* Use icon-only padding, subtracted from the default text-only padding */ - margin-left: calc(-1 * (var(--spectrum-actionbutton-textonly-padding-left-adjusted) - var(--spectrum-actionbutton-icononly-padding-left-adjusted))); - margin-right: calc(-1 * (var(--spectrum-actionbutton-textonly-padding-right-adjusted) - var(--spectrum-actionbutton-icononly-padding-right-adjusted))); - } + margin-inline-start: calc(-1 * (var(--spectrum-actionbutton-edge-to-text) - var(--spectrum-actionbutton-edge-to-visual))); +} + +.spectrum-ActionButton-hold + .spectrum-ActionButton-icon, +.spectrum-ActionButton-icon:only-child { + /* Use icon-only padding, subtracted from the default text-only padding */ + margin-inline-start: calc(-1 * (var(--spectrum-actionbutton-edge-to-text) - var(--spectrum-actionbutton-edge-to-visual-only))); + margin-inline-end: calc(-1 * (var(--spectrum-actionbutton-edge-to-text) - var(--spectrum-actionbutton-edge-to-visual-only))); } .spectrum-ActionButton-label { @inherit: %spectrum-ButtonLabel; + font-size: var(--spectrum-actionbutton-font-size); + white-space: nowrap; overflow: hidden; text-overflow: ellipsis; @@ -132,27 +139,16 @@ a.spectrum-ActionButton { .spectrum-ActionButton-hold { position: absolute; - inset-inline-end: var(--spectrum-actionbutton-textonly-hold-icon-padding-right); - inset-block-end: var(--spectrum-actionbutton-textonly-hold-icon-padding-bottom); + inset-inline-end: calc(var(--spectrum-actionbutton-edge-to-hold-icon) - var(--spectrum-actionbutton-border-width)); + inset-block-end: calc(var(--spectrum-actionbutton-edge-to-hold-icon) - var(--spectrum-actionbutton-border-width)); transform: logical rotate(0deg); } -.spectrum-ActionButton--quiet { - border-width: var(--spectrum-actionbutton-quiet-textonly-border-size); - border-radius: var(--spectrum-actionbutton-quiet-textonly-border-radius); - - font-size: var(--spectrum-actionbutton-quiet-textonly-text-size); - font-weight: var(--spectrum-actionbutton-quiet-textonly-text-font-weight); -} /* special cases for focus-ring */ .spectrum-ActionButton { - --spectrum-actionbutton-focus-ring-gap: var(--spectrum-alias-component-focusring-gap); - --spectrum-actionbutton-focus-ring-size: var(--spectrum-alias-component-focusring-size); - --spectrum-actionbutton-focus-ring-color: var(--spectrum-actionbutton-m-textonly-focus-ring-border-color-key-focus); - - transition: border-color var(--spectrum-global-animation-duration-100) ease-in-out; + transition: border-color var(--spectrum-animation-duration-100) ease-in-out; &:after { pointer-events: none; @@ -162,32 +158,24 @@ a.spectrum-ActionButton { right: 0; bottom: 0; top: 0; - margin: calc((var(--spectrum-actionbutton-focus-ring-gap) + var(--spectrum-actionbutton-textonly-border-size)) * -1); - border-radius: var(--spectrum-actionbutton-focus-ring-border-radius-adjusted); - transition: box-shadow var(--spectrum-global-animation-duration-100) ease-in-out; + margin: calc((var(--spectrum-actionbutton-focus-ring-gap) + var(--spectrum-actionbutton-border-width)) * -1); + border-radius: var(--spectrum-actionbutton-focus-ring-border-radius); + transition: box-shadow var(--spectrum-animation-duration-100) ease-in-out; } &:focus-ring { - /* kill the default ring */ box-shadow: none !important; &:after { - box-shadow: 0 0 0 var(--spectrum-actionbutton-focus-ring-size) var(--spectrum-actionbutton-focus-ring-color); + box-shadow: 0 0 0 var(--spectrum-actionbutton-focus-ring-thickness) var(--spectrum-actionbutton-focus-ring-color); } } } .spectrum-ActionButton--staticWhite { - --spectrum-actionbutton-focus-ring-color: var(--spectrum-global-color-static-white); -} - -.spectrum-ActionButton--staticBlack { - --spectrum-actionbutton-focus-ring-color: var(--spectrum-global-color-static-black); + --spectrum-actionbutton-focus-ring-color: var(--spectrum-white); } -.spectrum-ActionButton--emphasized.is-selected, -.spectrum-ActionButton--staticWhite, .spectrum-ActionButton--staticBlack { - --spectrum-actionbutton-focus-ring-gap: var(--spectrum-alias-component-focusring-gap-emphasized); - --spectrum-actionbutton-focus-ring-size: var(--spectrum-alias-component-focusring-size-emphasized); + --spectrum-actionbutton-focus-ring-color: var(--spectrum-black); } diff --git a/components/actionbutton/metadata/actionbutton.yml b/components/actionbutton/metadata/actionbutton.yml index 75a07a21325..dedcbf6d3f5 100644 --- a/components/actionbutton/metadata/actionbutton.yml +++ b/components/actionbutton/metadata/actionbutton.yml @@ -8,6 +8,9 @@ description: | sections: - name: Migration Guide description: | + ### Action Button now required a class on its icon + The `.spectrum-ActionButton-icon` class is now required on the icon. + ### T-shirt sizing Action Button now supports t-shirt sizing and requires that you specify the size by adding a `.spectrum-ActionButton--size*` class. @@ -52,14 +55,14 @@ examples: @@ -68,7 +71,7 @@ examples: - Edit @@ -99,7 +102,7 @@ examples: - Edit @@ -131,7 +134,7 @@ examples: - Edit @@ -163,7 +166,7 @@ examples: - Edit @@ -200,7 +203,7 @@ examples: - Edit @@ -231,7 +234,7 @@ examples: - Edit @@ -262,7 +265,7 @@ examples: - Edit @@ -293,7 +296,7 @@ examples: - Edit @@ -331,7 +334,7 @@ examples: - Edit @@ -362,7 +365,7 @@ examples: - Edit @@ -393,7 +396,7 @@ examples: - Edit @@ -424,7 +427,7 @@ examples: - Edit @@ -462,7 +465,7 @@ examples: - Edit @@ -493,7 +496,7 @@ examples: - Edit @@ -524,7 +527,7 @@ examples: - Edit @@ -555,7 +558,7 @@ examples: - Edit @@ -592,7 +595,7 @@ examples: - Edit @@ -623,7 +626,7 @@ examples: - Edit @@ -654,7 +657,7 @@ examples: - Edit @@ -685,7 +688,7 @@ examples: - Edit @@ -723,7 +726,7 @@ examples: - Edit @@ -754,7 +757,7 @@ examples: - Edit @@ -785,7 +788,7 @@ examples: - Edit @@ -816,7 +819,7 @@ examples: - Edit @@ -855,7 +858,7 @@ examples: - Edit @@ -886,7 +889,7 @@ examples: - Edit @@ -917,7 +920,7 @@ examples: - Edit @@ -948,7 +951,7 @@ examples: - Edit @@ -988,7 +991,7 @@ examples: - Edit @@ -1019,7 +1022,7 @@ examples: - Edit @@ -1050,7 +1053,7 @@ examples: - Edit @@ -1081,7 +1084,7 @@ examples: - Edit @@ -1120,7 +1123,7 @@ examples: - Edit @@ -1151,7 +1154,7 @@ examples: - Edit @@ -1182,7 +1185,7 @@ examples: - Edit @@ -1213,7 +1216,7 @@ examples: - Edit + From 0d32da921edd5bca1de8e262d2b4d87007abc0a0 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 12:04:51 -0700 Subject: [PATCH 08/23] chore: don't warn for locally defined custom properties API --- tools/component-builder/css/vars.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/component-builder/css/vars.js b/tools/component-builder/css/vars.js index 9c7e6280d35..325093b074b 100644 --- a/tools/component-builder/css/vars.js +++ b/tools/component-builder/css/vars.js @@ -59,8 +59,8 @@ function bakeVars() { if (varName.indexOf('spectrum-global') !== -1) { logger.warn(`⚠️ ${pkg.name} directly uses global variable ${varName}`); } - else if (!allVars[varName]) { - if (!varName.startsWith('--custom') && componentVars.indexOf(varName) === -1) { + else if (!allVars[varName] && !varName.startsWith('--custom')) { + if (componentVars.indexOf(varName) === -1) { errors.push(`${pkg.name} uses undefined variable ${varName}`); } else { From 80e39ea20515bc352541ac0104df0a07953f9392 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 12:54:22 -0700 Subject: [PATCH 09/23] fix: add missing focus-ring-color token, fix emphasized speiling --- components/actionbutton/index.css | 4 +++- components/actionbutton/metadata/actionbutton.yml | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index fb94265cc30..ffbbc459671 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -32,6 +32,8 @@ governing permissions and limitations under the License. --custom-actionbutton-content-color-focus: x; --custom-actionbutton-content-color-disabled: x; + --custom-actionbutton-focus-ring-color: x; + --custom-actionbutton-min-width: x; --custom-actionbutton-height: x; @@ -91,7 +93,7 @@ governing permissions and limitations under the License. --spectrum-actionbutton-border-color-down: transparent; --spectrum-actionbutton-border-color-focus: transparent; - &.spectrum-ActionButton--emphaszied { + &.spectrum-ActionButton--emphasized { --spectrum-actionbutton-background-color-default: var(--spectrum-accent-background-color-default); --spectrum-actionbutton-background-color-hover: var(--spectrum-accent-background-color-hover); --spectrum-actionbutton-background-color-down: var(--spectrum-accent-background-color-down); diff --git a/components/actionbutton/metadata/actionbutton.yml b/components/actionbutton/metadata/actionbutton.yml index 0406be89b4f..e05409504d1 100644 --- a/components/actionbutton/metadata/actionbutton.yml +++ b/components/actionbutton/metadata/actionbutton.yml @@ -29,6 +29,7 @@ sections: | `--custom-actionbutton-content-color-down` | | `--custom-actionbutton-content-color-focus` | | `--custom-actionbutton-content-color-disabled` | + | `--custom-actionbutton-focus-ring-color` | | `--custom-actionbutton-min-width` | | `--custom-actionbutton-height` | | `--custom-actionbutton-icon-size` | @@ -1277,6 +1278,8 @@ examples: --custom-actionbutton-content-color-down: var(--spectrum-orange-1000); --custom-actionbutton-content-color-focus: var(--spectrum-orange-1300); + --custom-actionbutton-focus-ring-color: var(--spectrum-orange-800); + --custom-actionbutton-min-width: 24px; --custom-actionbutton-height: 44px; From bd8a16583f92c75895d06484fad77fb5018c16c8 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 13:12:29 -0700 Subject: [PATCH 10/23] fix: disabled background color, emphasized override --- components/actionbutton/index.css | 23 ++++++++++--------- .../actionbutton/metadata/actionbutton.yml | 10 ++++---- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index ffbbc459671..ccec32dec1e 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -33,6 +33,7 @@ governing permissions and limitations under the License. --custom-actionbutton-content-color-disabled: x; --custom-actionbutton-focus-ring-color: x; + --custom-actionbutton-static-content-color: x; --custom-actionbutton-min-width: x; --custom-actionbutton-height: x; @@ -64,8 +65,8 @@ governing permissions and limitations under the License. --spectrum-actionbutton-content-color-down: var(--spectrum-neutral-content-color-down); --spectrum-actionbutton-content-color-focus: var(--spectrum-neutral-content-color-key-focus); - --spectrum-actionbutton-background-color-disabled: transparent; - --spectrum-actionbutton-border-color-disabled: var(--spectrum-disabled-border-color); + --spectrum-actionbutton-background-color-disabled: var(--spectrum-disabled-background-color); + --spectrum-actionbutton-border-color-disabled: transparent; --spectrum-actionbutton-content-color-disabled: var(--spectrum-disabled-content-color); &.spectrum-ActionButton--quiet { @@ -141,10 +142,10 @@ governing permissions and limitations under the License. --spectrum-actionbutton-background-color-down: var(--spectrum-transparent-black-900); --spectrum-actionbutton-background-color-focus: var(--spectrum-transparent-black-900); - --spectrum-actionbutton-content-color-default: var(--spectrum-white); - --spectrum-actionbutton-content-color-hover: var(--spectrum-white); - --spectrum-actionbutton-content-color-down: var(--spectrum-white); - --spectrum-actionbutton-content-color-focus: var(--spectrum-white); + --spectrum-actionbutton-content-color-default: var(--custom-actionbutton-static-content-color, var(--spectrum-white)); + --spectrum-actionbutton-content-color-hover: var(--custom-actionbutton-static-content-color, var(--spectrum-white)); + --spectrum-actionbutton-content-color-down: var(--custom-actionbutton-static-content-color, var(--spectrum-white)); + --spectrum-actionbutton-content-color-focus: var(--custom-actionbutton-static-content-color, var(--spectrum-white)); } } @@ -176,10 +177,10 @@ governing permissions and limitations under the License. --spectrum-actionbutton-background-color-down: var(--spectrum-transparent-white-900); --spectrum-actionbutton-background-color-focus: var(--spectrum-transparent-white-900); - --spectrum-actionbutton-content-color-default: var(--spectrum-black); - --spectrum-actionbutton-content-color-hover: var(--spectrum-black); - --spectrum-actionbutton-content-color-down: var(--spectrum-black); - --spectrum-actionbutton-content-color-focus: var(--spectrum-black); + --spectrum-actionbutton-content-color-default: var(--custom-actionbutton-static-content-color, var(--spectrum-black)); + --spectrum-actionbutton-content-color-hover: var(--custom-actionbutton-static-content-color, var(--spectrum-black)); + --spectrum-actionbutton-content-color-down: var(--custom-actionbutton-static-content-color, var(--spectrum-black)); + --spectrum-actionbutton-content-color-focus: var(--custom-actionbutton-static-content-color, var(--spectrum-black)); } } } @@ -198,7 +199,7 @@ governing permissions and limitations under the License. --spectrum-actionbutton-border-color-focus: transparent; --spectrum-actionbutton-background-color-disabled: var(--spectrum-disabled-background-color); - --spectrum-actionbutton-border-color-disabled: transparent; + --spectrum-actionbutton-border-color-disabled: var(--spectrum-disabled-border-color); --spectrum-actionbutton-content-color-disabled: var(--spectrum-disabled-content-color); &.is-selected { diff --git a/components/actionbutton/metadata/actionbutton.yml b/components/actionbutton/metadata/actionbutton.yml index e05409504d1..731cb619cdf 100644 --- a/components/actionbutton/metadata/actionbutton.yml +++ b/components/actionbutton/metadata/actionbutton.yml @@ -5,6 +5,7 @@ description: | - For Action Buttons that only contain an icon with no label, do not include the element with the `.spectrum-ActionButton-label` class in the markup - If an icon and a label are both used, ensure that the element with the `.spectrum-ActionButton-label` class comes after the `.spectrum-Icon` element. - If the hold icon is used, ensure that the element with the `.spectrum-ActionButton-hold` class comes before the `.spectrum-Icon` element. + - When using `.spectrum-ActionButton--staticWhite` or `.spectrum-ActionButton--staticblack`, use the `--custom-actionbutton-static-content-color` custom property to set the text color when selected. sections: - name: Custom Properties API description: | @@ -30,6 +31,7 @@ sections: | `--custom-actionbutton-content-color-focus` | | `--custom-actionbutton-content-color-disabled` | | `--custom-actionbutton-focus-ring-color` | + | `--custom-actionbutton-static-content-color` | | `--custom-actionbutton-min-width` | | `--custom-actionbutton-height` | | `--custom-actionbutton-icon-size` | @@ -732,7 +734,7 @@ examples: - id: actionbutton-staticwhite name: Static White markup: | -
+

Default

@@ -864,7 +866,7 @@ examples: - id: actionbutton-staticblack name: Static Black markup: | -
+

Default

@@ -997,7 +999,7 @@ examples: - id: actionbutton-staticwhite-quiet name: Static White (quiet) markup: | -
+

Default

@@ -1129,7 +1131,7 @@ examples: - id: actionbutton-staticblack-quiet name: Static Black (quiet) markup: | -
+

Default

From 685b8acafe4b05253c80ccf9b0f28b01b7683b2e Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 13:25:38 -0700 Subject: [PATCH 11/23] fix: active overrides focus --- components/actionbutton/index.css | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index ccec32dec1e..5514e07b574 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -325,16 +325,16 @@ governing permissions and limitations under the License. border-color: var(--custom-actionbutton-border-color-hover, var(--spectrum-actionbutton-border-color-hover)); color: var(--custom-actionbutton-content-color-hover, var(--spectrum-actionbutton-content-color-hover)); } - &:active { - background-color: var(--custom-actionbutton-background-color-down, var(--spectrum-actionbutton-background-color-down)); - border-color: var(--custom-actionbutton-border-color-down, var(--spectrum-actionbutton-border-color-down)); - color: var(--custom-actionbutton-content-color-down, var(--spectrum-actionbutton-content-color-down)); - } &:focus-ring { background-color: var(--custom-actionbutton-background-color-focus, var(--spectrum-actionbutton-background-color-focus)); border-color: var(--custom-actionbutton-border-color-focus, var(--spectrum-actionbutton-border-color-focus)); color: var(--custom-actionbutton-content-color-focus, var(--spectrum-actionbutton-content-color-focus)); } + &:active { + background-color: var(--custom-actionbutton-background-color-down, var(--spectrum-actionbutton-background-color-down)); + border-color: var(--custom-actionbutton-border-color-down, var(--spectrum-actionbutton-border-color-down)); + color: var(--custom-actionbutton-content-color-down, var(--spectrum-actionbutton-content-color-down)); + } &:disabled, &.is-disabled { background-color: var(--custom-actionbutton-background-color-disabled, var(--spectrum-actionbutton-background-color-disabled)); From c6850b73dfcb6c3d97ca1de0484dbff755483156 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 14:11:51 -0700 Subject: [PATCH 12/23] style: newline --- components/actionbutton/index.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index 5514e07b574..8cbb58ba2df 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -390,7 +390,6 @@ a.spectrum-ActionButton { transform: logical rotate(0deg); } - /* special cases for focus-ring */ .spectrum-ActionButton { transition: border-color var(--custom-actionbutton-animation-duration, var(--spectrum-actionbutton-animation-duration)) ease-in-out; @@ -415,4 +414,4 @@ a.spectrum-ActionButton { box-shadow: 0 0 0 var(--custom-actionbutton-focus-ring-thickness, var(--spectrum-actionbutton-focus-ring-thickness)) var(--custom-actionbutton-focus-ring-color, var(--spectrum-actionbutton-focus-ring-color)); } } -} \ No newline at end of file +} From b99c5032c9641a21e0689372764b52fa71f470ed Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 14:50:41 -0700 Subject: [PATCH 13/23] fix: disabled + selected, move code around --- components/actionbutton/index.css | 175 +++++++++++++----------------- 1 file changed, 75 insertions(+), 100 deletions(-) diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index 8cbb58ba2df..f74d6b59c25 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -12,41 +12,68 @@ governing permissions and limitations under the License. @import "../commons/basebutton.css"; -/** .spectrum-ActionButton { - --custom-actionbutton-background-color-default: x; - --custom-actionbutton-background-color-hover: x; - --custom-actionbutton-background-color-down: x; - --custom-actionbutton-background-color-focus: x; - --custom-actionbutton-background-color-disabled: x; - - --custom-actionbutton-border-color-default: x; - --custom-actionbutton-border-color-hover: x; - --custom-actionbutton-border-color-down: x; - --custom-actionbutton-border-color-focus: x; - --custom-actionbutton-border-color-disabled: x; - - --custom-actionbutton-content-color-default: x; - --custom-actionbutton-content-color-hover: x; - --custom-actionbutton-content-color-down: x; - --custom-actionbutton-content-color-focus: x; - --custom-actionbutton-content-color-disabled: x; - - --custom-actionbutton-focus-ring-color: x; - --custom-actionbutton-static-content-color: x; - - --custom-actionbutton-min-width: x; - --custom-actionbutton-height: x; - - --custom-actionbutton-icon-size: x; - --custom-actionbutton-font-size: x; - --custom-actionbutton-text-to-visual: x; - --custom-actionbutton-edge-to-hold-icon: x; - --custom-actionbutton-edge-to-visual: x; - --custom-actionbutton-edge-to-text: x; - --custom-actionbutton-edge-to-visual-only: x; + --spectrum-actionbutton-animation-duration: var(--spectrum-animation-duration-100); + --spectrum-actionbutton-border-radius: var(--spectrum-corner-radius-100); + --spectrum-actionbutton-border-width: var(--spectrum-border-width-100); + + --spectrum-actionbutton-focus-ring-gap: var(--spectrum-focus-ring-gap); + --spectrum-actionbutton-focus-ring-thickness: var(--spectrum-focus-ring-thickness); + --spectrum-actionbutton-focus-ring-color: var(--spectrum-focus-ring-color); + --spectrum-actionbutton-focus-ring-border-radius: calc(var(--spectrum-actionbutton-border-radius) + var(--spectrum-actionbutton-focus-ring-gap)); +} + +.spectrum-ActionButton--sizeS { + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-75); + --spectrum-actionbutton-height: var(--spectrum-component-height-75); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-75); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-75); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-75); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-small); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-75) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-75) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-75) - var(--spectrum-actionbutton-border-width)); +} + +.spectrum-ActionButton--sizeM { + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-100); + --spectrum-actionbutton-height: var(--spectrum-component-height-100); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-100); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-100); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-100); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-medium); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-100) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-100) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-100) - var(--spectrum-actionbutton-border-width)); +} + +.spectrum-ActionButton--sizeL { + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-200); + --spectrum-actionbutton-height: var(--spectrum-component-height-200); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-200); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-200); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-200); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-large); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-200) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-200) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-200) - var(--spectrum-actionbutton-border-width)); +} + +.spectrum-ActionButton--sizeXL { + --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-300); + --spectrum-actionbutton-height: var(--spectrum-component-height-300); + + --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-300); + --spectrum-actionbutton-font-size: var(--spectrum-font-size-300); + --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-300); + --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-extra-large); + --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-300) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-300) - var(--spectrum-actionbutton-border-width)); + --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-300) - var(--spectrum-actionbutton-border-width)); } -*/ .spectrum { .spectrum-ActionButton { @@ -65,8 +92,8 @@ governing permissions and limitations under the License. --spectrum-actionbutton-content-color-down: var(--spectrum-neutral-content-color-down); --spectrum-actionbutton-content-color-focus: var(--spectrum-neutral-content-color-key-focus); - --spectrum-actionbutton-background-color-disabled: var(--spectrum-disabled-background-color); - --spectrum-actionbutton-border-color-disabled: transparent; + --spectrum-actionbutton-background-color-disabled: transparent; + --spectrum-actionbutton-border-color-disabled: var(--spectrum-disabled-border-color); --spectrum-actionbutton-content-color-disabled: var(--spectrum-disabled-content-color); &.spectrum-ActionButton--quiet { @@ -94,6 +121,9 @@ governing permissions and limitations under the License. --spectrum-actionbutton-border-color-down: transparent; --spectrum-actionbutton-border-color-focus: transparent; + --spectrum-actionbutton-background-color-disabled: var(--spectrum-disabled-background-color); + --spectrum-actionbutton-border-color-disabled: transparent; + &.spectrum-ActionButton--emphasized { --spectrum-actionbutton-background-color-default: var(--spectrum-accent-background-color-default); --spectrum-actionbutton-background-color-hover: var(--spectrum-accent-background-color-hover); @@ -146,6 +176,9 @@ governing permissions and limitations under the License. --spectrum-actionbutton-content-color-hover: var(--custom-actionbutton-static-content-color, var(--spectrum-white)); --spectrum-actionbutton-content-color-down: var(--custom-actionbutton-static-content-color, var(--spectrum-white)); --spectrum-actionbutton-content-color-focus: var(--custom-actionbutton-static-content-color, var(--spectrum-white)); + + --spectrum-actionbutton-background-color-disabled: var(--spectrum-disabled-static-black-background-color); + --spectrum-actionbutton-border-color-disabled: transparent; } } @@ -181,7 +214,9 @@ governing permissions and limitations under the License. --spectrum-actionbutton-content-color-hover: var(--custom-actionbutton-static-content-color, var(--spectrum-black)); --spectrum-actionbutton-content-color-down: var(--custom-actionbutton-static-content-color, var(--spectrum-black)); --spectrum-actionbutton-content-color-focus: var(--custom-actionbutton-static-content-color, var(--spectrum-black)); - } + + --spectrum-actionbutton-background-color-disabled: var(--spectrum-disabled-static-white-background-color); + --spectrum-actionbutton-border-color-disabled: transparent; } } } } @@ -199,7 +234,7 @@ governing permissions and limitations under the License. --spectrum-actionbutton-border-color-focus: transparent; --spectrum-actionbutton-background-color-disabled: var(--spectrum-disabled-background-color); - --spectrum-actionbutton-border-color-disabled: var(--spectrum-disabled-border-color); + --spectrum-actionbutton-border-color-disabled: transparent; --spectrum-actionbutton-content-color-disabled: var(--spectrum-disabled-content-color); &.is-selected { @@ -238,69 +273,6 @@ governing permissions and limitations under the License. } } -.spectrum-ActionButton--sizeS { - --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-75); - --spectrum-actionbutton-height: var(--spectrum-component-height-75); - - --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-75); - --spectrum-actionbutton-font-size: var(--spectrum-font-size-75); - --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-75); - --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-small); - --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-75) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-75) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-75) - var(--spectrum-actionbutton-border-width)); -} - -.spectrum-ActionButton--sizeM { - --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-100); - --spectrum-actionbutton-height: var(--spectrum-component-height-100); - - --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-100); - --spectrum-actionbutton-font-size: var(--spectrum-font-size-100); - --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-100); - --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-medium); - --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-100) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-100) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-100) - var(--spectrum-actionbutton-border-width)); -} - -.spectrum-ActionButton--sizeL { - --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-200); - --spectrum-actionbutton-height: var(--spectrum-component-height-200); - - --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-200); - --spectrum-actionbutton-font-size: var(--spectrum-font-size-200); - --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-200); - --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-large); - --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-200) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-200) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-200) - var(--spectrum-actionbutton-border-width)); -} - -.spectrum-ActionButton--sizeXL { - --spectrum-actionbutton-min-width: var(--spectrum-component-minimum-width-300); - --spectrum-actionbutton-height: var(--spectrum-component-height-300); - - --spectrum-actionbutton-icon-size: var(--spectrum-workflow-icon-size-300); - --spectrum-actionbutton-font-size: var(--spectrum-font-size-300); - --spectrum-actionbutton-text-to-visual: var(--spectrum-text-to-visual-300); - --spectrum-actionbutton-edge-to-hold-icon: var(--spectrum-action-button-edge-to-hold-icon-extra-large); - --spectrum-actionbutton-edge-to-visual: calc(var(--spectrum-edge-to-visual-300) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-text: calc(var(--spectrum-edge-to-text-300) - var(--spectrum-actionbutton-border-width)); - --spectrum-actionbutton-edge-to-visual-only: calc(var(--spectrum-edge-to-visual-only-300) - var(--spectrum-actionbutton-border-width)); -} - -.spectrum-ActionButton { - --spectrum-actionbutton-animation-duration: var(--spectrum-animation-duration-100); - --spectrum-actionbutton-border-radius: var(--spectrum-corner-radius-100); - --spectrum-actionbutton-border-width: var(--spectrum-border-width-100); - - --spectrum-actionbutton-focus-ring-gap: var(--spectrum-focus-ring-gap); - --spectrum-actionbutton-focus-ring-thickness: var(--spectrum-focus-ring-thickness); - --spectrum-actionbutton-focus-ring-color: var(--spectrum-focus-ring-color); - --spectrum-actionbutton-focus-ring-border-radius: calc(var(--spectrum-actionbutton-border-radius) + var(--spectrum-actionbutton-focus-ring-gap)); -} - .spectrum-ActionButton { @inherit: %spectrum-BaseButton; position: relative; @@ -325,16 +297,19 @@ governing permissions and limitations under the License. border-color: var(--custom-actionbutton-border-color-hover, var(--spectrum-actionbutton-border-color-hover)); color: var(--custom-actionbutton-content-color-hover, var(--spectrum-actionbutton-content-color-hover)); } + &:focus-ring { background-color: var(--custom-actionbutton-background-color-focus, var(--spectrum-actionbutton-background-color-focus)); border-color: var(--custom-actionbutton-border-color-focus, var(--spectrum-actionbutton-border-color-focus)); color: var(--custom-actionbutton-content-color-focus, var(--spectrum-actionbutton-content-color-focus)); } + &:active { background-color: var(--custom-actionbutton-background-color-down, var(--spectrum-actionbutton-background-color-down)); border-color: var(--custom-actionbutton-border-color-down, var(--spectrum-actionbutton-border-color-down)); color: var(--custom-actionbutton-content-color-down, var(--spectrum-actionbutton-content-color-down)); } + &:disabled, &.is-disabled { background-color: var(--custom-actionbutton-background-color-disabled, var(--spectrum-actionbutton-background-color-disabled)); From 2da4d40d788bab5bc1e5d287e1499ffa7e7a7591 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 16:23:40 -0700 Subject: [PATCH 14/23] fix: update tokens --- components/coretokens/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/coretokens/package.json b/components/coretokens/package.json index e451af0bdc8..1662fc599b7 100644 --- a/components/coretokens/package.json +++ b/components/coretokens/package.json @@ -18,7 +18,7 @@ "devDependencies": { "gulp": "^4.0.0", "gulp-concat": "^2.6.1", - "@adobe/spectrum-tokens": "^12.0.0-beta.18", + "@adobe/spectrum-tokens": "^12.0.0-beta.19", "style-dictionary": "^3.7.0", "style-dictionary-sets": "^1.4.1" }, From d8ca3cec8bd45902185a8b877a256c2732a1a973 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 16:23:58 -0700 Subject: [PATCH 15/23] fix: repair WHCM that I broke --- components/actionbutton/index.css | 146 ++++++++++++++++++++++++++++ components/actionbutton/skin.css | 155 ------------------------------ 2 files changed, 146 insertions(+), 155 deletions(-) delete mode 100644 components/actionbutton/skin.css diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index f74d6b59c25..8418b200e06 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -273,6 +273,152 @@ governing permissions and limitations under the License. } } +@media (forced-colors: active) { + .spectrum-ActionButton { + forced-color-adjust: none; + + --spectrum-actionbutton-focus-ring-thickness: 3px; + + --spectrum-actionbutton-background-color-default: ButtonFace; + --spectrum-actionbutton-background-color-hover: ButtonFace; + --spectrum-actionbutton-background-color-down: ButtonFace; + --spectrum-actionbutton-background-color-focus: ButtonFace; + --spectrum-actionbutton-background-color-disabled: ButtonFace; + + --spectrum-actionbutton-border-color-default: ButtonText; + --spectrum-actionbutton-border-color-hover: ButtonText; + --spectrum-actionbutton-border-color-down: ButtonText; + --spectrum-actionbutton-border-color-focus: Highlight; + --spectrum-actionbutton-border-color-disabled: GrayText; + + --spectrum-actionbutton-content-color-default: ButtonText; + --spectrum-actionbutton-content-color-hover: ButtonText; + --spectrum-actionbutton-content-color-down: ButtonText; + --spectrum-actionbutton-content-color-focus: ButtonText; + --spectrum-actionbutton-content-color-disabled: GrayText; + + &.is-selected { + --spectrum-actionbutton-background-color-default: Highlight; + --spectrum-actionbutton-background-color-hover: Highlight; + --spectrum-actionbutton-background-color-down: Highlight; + --spectrum-actionbutton-background-color-focus: Highlight; + --spectrum-actionbutton-background-color-disabled: ButtonFace; + + --spectrum-actionbutton-border-color-default: HighlightText; + --spectrum-actionbutton-border-color-hover: HighlightText; + --spectrum-actionbutton-border-color-down: HighlightText; + --spectrum-actionbutton-border-color-focus: HighlightText; + --spectrum-actionbutton-border-color-disabled: GrayText; + + --spectrum-actionbutton-content-color-default: HighlightText; + --spectrum-actionbutton-content-color-hover: HighlightText; + --spectrum-actionbutton-content-color-down: HighlightText; + --spectrum-actionbutton-content-color-focus: HighlightText; + --spectrum-actionbutton-content-color-disabled: GrayText; + } + + &.spectrum-ActionButton--emphasized { + --spectrum-actionbutton-background-color: ButtonFace; + --spectrum-actionbutton-background-color-hover: ButtonFace; + --spectrum-actionbutton-background-color-down: ButtonFace; + --spectrum-actionbutton-background-color-focus: ButtonFace; + --spectrum-actionbutton-background-color-disabled: ButtonFace; + + --spectrum-actionbutton-border-color-default: ButtonText; + --spectrum-actionbutton-border-color-hover: ButtonText; + --spectrum-actionbutton-border-color-down: ButtonText; + --spectrum-actionbutton-border-color-focus: ButtonText; + --spectrum-actionbutton-border-color-disabled: GrayText; + + --spectrum-actionbutton-content-color-default: ButtonText; + --spectrum-actionbutton-content-color-hover: ButtonText; + --spectrum-actionbutton-content-color-down: ButtonText; + --spectrum-actionbutton-content-color-focus: ButtonText; + --spectrum-actionbutton-content-color-disabled: GrayText; + + &.is-selected { + --spectrum-actionbutton-background-color-default: Highlight; + --spectrum-actionbutton-background-color-hover: Highlight; + --spectrum-actionbutton-background-color-down: Highlight; + --spectrum-actionbutton-background-color-focus: Highlight; + --spectrum-actionbutton-background-color-disabled: ButtonFace; + + --spectrum-actionbutton-border-color-default: HighlightText; + --spectrum-actionbutton-border-color-hover: HighlightText; + --spectrum-actionbutton-border-color-down: HighlightText; + --spectrum-actionbutton-border-color-focus: HighlightText; + --spectrum-actionbutton-border-color-disabled: GrayText; + + --spectrum-actionbutton-content-color-default: HighlightText; + --spectrum-actionbutton-content-color-hover: HighlightText; + --spectrum-actionbutton-content-color-down: HighlightText; + --spectrum-actionbutton-content-color-focus: HighlightText; + --spectrum-actionbutton-content-color-disabled: GrayText; + } + } + + .spectrum-ActionButton--quiet { + --spectrum-actionbutton-background-color: ButtonFace; + --spectrum-actionbutton-background-color-hover: ButtonFace; + --spectrum-actionbutton-background-color-down: ButtonFace; + --spectrum-actionbutton-background-color-focus: ButtonFace; + --spectrum-actionbutton-background-color-disabled: ButtonFace; + + --spectrum-actionbutton-border-color-default: ButtonFace; + --spectrum-actionbutton-border-color-hover: ButtonFace; + --spectrum-actionbutton-border-color-down: ButtonFace; + --spectrum-actionbutton-border-color-focus: Highlight; + --spectrum-actionbutton-border-color-disabled: ButtonFace; + + --spectrum-actionbutton-content-color-default: ButtonText; + --spectrum-actionbutton-content-color-hover: ButtonText; + --spectrum-actionbutton-content-color-down: ButtonText; + --spectrum-actionbutton-content-color-focus: ButtonText; + --spectrum-actionbutton-content-color-disabled: GrayText; + + &.is-selected { + --spectrum-actionbutton-background-color-default: Highlight; + --spectrum-actionbutton-background-color-hover: Highlight; + --spectrum-actionbutton-background-color-down: Highlight; + --spectrum-actionbutton-background-color-focus: Highlight; + --spectrum-actionbutton-background-color-disabled: ButtonFace; + + --spectrum-actionbutton-border-color-default: HighlightText; + --spectrum-actionbutton-border-color-hover: HighlightText; + --spectrum-actionbutton-border-color-down: HighlightText; + --spectrum-actionbutton-border-color-focus: HighlightText; + --spectrum-actionbutton-border-color-disabled: GrayText; + + --spectrum-actionbutton-content-color-default: HighlightText; + --spectrum-actionbutton-content-color-hover: HighlightText; + --spectrum-actionbutton-content-color-down: HighlightText; + --spectrum-actionbutton-content-color-focus: HighlightText; + --spectrum-actionbutton-content-color-disabled: GrayText; + } + } + + /* + &.spectrum-ActionButton--quiet { + &.spectrum-ActionButton--emphasized { + &:not(:disabled, .is-disabled) { + &:hover { + background-color: var(--spectrum-actionbutton-m-emphasized-textonly-background-color-selected-hover); + border-color: var(--spectrum-actionbutton-m-emphasized-textonly-border-color-selected-hover); + color: var(--spectrum-actionbutton-m-emphasized-textonly-text-color-selected-hover); + } + + &.is-active { + background-color: var(--spectrum-actionbutton-m-emphasized-textonly-background-color-selected-down); + border-color: var(--spectrum-actionbutton-m-emphasized-textonly-border-color-selected-down); + color: var(--spectrum-actionbutton-m-emphasized-textonly-text-color-selected-down); + } + } + } + } + */ + } +} + .spectrum-ActionButton { @inherit: %spectrum-BaseButton; position: relative; diff --git a/components/actionbutton/skin.css b/components/actionbutton/skin.css deleted file mode 100644 index 082e13b1d47..00000000000 --- a/components/actionbutton/skin.css +++ /dev/null @@ -1,155 +0,0 @@ -/* -Copyright 2019 Adobe. All rights reserved. -This file is licensed to you under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. You may obtain a copy -of the License at http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software distributed under -the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS -OF ANY KIND, either express or implied. See the License for the specific language -governing permissions and limitations under the License. -*/ - -@media (forced-colors: active) { - .spectrum-ActionButton { - --spectrum-actionbutton-m-emphasized-texticon-icon-color: ButtonText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-disabled: GrayText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-hover: ButtonText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-key-focus: ButtonText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-selected: HighlightText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-selected-down: HighlightText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-emphasized-texticon-icon-color-selected-key-focus: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-background-color: ButtonFace; - --spectrum-actionbutton-m-emphasized-textonly-background-color-disabled: ButtonFace; - --spectrum-actionbutton-m-emphasized-textonly-background-color-down: ButtonFace; - --spectrum-actionbutton-m-emphasized-textonly-background-color-hover: ButtonFace; - --spectrum-actionbutton-m-emphasized-textonly-background-color-key-focus: ButtonFace; - --spectrum-actionbutton-m-emphasized-textonly-background-color-selected: Highlight; - --spectrum-actionbutton-m-emphasized-textonly-background-color-selected-disabled: ButtonFace; - --spectrum-actionbutton-m-emphasized-textonly-background-color-selected-down: Highlight; - --spectrum-actionbutton-m-emphasized-textonly-background-color-selected-hover: Highlight; - --spectrum-actionbutton-m-emphasized-textonly-background-color-selected-key-focus: Highlight; - --spectrum-actionbutton-m-emphasized-textonly-border-color: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-disabled: GrayText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-down: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-hover: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-key-focus: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-selected: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-selected-down: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-border-color-selected-key-focus: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-hold-icon-color: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-hold-icon-color-disabled: GrayText; - --spectrum-actionbutton-m-emphasized-textonly-hold-icon-color-down: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-hold-icon-color-hover: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-hold-icon-color-key-focus: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-hold-icon-color-selected: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-text-color: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-disabled: GrayText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-down: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-hover: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-key-focus: ButtonText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-selected: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-selected-down: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-emphasized-textonly-text-color-selected-key-focus: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-background-color: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-background-color-disabled: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-background-color-down: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-background-color-hover: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-background-color-key-focus: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-background-color-selected: Highlight; - --spectrum-actionbutton-m-quiet-textonly-background-color-selected-disabled: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-background-color-selected-down: Highlight; - --spectrum-actionbutton-m-quiet-textonly-background-color-selected-hover: Highlight; - --spectrum-actionbutton-m-quiet-textonly-background-color-selected-key-focus: Highlight; - --spectrum-actionbutton-m-quiet-textonly-border-color: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-border-color-disabled: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-border-color-down: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-border-color-hover: ButtonFace; - --spectrum-actionbutton-m-quiet-textonly-border-color-key-focus: Highlight; - --spectrum-actionbutton-m-quiet-textonly-border-color-selected: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-border-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-quiet-textonly-border-color-selected-down: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-border-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-border-color-selected-key-focus: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-text-color: ButtonText; - --spectrum-actionbutton-m-quiet-textonly-text-color-disabled: GrayText; - --spectrum-actionbutton-m-quiet-textonly-text-color-down: ButtonText; - --spectrum-actionbutton-m-quiet-textonly-text-color-hover: ButtonText; - --spectrum-actionbutton-m-quiet-textonly-text-color-key-focus: ButtonText; - --spectrum-actionbutton-m-quiet-textonly-text-color-selected: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-text-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-quiet-textonly-text-color-selected-down: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-text-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-quiet-textonly-text-color-selected-key-focus: HighlightText; - --spectrum-actionbutton-m-texticon-icon-color: ButtonText; - --spectrum-actionbutton-m-texticon-icon-color-disabled: GrayText; - --spectrum-actionbutton-m-texticon-icon-color-hover: ButtonText; - --spectrum-actionbutton-m-texticon-icon-color-key-focus: ButtonText; - --spectrum-actionbutton-m-texticon-icon-color-selected: HighlightText; - --spectrum-actionbutton-m-texticon-icon-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-texticon-icon-color-selected-down: HighlightText; - --spectrum-actionbutton-m-texticon-icon-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-texticon-icon-color-selected-key-focus: HighlightText; - --spectrum-actionbutton-m-textonly-background-color: ButtonFace; - --spectrum-actionbutton-m-textonly-background-color-disabled: ButtonFace; - --spectrum-actionbutton-m-textonly-background-color-down: ButtonFace; - --spectrum-actionbutton-m-textonly-background-color-hover: ButtonFace; - --spectrum-actionbutton-m-textonly-background-color-key-focus: ButtonFace; - --spectrum-actionbutton-m-textonly-background-color-selected: Highlight; - --spectrum-actionbutton-m-textonly-background-color-selected-disabled: ButtonFace; - --spectrum-actionbutton-m-textonly-background-color-selected-down: Highlight; - --spectrum-actionbutton-m-textonly-background-color-selected-hover: Highlight; - --spectrum-actionbutton-m-textonly-background-color-selected-key-focus: Highlight; - --spectrum-actionbutton-m-textonly-border-color: ButtonText; - --spectrum-actionbutton-m-textonly-border-color-disabled: GrayText; - --spectrum-actionbutton-m-textonly-border-color-down: ButtonText; - --spectrum-actionbutton-m-textonly-border-color-hover: ButtonText; - --spectrum-actionbutton-m-textonly-border-color-key-focus: Highlight; - --spectrum-actionbutton-m-textonly-border-color-selected: HighlightText; - --spectrum-actionbutton-m-textonly-border-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-textonly-border-color-selected-down: HighlightText; - --spectrum-actionbutton-m-textonly-border-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-textonly-border-color-selected-key-focus: HighlightText; - --spectrum-actionbutton-m-textonly-hold-icon-color: ButtonText; - --spectrum-actionbutton-m-textonly-hold-icon-color-disabled: GrayText; - --spectrum-actionbutton-m-textonly-hold-icon-color-down: ButtonText; - --spectrum-actionbutton-m-textonly-hold-icon-color-hover: ButtonText; - --spectrum-actionbutton-m-textonly-hold-icon-color-key-focus: ButtonText; - --spectrum-actionbutton-m-textonly-text-color: ButtonText; - --spectrum-actionbutton-m-textonly-text-color-disabled: GrayText; - --spectrum-actionbutton-m-textonly-text-color-down: ButtonText; - --spectrum-actionbutton-m-textonly-text-color-hover: ButtonText; - --spectrum-actionbutton-m-textonly-text-color-key-focus: ButtonText; - --spectrum-actionbutton-m-textonly-text-color-selected: HighlightText; - --spectrum-actionbutton-m-textonly-text-color-selected-disabled: GrayText; - --spectrum-actionbutton-m-textonly-text-color-selected-down: HighlightText; - --spectrum-actionbutton-m-textonly-text-color-selected-hover: HighlightText; - --spectrum-actionbutton-m-textonly-text-color-selected-key-focus: HighlightText; - - forced-color-adjust: none; - --spectrum-actionbutton-m-quiet-textonly-border-size-key-focus: 3px; - &.spectrum-ActionButton--quiet { - &.spectrum-ActionButton--emphasized { - &:not(:disabled, .is-disabled) { - &:hover { - background-color: var(--spectrum-actionbutton-m-emphasized-textonly-background-color-selected-hover); - border-color: var(--spectrum-actionbutton-m-emphasized-textonly-border-color-selected-hover); - color: var(--spectrum-actionbutton-m-emphasized-textonly-text-color-selected-hover); - } - - &.is-active { - background-color: var(--spectrum-actionbutton-m-emphasized-textonly-background-color-selected-down); - border-color: var(--spectrum-actionbutton-m-emphasized-textonly-border-color-selected-down); - color: var(--spectrum-actionbutton-m-emphasized-textonly-text-color-selected-down); - } - } - } - } - } -} From 0639127bd7c039602c227734e186519983ee1b96 Mon Sep 17 00:00:00 2001 From: Larry Davis Date: Wed, 27 Apr 2022 17:26:30 -0700 Subject: [PATCH 16/23] fix: correct WHCM implementation with @nurthen --- components/actionbutton/index.css | 166 ++++-------------- .../actionbutton/metadata/actionbutton.yml | 40 +++-- 2 files changed, 53 insertions(+), 153 deletions(-) diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css index 8418b200e06..3fc7efaf24f 100644 --- a/components/actionbutton/index.css +++ b/components/actionbutton/index.css @@ -275,147 +275,41 @@ governing permissions and limitations under the License. @media (forced-colors: active) { .spectrum-ActionButton { - forced-color-adjust: none; - - --spectrum-actionbutton-focus-ring-thickness: 3px; - - --spectrum-actionbutton-background-color-default: ButtonFace; - --spectrum-actionbutton-background-color-hover: ButtonFace; - --spectrum-actionbutton-background-color-down: ButtonFace; - --spectrum-actionbutton-background-color-focus: ButtonFace; - --spectrum-actionbutton-background-color-disabled: ButtonFace; - - --spectrum-actionbutton-border-color-default: ButtonText; - --spectrum-actionbutton-border-color-hover: ButtonText; - --spectrum-actionbutton-border-color-down: ButtonText; - --spectrum-actionbutton-border-color-focus: Highlight; - --spectrum-actionbutton-border-color-disabled: GrayText; - - --spectrum-actionbutton-content-color-default: ButtonText; - --spectrum-actionbutton-content-color-hover: ButtonText; - --spectrum-actionbutton-content-color-down: ButtonText; - --spectrum-actionbutton-content-color-focus: ButtonText; - --spectrum-actionbutton-content-color-disabled: GrayText; - - &.is-selected { - --spectrum-actionbutton-background-color-default: Highlight; - --spectrum-actionbutton-background-color-hover: Highlight; - --spectrum-actionbutton-background-color-down: Highlight; - --spectrum-actionbutton-background-color-focus: Highlight; - --spectrum-actionbutton-background-color-disabled: ButtonFace; - - --spectrum-actionbutton-border-color-default: HighlightText; - --spectrum-actionbutton-border-color-hover: HighlightText; - --spectrum-actionbutton-border-color-down: HighlightText; - --spectrum-actionbutton-border-color-focus: HighlightText; - --spectrum-actionbutton-border-color-disabled: GrayText; - - --spectrum-actionbutton-content-color-default: HighlightText; - --spectrum-actionbutton-content-color-hover: HighlightText; - --spectrum-actionbutton-content-color-down: HighlightText; - --spectrum-actionbutton-content-color-focus: HighlightText; - --spectrum-actionbutton-content-color-disabled: GrayText; - } - - &.spectrum-ActionButton--emphasized { - --spectrum-actionbutton-background-color: ButtonFace; - --spectrum-actionbutton-background-color-hover: ButtonFace; - --spectrum-actionbutton-background-color-down: ButtonFace; - --spectrum-actionbutton-background-color-focus: ButtonFace; - --spectrum-actionbutton-background-color-disabled: ButtonFace; - - --spectrum-actionbutton-border-color-default: ButtonText; - --spectrum-actionbutton-border-color-hover: ButtonText; - --spectrum-actionbutton-border-color-down: ButtonText; - --spectrum-actionbutton-border-color-focus: ButtonText; - --spectrum-actionbutton-border-color-disabled: GrayText; - - --spectrum-actionbutton-content-color-default: ButtonText; - --spectrum-actionbutton-content-color-hover: ButtonText; - --spectrum-actionbutton-content-color-down: ButtonText; - --spectrum-actionbutton-content-color-focus: ButtonText; - --spectrum-actionbutton-content-color-disabled: GrayText; - - &.is-selected { - --spectrum-actionbutton-background-color-default: Highlight; - --spectrum-actionbutton-background-color-hover: Highlight; - --spectrum-actionbutton-background-color-down: Highlight; - --spectrum-actionbutton-background-color-focus: Highlight; - --spectrum-actionbutton-background-color-disabled: ButtonFace; - - --spectrum-actionbutton-border-color-default: HighlightText; - --spectrum-actionbutton-border-color-hover: HighlightText; - --spectrum-actionbutton-border-color-down: HighlightText; - --spectrum-actionbutton-border-color-focus: HighlightText; - --spectrum-actionbutton-border-color-disabled: GrayText; - - --spectrum-actionbutton-content-color-default: HighlightText; - --spectrum-actionbutton-content-color-hover: HighlightText; - --spectrum-actionbutton-content-color-down: HighlightText; - --spectrum-actionbutton-content-color-focus: HighlightText; - --spectrum-actionbutton-content-color-disabled: GrayText; - } + &:after { + /* make sure focus-ring renders */ + forced-color-adjust: none; } - .spectrum-ActionButton--quiet { - --spectrum-actionbutton-background-color: ButtonFace; - --spectrum-actionbutton-background-color-hover: ButtonFace; - --spectrum-actionbutton-background-color-down: ButtonFace; - --spectrum-actionbutton-background-color-focus: ButtonFace; - --spectrum-actionbutton-background-color-disabled: ButtonFace; - - --spectrum-actionbutton-border-color-default: ButtonFace; - --spectrum-actionbutton-border-color-hover: ButtonFace; - --spectrum-actionbutton-border-color-down: ButtonFace; - --spectrum-actionbutton-border-color-focus: Highlight; - --spectrum-actionbutton-border-color-disabled: ButtonFace; - - --spectrum-actionbutton-content-color-default: ButtonText; - --spectrum-actionbutton-content-color-hover: ButtonText; - --spectrum-actionbutton-content-color-down: ButtonText; - --spectrum-actionbutton-content-color-focus: ButtonText; - --spectrum-actionbutton-content-color-disabled: GrayText; + /* force a more visible focus-ring color */ + --custom-actionbutton-focus-ring-color: ButtonText; - &.is-selected { - --spectrum-actionbutton-background-color-default: Highlight; - --spectrum-actionbutton-background-color-hover: Highlight; - --spectrum-actionbutton-background-color-down: Highlight; - --spectrum-actionbutton-background-color-focus: Highlight; - --spectrum-actionbutton-background-color-disabled: ButtonFace; - - --spectrum-actionbutton-border-color-default: HighlightText; - --spectrum-actionbutton-border-color-hover: HighlightText; - --spectrum-actionbutton-border-color-down: HighlightText; - --spectrum-actionbutton-border-color-focus: HighlightText; - --spectrum-actionbutton-border-color-disabled: GrayText; - - --spectrum-actionbutton-content-color-default: HighlightText; - --spectrum-actionbutton-content-color-hover: HighlightText; - --spectrum-actionbutton-content-color-down: HighlightText; - --spectrum-actionbutton-content-color-focus: HighlightText; - --spectrum-actionbutton-content-color-disabled: GrayText; - } - } - - /* - &.spectrum-ActionButton--quiet { - &.spectrum-ActionButton--emphasized { - &:not(:disabled, .is-disabled) { - &:hover { - background-color: var(--spectrum-actionbutton-m-emphasized-textonly-background-color-selected-hover); - border-color: var(--spectrum-actionbutton-m-emphasized-textonly-border-color-selected-hover); - color: var(--spectrum-actionbutton-m-emphasized-textonly-text-color-selected-hover); - } - - &.is-active { - background-color: var(--spectrum-actionbutton-m-emphasized-textonly-background-color-selected-down); - border-color: var(--spectrum-actionbutton-m-emphasized-textonly-border-color-selected-down); - color: var(--spectrum-actionbutton-m-emphasized-textonly-text-color-selected-down); - } - } + &.is-selected { + --custom-actionbutton-background-color-default: Highlight; + --custom-actionbutton-background-color-hover: Highlight; + --custom-actionbutton-background-color-focus: Highlight; + --custom-actionbutton-background-color-down: Highlight; + --custom-actionbutton-background-color-disabled: ButtonFace; + + --custom-actionbutton-border-color-default: HighlightText; + --custom-actionbutton-border-color-hover: HighlightText; + --custom-actionbutton-border-color-focus: HighlightText; + --custom-actionbutton-border-color-down: HighlightText; + --custom-actionbutton-border-color-disabled: GrayText; + + --custom-actionbutton-content-color-default: HighlightText; + --custom-actionbutton-content-color-hover: HighlightText; + --custom-actionbutton-content-color-focus: HighlightText; + --custom-actionbutton-content-color-down: HighlightText; + --custom-actionbutton-content-color-disabled: GrayText; + + .spectrum-ActionButton-icon, + .spectrum-ActionButton-hold, + .spectrum-ActionButton-label { + /* ensure custom text colors from above get applied */ + /* it seems like this shouldn't have to be done, but colors are wrong without it */ + forced-color-adjust: none; } } - */ } } diff --git a/components/actionbutton/metadata/actionbutton.yml b/components/actionbutton/metadata/actionbutton.yml index 731cb619cdf..882b7431fdf 100644 --- a/components/actionbutton/metadata/actionbutton.yml +++ b/components/actionbutton/metadata/actionbutton.yml @@ -1264,24 +1264,30 @@ examples: name: Customized markup: |