From e16cdeaae5538a532c568e4b232d9ed0c983bb50 Mon Sep 17 00:00:00 2001 From: Marissa Huysentruyt Date: Thu, 13 Feb 2025 16:32:39 -0500 Subject: [PATCH] fix(statuslight): remove accent variant - removes --spectrum-statuslight-semantic-accent-color from CSS - removes deprecated accent variant from template and tests - adds changeset - update metadata.json --- .changeset/small-impalas-search.md | 10 ++++++++++ components/statuslight/dist/metadata.json | 2 -- components/statuslight/index.css | 6 ++---- components/statuslight/stories/statuslight.test.js | 2 +- components/statuslight/stories/template.js | 2 -- 5 files changed, 13 insertions(+), 9 deletions(-) create mode 100644 .changeset/small-impalas-search.md diff --git a/.changeset/small-impalas-search.md b/.changeset/small-impalas-search.md new file mode 100644 index 00000000000..53317c408e0 --- /dev/null +++ b/.changeset/small-impalas-search.md @@ -0,0 +1,10 @@ +--- +"@spectrum-css/statuslight": patch +--- + +Removes references to the accent variant, since the accent status light was deprecated in S2. + +Removed variant: + +`.spectrum-StatusLight--accent` +`--spectrum-statuslight-semantic-accent-color` diff --git a/components/statuslight/dist/metadata.json b/components/statuslight/dist/metadata.json index f48621da4c8..13c313b8342 100644 --- a/components/statuslight/dist/metadata.json +++ b/components/statuslight/dist/metadata.json @@ -120,7 +120,6 @@ "--spectrum-statuslight-nonsemantic-silver-color", "--spectrum-statuslight-nonsemantic-turquoise-color", "--spectrum-statuslight-nonsemantic-yellow-color", - "--spectrum-statuslight-semantic-accent-color", "--spectrum-statuslight-semantic-info-color", "--spectrum-statuslight-semantic-negative-color", "--spectrum-statuslight-semantic-neutral-color", @@ -134,7 +133,6 @@ "--spectrum-statuslight-subdued-content-color-default" ], "global": [ - "--spectrum-accent-visual-color", "--spectrum-blue-visual-color", "--spectrum-border-width-100", "--spectrum-brown-visual-color", diff --git a/components/statuslight/index.css b/components/statuslight/index.css index f1788a51779..db4a4f57e4d 100644 --- a/components/statuslight/index.css +++ b/components/statuslight/index.css @@ -111,7 +111,6 @@ --spectrum-statuslight-content-color-default: var(--spectrum-neutral-content-color-default); --spectrum-statuslight-subdued-content-color-default: var(--spectrum-neutral-subdued-content-color-default); --spectrum-statuslight-semantic-neutral-color: var(--spectrum-neutral-visual-color); - --spectrum-statuslight-semantic-accent-color: var(--spectrum-accent-visual-color); --spectrum-statuslight-semantic-negative-color: var(--spectrum-negative-visual-color); --spectrum-statuslight-semantic-info-color: var(--spectrum-informative-visual-color); --spectrum-statuslight-semantic-notice-color: var(--spectrum-notice-visual-color); @@ -159,6 +158,7 @@ /* Dot */ &::before { + --spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label))); content: ""; flex-grow: 0; flex-shrink: 0; @@ -166,8 +166,6 @@ inline-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size)); block-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size)); border-radius: var(--mod-statuslight-corner-radius, var(--spectrum-statuslight-corner-radius)); - - --spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label))); margin-block-start: var(--spectrum-statuslight-spacing-computed-top-to-dot); margin-inline-end: var(--mod-statuslight-spacing-dot-to-label, var(--spectrum-statuslight-spacing-dot-to-label)); } @@ -277,9 +275,9 @@ @media (forced-colors: active) { .spectrum-StatusLight { - forced-color-adjust: none; --highcontrast-statuslight-content-color-default: CanvasText; --highcontrast-statuslight-subdued-content-color-default: CanvasText; + forced-color-adjust: none; /* Dot */ &::before { diff --git a/components/statuslight/stories/statuslight.test.js b/components/statuslight/stories/statuslight.test.js index 9cfab9c3094..7fc72a9ce6b 100644 --- a/components/statuslight/stories/statuslight.test.js +++ b/components/statuslight/stories/statuslight.test.js @@ -4,7 +4,7 @@ import { Template } from "./template.js"; export const StatusLightGroup = Variants({ Template, testData: [ - ...["accent", "info", "positive", "negative", "notice", "neutral"].map((variant) => ({ + ...["info", "positive", "negative", "notice", "neutral"].map((variant) => ({ testHeading: variant.charAt(0).toUpperCase() + variant.slice(1), variant, })), diff --git a/components/statuslight/stories/template.js b/components/statuslight/stories/template.js index 2faf35797c8..be01af383ba 100644 --- a/components/statuslight/stories/template.js +++ b/components/statuslight/stories/template.js @@ -27,12 +27,10 @@ export const Template = ({ `; -// TODO: the accent variant will be removed in S2. export const SemanticGroup = (args, context) => Container({ withBorder: false, direction: "column", content: html`${[ - "accent", "neutral", "info", "negative",