From 78085d585c41476e2e33797292da39ef118b6e6b Mon Sep 17 00:00:00 2001 From: Cory Dransfeldt Date: Wed, 11 Jun 2025 14:09:15 -0700 Subject: [PATCH 1/3] fix(alertbanner): updates alertbanner test file to restore text and action button label control functionality --- .changeset/honest-lamps-wait.md | 5 +++ .../stories/alertbanner.stories.js | 2 +- .../alertbanner/stories/alertbanner.test.js | 34 ++----------------- 3 files changed, 8 insertions(+), 33 deletions(-) create mode 100644 .changeset/honest-lamps-wait.md diff --git a/.changeset/honest-lamps-wait.md b/.changeset/honest-lamps-wait.md new file mode 100644 index 00000000000..ff689e942d2 --- /dev/null +++ b/.changeset/honest-lamps-wait.md @@ -0,0 +1,5 @@ +--- +"@spectrum-css/alertbanner": patch +--- + +Updates alertbanner test file to restore text and action button label control functionality diff --git a/components/alertbanner/stories/alertbanner.stories.js b/components/alertbanner/stories/alertbanner.stories.js index c6d638008c2..c10a0ed2a7d 100644 --- a/components/alertbanner/stories/alertbanner.stories.js +++ b/components/alertbanner/stories/alertbanner.stories.js @@ -61,7 +61,7 @@ export default { isOpen: false, variant: "neutral", actionButtonText: "Action", - text: "Your trial has expired", + text: "Alert banner message. Use a short phrase to describe what's happening.", showCloseButton: true, }, parameters: { diff --git a/components/alertbanner/stories/alertbanner.test.js b/components/alertbanner/stories/alertbanner.test.js index a4440153b6b..34234bf362a 100644 --- a/components/alertbanner/stories/alertbanner.test.js +++ b/components/alertbanner/stories/alertbanner.test.js @@ -1,38 +1,8 @@ -import { Container, Variants } from "@spectrum-css/preview/decorators"; +import { Variants } from "@spectrum-css/preview/decorators"; import { Template } from "./template.js"; -/** - * Examples of options for contextual action button and close button. - */ -export const AlertBannerVariantsTemplate = (args, context) => Container({ - withBorder: false, - direction: "column", - containerStyles: { "align-items": "stretch" }, - wrapperStyles: { "align-items": "stretch" }, - content: [ - Template({ - ...args, - variant: "neutral", - text: "Alert banner message. Use a short phrase to describe what's happening.", - actionButtonText: "Action", - }, context), - Template({ - ...args, - variant: "info", - text: "Alert banner message. Use a short phrase to describe what's happening.", - actionButtonText: "Action", - }, context), - Template({ - ...args, - variant: "negative", - text: "Alert banner message. Use a short phrase to describe what's happening.", - actionButtonText: "Action", - }, context), - ], -}, context); - export const AlertBannerGroup = Variants({ - Template: AlertBannerVariantsTemplate, + Template: Template, TestTemplate: Template, stateDirection: "column", wrapperStyles: { From dcf85bd1bba65d580fc12c6d51642f7440cc5908 Mon Sep 17 00:00:00 2001 From: Cory Dransfeldt Date: Thu, 12 Jun 2025 07:52:01 -0700 Subject: [PATCH 2/3] chore(alertbanner): remove unnecessary changeset --- .changeset/honest-lamps-wait.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/honest-lamps-wait.md diff --git a/.changeset/honest-lamps-wait.md b/.changeset/honest-lamps-wait.md deleted file mode 100644 index ff689e942d2..00000000000 --- a/.changeset/honest-lamps-wait.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@spectrum-css/alertbanner": patch ---- - -Updates alertbanner test file to restore text and action button label control functionality From 634d586b960215473aa68b08ba883de87485ec93 Mon Sep 17 00:00:00 2001 From: Cory Dransfeldt Date: Thu, 12 Jun 2025 07:55:15 -0700 Subject: [PATCH 3/3] chore(alertbanner): revert story text; simplify banner arg --- components/alertbanner/stories/alertbanner.stories.js | 2 +- components/alertbanner/stories/alertbanner.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/components/alertbanner/stories/alertbanner.stories.js b/components/alertbanner/stories/alertbanner.stories.js index c10a0ed2a7d..c6d638008c2 100644 --- a/components/alertbanner/stories/alertbanner.stories.js +++ b/components/alertbanner/stories/alertbanner.stories.js @@ -61,7 +61,7 @@ export default { isOpen: false, variant: "neutral", actionButtonText: "Action", - text: "Alert banner message. Use a short phrase to describe what's happening.", + text: "Your trial has expired", showCloseButton: true, }, parameters: { diff --git a/components/alertbanner/stories/alertbanner.test.js b/components/alertbanner/stories/alertbanner.test.js index 34234bf362a..0b86e7fbfaa 100644 --- a/components/alertbanner/stories/alertbanner.test.js +++ b/components/alertbanner/stories/alertbanner.test.js @@ -2,7 +2,7 @@ import { Variants } from "@spectrum-css/preview/decorators"; import { Template } from "./template.js"; export const AlertBannerGroup = Variants({ - Template: Template, + Template, TestTemplate: Template, stateDirection: "column", wrapperStyles: {